From 1dc35774bf28a2b47c7e40e0c170d508893a761c Mon Sep 17 00:00:00 2001
From: Miika Pekkarinen <miipekk@ihme.org>
Date: Thu, 21 Sep 2006 17:16:35 +0000
Subject: Increased maximum number of menus to 16 and avoiding a crash.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11019 a1c6a512-1295-4272-9138-f99709370657
---
 apps/tagtree.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

(limited to 'apps/tagtree.c')

diff --git a/apps/tagtree.c b/apps/tagtree.c
index d03623b295..06239c4458 100644
--- a/apps/tagtree.c
+++ b/apps/tagtree.c
@@ -107,9 +107,6 @@ struct menu_entry {
     int link;
 };
 
-#define TAGNAVI_VERSION    "#! rockbox/tagbrowser/2.0"
-#define TAGMENU_MAX_ITEMS  32
-#define TAGMENU_MAX_MENUS  8
 struct root_menu {
     char title[64];
     char id[32];
@@ -596,7 +593,10 @@ static bool parse_menu(const char *filename)
     int i;
 
     if (menu_count >= TAGMENU_MAX_MENUS)
+    {
+        logf("max menucount reached");
         return false;
+    }
     
     fd = open(filename, O_RDONLY);
     if (fd < 0)
@@ -659,6 +659,12 @@ static bool parse_menu(const char *filename)
                     break;
                 
                 case var_menu_start:
+                    if (menu_count >= TAGMENU_MAX_MENUS)
+                    {
+                        logf("max menucount reached");
+                        return false;
+                    }
+    
                     if (get_token_str(menu->id, sizeof(menu->id)) < 0)
                     {
                         logf("%menu_start id empty");
@@ -693,6 +699,12 @@ static bool parse_menu(const char *filename)
             continue;
         }
         
+        if (menu->itemcount >= TAGMENU_MAX_ITEMS)
+        {
+            logf("max itemcount reached");
+            continue;
+        }
+        
         /* Allocate */
         if (menu->items[menu->itemcount] == NULL)
         {
-- 
cgit v1.2.3