From f6c719d7ec71cc7771c46d3daa390924a3871ba3 Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Mon, 14 Nov 2022 11:32:34 -0500 Subject: replace strlcpy with strmemccpy replace applicable calls to strlcpy with calls to strmemccpy which null terminates on truncation in theory the strmemccpy calls should be slightly faster since they don't traverse the rest of the source string on truncation but I seriously doubt there is too much of that going on in the code base Change-Id: Ia0251514e36a6242bbf3f03c5e0df123aba60ed2 --- apps/settings_list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'apps/settings_list.c') diff --git a/apps/settings_list.c b/apps/settings_list.c index f54738163a..f733ee4f69 100644 --- a/apps/settings_list.c +++ b/apps/settings_list.c @@ -624,11 +624,11 @@ static char* qs_write_to_cfg(void* setting, char*buf, int buf_len) int index = *(int*)setting; if (index < 0 || index >= nb_settings) { - strlcpy(buf, "-", buf_len); + strmemccpy(buf, "-", buf_len); return buf; } const struct settings_list *var = &settings[index]; - strlcpy(buf, var->cfg_name, buf_len); + strmemccpy(buf, var->cfg_name, buf_len); return buf; } static bool qs_is_changed(void* setting, void* defaultval) -- cgit v1.2.3