From 6b87bfadfff6c44722f8ffe5227c05c41b1b47c8 Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Wed, 14 Dec 2022 03:06:04 -0500 Subject: wps.c cleanup gui_show_wps remove some old cruft move a few things around clean-up flow Change-Id: I138c6cd9e2d58ef526eb686333da413819df725d --- apps/playlist_viewer.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'apps/playlist_viewer.c') diff --git a/apps/playlist_viewer.c b/apps/playlist_viewer.c index 4c57d1a5ce..80239367e4 100644 --- a/apps/playlist_viewer.c +++ b/apps/playlist_viewer.c @@ -143,7 +143,7 @@ static void format_line(const struct playlist_entry* track, char* str, static bool update_playlist(bool force); static enum pv_onplay_result onplay_menu(int index); -static void close_playlist_viewer(bool pop_activity); +static void close_playlist_viewer(void); static void playlist_buffer_init(struct playlist_buffer *pb, char *names_buffer, int names_buffer_size) @@ -525,12 +525,12 @@ static enum pv_onplay_result show_track_info(const struct playlist_entry *curren static enum pv_onplay_result open_with(const struct playlist_entry *current_track) { char selected_track[MAX_PATH]; - close_playlist_viewer(false); /* don't pop activity yet – relevant for plugin_load */ + close_playlist_viewer(); /* don't pop activity yet – relevant for plugin_load */ strmemccpy(selected_track, current_track->name, sizeof(selected_track)); int plugin_return = filetype_list_viewers(selected_track); - pop_current_activity(ACTIVITY_REFRESH_DEFERRED); + pop_current_activity_without_refresh(); switch (plugin_return) { @@ -548,11 +548,11 @@ static enum pv_onplay_result open_with(const struct playlist_entry *current_trac static enum pv_onplay_result open_pictureflow(const struct playlist_entry *current_track) { char selected_track[MAX_PATH]; - close_playlist_viewer(false); /* don't pop activity yet – relevant for plugin_load */ + close_playlist_viewer(); /* don't pop activity yet – relevant for plugin_load */ strmemccpy(selected_track, current_track->name, sizeof(selected_track)); int plugin_return = filetype_load_plugin((void *)"pictureflow", selected_track); - pop_current_activity(ACTIVITY_REFRESH_DEFERRED); + pop_current_activity_without_refresh(); switch (plugin_return) { @@ -1093,15 +1093,14 @@ enum playlist_viewer_result playlist_viewer_ex(const char* filename, } exit: - close_playlist_viewer(true); + pop_current_activity_without_refresh(); + close_playlist_viewer(); return ret; } -static void close_playlist_viewer(bool pop_activity) +static void close_playlist_viewer(void) { talk_shutup(); - if (pop_activity) - pop_current_activity(ACTIVITY_REFRESH_DEFERRED); if (viewer.playlist) { if (viewer.initial_selection) -- cgit v1.2.3