From f0c208554c5ccf628965c0b4b1415ac04789876e Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Tue, 24 Sep 2024 03:14:49 -0400 Subject: [BugFix] Playback.c OOM with large voice file with our large voice file being loaded in its entirety to the buffer there isn't enough room to allocate the required pcm buffer well prior to this patch we looked for 1k free to allow the talk buffer to be given away well the pcm buffer expects something like 5-600 kb on the clipzip and there is 1k allocatable but not 300 more so instead get the required pcm buffer size and check against that Change-Id: I40a056e4170c37bc3429f0cb37af221ae7f812e5 --- apps/pcmbuf.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'apps/pcmbuf.c') diff --git a/apps/pcmbuf.c b/apps/pcmbuf.c index 773e97cce0..b32cb4c429 100644 --- a/apps/pcmbuf.c +++ b/apps/pcmbuf.c @@ -580,6 +580,12 @@ static void init_buffer_state(void) chunk_transidx = INVALID_BUF_INDEX; } +/* call prior to init to get bytes required */ +size_t pcmbuf_size_reqd(void) +{ + return get_next_required_pcmbuf_chunks() * PCMBUF_CHUNK_SIZE; +} + /* Initialize the PCM buffer. The structure looks like this: * ...|---------PCMBUF---------|GUARDBUF|DESCS| */ size_t pcmbuf_init(void *bufend) -- cgit v1.2.3