From b9bf6cdb2c400ccfa0c00999468dbd2b1f0ac8d3 Mon Sep 17 00:00:00 2001 From: Frank Gevaerts Date: Tue, 21 Feb 2012 14:59:52 +0100 Subject: Call skinlist_set_cfg() unconditionally, i.e. also if do_refresh==false This call is cheap (except if the list config changes, but then it should be called anyway), and do_refresh isn't always set appropriately, e.g. when the screen has just changed, which could cause the list config to be null at bad times, which caused the standard list to be shown instead of the desired skinned list. Change-Id: I47dd2552d6d1062456ede4529c4891e80a8159ea Reviewed-on: http://gerrit.rockbox.org/113 Reviewed-by: Frank Gevaerts --- apps/gui/skin_engine/skin_render.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'apps/gui') diff --git a/apps/gui/skin_engine/skin_render.c b/apps/gui/skin_engine/skin_render.c index f86b161eab..80d8c83d27 100644 --- a/apps/gui/skin_engine/skin_render.c +++ b/apps/gui/skin_engine/skin_render.c @@ -165,9 +165,8 @@ static bool do_non_text_tags(struct gui_wps *gwps, struct skin_draw_info *info, break; #ifdef HAVE_LCD_BITMAP case SKIN_TOKEN_LIST_ITEM_CFG: - if (do_refresh) - skinlist_set_cfg(gwps->display->screen_type, - SKINOFFSETTOPTR(skin_buffer, token->value.data)); + skinlist_set_cfg(gwps->display->screen_type, + SKINOFFSETTOPTR(skin_buffer, token->value.data)); break; case SKIN_TOKEN_UIVIEWPORT_ENABLE: sb_set_info_vp(gwps->display->screen_type, token->value.data); -- cgit v1.2.3