From d4d3f3c494e48304d41eada0a4881a9d2b4b97f4 Mon Sep 17 00:00:00 2001 From: Thomas Martitz Date: Fri, 10 Jan 2014 21:50:37 +0100 Subject: skin engine: Fix FS#12884. The %Vf and %Vb tags change the colors for the rest of the viewport. This requires the rest of the vp to be redrawn when they change due to a conditional. The previous code did this redraw in all cases (conditional or not) which led to visible blinking. Change-Id: Ie59dfc6fe8ed76485a2a2bd7caf1315f1944c227 --- apps/gui/skin_engine/skin_parser.c | 8 -------- 1 file changed, 8 deletions(-) (limited to 'apps/gui/skin_engine/skin_parser.c') diff --git a/apps/gui/skin_engine/skin_parser.c b/apps/gui/skin_engine/skin_parser.c index 1946e179c0..1de1047583 100644 --- a/apps/gui/skin_engine/skin_parser.c +++ b/apps/gui/skin_engine/skin_parser.c @@ -700,15 +700,9 @@ static int parse_viewportcolour(struct skin_element *element, if (element->line == curr_viewport_element->line) { if (token->type == SKIN_TOKEN_VIEWPORT_FGCOLOUR) - { - curr_vp->start_fgcolour = colour->colour; curr_vp->vp.fg_pattern = colour->colour; - } else - { - curr_vp->start_bgcolour = colour->colour; curr_vp->vp.bg_pattern = colour->colour; - } } return 0; } @@ -1953,8 +1947,6 @@ static int convert_viewport(struct wps_data *data, struct skin_element* element) #if (LCD_DEPTH > 1) || (defined(HAVE_REMOTE_LCD) && (LCD_REMOTE_DEPTH > 1)) skin_vp->output_to_backdrop_buffer = false; - skin_vp->start_fgcolour = skin_vp->vp.fg_pattern; - skin_vp->start_bgcolour = skin_vp->vp.bg_pattern; #endif #ifdef HAVE_LCD_COLOR skin_vp->start_gradient.start = global_settings.lss_color; -- cgit v1.2.3