From 479414faccedeeb1ca7d0b6074bd69f2ef6dd441 Mon Sep 17 00:00:00 2001 From: Nils Wallménius Date: Mon, 27 Dec 2010 09:49:33 +0000 Subject: Fix profiling on coldfire with newer Gcc. In switch_thread, make the call to profile_thread_stopped from an inline asm block to make sure the sp is pointing to the right place before storing the context. This apparently worked by luck with the old Gcc. The workaround used for coldfire in the codeclib's __cyg_profile_func_enter does not work with newer gcc, however the workaround isn't needed for those so enable it only for coldfire gcc version < 4. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28908 a1c6a512-1295-4272-9138-f99709370657 --- apps/codecs/lib/codeclib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'apps/codecs') diff --git a/apps/codecs/lib/codeclib.c b/apps/codecs/lib/codeclib.c index 329b0e2136..5af4e01fff 100644 --- a/apps/codecs/lib/codeclib.c +++ b/apps/codecs/lib/codeclib.c @@ -163,7 +163,9 @@ const uint8_t bs_clz_tab[256] ICONST_ATTR = { #ifdef RB_PROFILE void __cyg_profile_func_enter(void *this_fn, void *call_site) { -#ifdef CPU_COLDFIRE +/* This workaround is required for coldfire gcc 3.4 but is broken for 4.4 + and 4.5, but for those the other way works. */ +#if defined(CPU_COLDFIRE) && defined(__GNUC__) && __GNUC__ < 4 (void)call_site; ci->profile_func_enter(this_fn, __builtin_return_address(1)); #else -- cgit v1.2.3