From 0a1d7c28b7e9da555d26d489cde2da26e2cc9ca0 Mon Sep 17 00:00:00 2001 From: Thomas Martitz Date: Thu, 6 May 2010 17:35:13 +0000 Subject: Make open() posix compliant api-wise. A few calls (those with O_CREAT) need the additional optional mode parameter so add it. Impact for the core is almost zero, as open() is a wrapper macro for the real open function which doesn't take the variable parameter. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25844 a1c6a512-1295-4272-9138-f99709370657 --- apps/codecs/aiff_enc.c | 2 +- apps/codecs/libcook/main.c | 2 +- apps/codecs/libffmpegFLAC/main.c | 2 +- apps/codecs/libspc/spc_profiler.c | 2 +- apps/codecs/mp3_enc.c | 2 +- apps/codecs/nsf.c | 2 +- apps/codecs/wav_enc.c | 2 +- apps/codecs/wavpack_enc.c | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) (limited to 'apps/codecs') diff --git a/apps/codecs/aiff_enc.c b/apps/codecs/aiff_enc.c index 87358f3df8..f728d6f6a5 100644 --- a/apps/codecs/aiff_enc.c +++ b/apps/codecs/aiff_enc.c @@ -136,7 +136,7 @@ static bool on_start_file(struct enc_file_event_data *data) if ((data->chunk->flags & CHUNKF_ERROR) || *data->filename == '\0') return false; - data->rec_file = ci->open(data->filename, O_RDWR|O_CREAT|O_TRUNC); + data->rec_file = ci->open(data->filename, O_RDWR|O_CREAT|O_TRUNC, 0666); if (data->rec_file < 0) return false; diff --git a/apps/codecs/libcook/main.c b/apps/codecs/libcook/main.c index 71d02fb736..25e263dd60 100644 --- a/apps/codecs/libcook/main.c +++ b/apps/codecs/libcook/main.c @@ -171,7 +171,7 @@ int main(int argc, char *argv[]) /* output raw audio frames that are sent to the decoder into separate files */ #ifdef DUMP_RAW_FRAMES snprintf(filename,sizeof(filename),"dump%d.raw",++x); - fd_out = open(filename,O_WRONLY|O_CREAT|O_APPEND); + fd_out = open(filename,O_WRONLY|O_CREAT|O_APPEND, 0666); write(fd_out,pkt.frames[i],sps); close(fd_out); #endif diff --git a/apps/codecs/libffmpegFLAC/main.c b/apps/codecs/libffmpegFLAC/main.c index 5d232a8896..e6d4b2f4fd 100644 --- a/apps/codecs/libffmpegFLAC/main.c +++ b/apps/codecs/libffmpegFLAC/main.c @@ -62,7 +62,7 @@ static unsigned char wav_header[44]={ int open_wav(char* filename) { int fd; - fd=open(filename,O_CREAT|O_WRONLY|O_TRUNC,S_IRUSR|S_IWUSR); + fd=open(filename,O_CREAT|O_WRONLY|O_TRUNC, S_IRUSR|S_IWUSR); if (fd >= 0) { if (write(fd,wav_header,sizeof(wav_header)) < sizeof(wav_header)) { fprintf(stderr,"[ERR} Failed to write wav header\n"); diff --git a/apps/codecs/libspc/spc_profiler.c b/apps/codecs/libspc/spc_profiler.c index 3184ad7b52..0ced8b5bd3 100644 --- a/apps/codecs/libspc/spc_profiler.c +++ b/apps/codecs/libspc/spc_profiler.c @@ -45,7 +45,7 @@ void reset_profile_timers(void) void print_timers(char * path) { - int logfd = ci->open("/spclog.txt",O_WRONLY|O_CREAT|O_APPEND); + int logfd = ci->open("/spclog.txt",O_WRONLY|O_CREAT|O_APPEND, 0666); ci->fdprintf(logfd,"%s:\t",path); ci->fdprintf(logfd,"%10ld total\t",READ_TIMER(total)); PRINT_TIMER_PCT(render,total,"render"); diff --git a/apps/codecs/mp3_enc.c b/apps/codecs/mp3_enc.c index d04b9e6c42..b35702b0d0 100644 --- a/apps/codecs/mp3_enc.c +++ b/apps/codecs/mp3_enc.c @@ -2434,7 +2434,7 @@ static bool on_start_file(struct enc_file_event_data *data) if ((data->chunk->flags & CHUNKF_ERROR) || *data->filename == '\0') return false; - data->rec_file = ci->open(data->filename, O_RDWR|O_CREAT|O_TRUNC); + data->rec_file = ci->open(data->filename, O_RDWR|O_CREAT|O_TRUNC, 0666); if (data->rec_file < 0) return false; diff --git a/apps/codecs/nsf.c b/apps/codecs/nsf.c index 6beb8fe3e6..f596f9dc68 100644 --- a/apps/codecs/nsf.c +++ b/apps/codecs/nsf.c @@ -98,7 +98,7 @@ void reset_profile_timers(void) { int logfd=-1; void print_timers(char * path, int track) { - logfd = ci->open("/nsflog.txt",O_WRONLY|O_CREAT|O_APPEND); + logfd = ci->open("/nsflog.txt",O_WRONLY|O_CREAT|O_APPEND, 0666); ci->fdprintf(logfd,"%s[%d]:\t",path,track); ci->fdprintf(logfd,"%10ld total\t",READ_TIMER(total)); PRINT_TIMER_PCT(cpu,total,"CPU"); diff --git a/apps/codecs/wav_enc.c b/apps/codecs/wav_enc.c index 38230c846b..4cecb0b2b6 100644 --- a/apps/codecs/wav_enc.c +++ b/apps/codecs/wav_enc.c @@ -122,7 +122,7 @@ static bool on_start_file(struct enc_file_event_data *data) if ((data->chunk->flags & CHUNKF_ERROR) || *data->filename == '\0') return false; - data->rec_file = ci->open(data->filename, O_RDWR|O_CREAT|O_TRUNC); + data->rec_file = ci->open(data->filename, O_RDWR|O_CREAT|O_TRUNC, 0666); if (data->rec_file < 0) return false; diff --git a/apps/codecs/wavpack_enc.c b/apps/codecs/wavpack_enc.c index e7da6efa75..7a5f35a53a 100644 --- a/apps/codecs/wavpack_enc.c +++ b/apps/codecs/wavpack_enc.c @@ -227,7 +227,7 @@ static bool on_start_file(struct enc_file_event_data *data) if ((data->chunk->flags & CHUNKF_ERROR) || *data->filename == '\0') return false; - data->rec_file = ci->open(data->filename, O_RDWR|O_CREAT|O_TRUNC); + data->rec_file = ci->open(data->filename, O_RDWR|O_CREAT|O_TRUNC, 0666); if (data->rec_file < 0) return false; -- cgit v1.2.3