From 33914a7dfc82fd6badaf774619539b92f3b7c255 Mon Sep 17 00:00:00 2001 From: Miika Pekkarinen Date: Sat, 21 Jan 2006 08:17:40 +0000 Subject: Fixed the codec loader bug. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8403 a1c6a512-1295-4272-9138-f99709370657 --- apps/codecs.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'apps/codecs.c') diff --git a/apps/codecs.c b/apps/codecs.c index 88b2ea4e07..6720de909c 100644 --- a/apps/codecs.c +++ b/apps/codecs.c @@ -238,13 +238,12 @@ int codec_load_ram(char* codecptr, int size, void* ptr2, int bufwrap, if ((char *)&codecbuf[0] != codecptr) { /* zero out codec buffer to ensure a properly zeroed bss area */ memset(codecbuf, 0, CODEC_SIZE); - + size = MIN(size, CODEC_SIZE); copy_n = MIN(size, bufwrap); memcpy(codecbuf, codecptr, copy_n); - size -= copy_n; - if (size > 0) { - memcpy(&codecbuf[copy_n], ptr2, size); + if (size - copy_n > 0) { + memcpy(&codecbuf[copy_n], ptr2, size - copy_n); } } hdr = (struct codec_header *)codecbuf; @@ -253,7 +252,9 @@ int codec_load_ram(char* codecptr, int size, void* ptr2, int bufwrap, || hdr->magic != CODEC_MAGIC || hdr->target_id != TARGET_ID || hdr->load_addr != codecbuf - || hdr->end_addr > codecbuf + CODEC_SIZE) { + || hdr->end_addr > codecbuf + CODEC_SIZE) + { + logf("codec header error"); return CODEC_ERROR; } #else /* SIMULATOR */ -- cgit v1.2.3