From e57b4f909901ccc04b596ea817a98100b5f7b33b Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Tue, 20 Sep 2022 13:27:51 +0100 Subject: gui: Remove gui_synclist_item_is_onscreen() Only the "Rockbox Info" screen uses it for a rather silly purpose, so remove the function. This helps to decouple things from the GUI. Change-Id: Icf73e3ee1230c75bf43016c0f1c05c7fe1a24895 --- apps/gui/list.c | 7 ------- apps/gui/list.h | 2 -- apps/menus/main_menu.c | 3 +-- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/apps/gui/list.c b/apps/gui/list.c index bb5d1a922e..d15948e97a 100644 --- a/apps/gui/list.c +++ b/apps/gui/list.c @@ -800,13 +800,6 @@ bool list_do_action(int context, int timeout, return gui_synclist_do_button(lists, action); } -bool gui_synclist_item_is_onscreen(struct gui_synclist *lists, - enum screen_type screen, int item) -{ - int nb_lines = list_get_nb_lines(lists, screen); - return (unsigned)(item - lists->start_item[screen]) < (unsigned) nb_lines; -} - /* Simple use list implementation */ static int simplelist_line_count = 0, simplelist_line_remaining; static int simplelist_line_pos; diff --git a/apps/gui/list.h b/apps/gui/list.h index b716d8afd9..ede62d7b0a 100644 --- a/apps/gui/list.h +++ b/apps/gui/list.h @@ -220,8 +220,6 @@ extern void gui_synclist_add_item(struct gui_synclist * lists); extern void gui_synclist_del_item(struct gui_synclist * lists); extern void gui_synclist_set_title(struct gui_synclist * lists, const char * title, enum themable_icons icon); -extern bool gui_synclist_item_is_onscreen(struct gui_synclist *lists, - enum screen_type screen, int item); extern bool gui_synclist_keyclick_callback(int action, void* data); /* diff --git a/apps/menus/main_menu.c b/apps/menus/main_menu.c index 2814c44fe6..03873faac9 100644 --- a/apps/menus/main_menu.c +++ b/apps/menus/main_menu.c @@ -441,8 +441,7 @@ static int info_action_callback(int action, struct gui_synclist *lists) else if (action == ACTION_NONE) { static int last_redraw = 0; - if (gui_synclist_item_is_onscreen(lists, 0, INFO_TIME) - && TIME_AFTER(current_tick, last_redraw + HZ*5)) + if (TIME_AFTER(current_tick, last_redraw + HZ*5)) { last_redraw = current_tick; return ACTION_REDRAW; -- cgit v1.2.3