From b91ad60d6390f20ac7b86e5ae71398cf341d944b Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Tue, 20 Jul 2021 00:04:36 -0400 Subject: timefuncs.c valid_time() should return false if tm == NULL and not try to deref luckily no one has yet.. Change-Id: I4117db84b013fa826958aea635daa0a24ee534b6 --- firmware/common/timefuncs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firmware/common/timefuncs.c b/firmware/common/timefuncs.c index 66854dea13..1405a8d926 100644 --- a/firmware/common/timefuncs.c +++ b/firmware/common/timefuncs.c @@ -86,13 +86,13 @@ static inline int rtc_read_datetime(struct tm *tm) #if CONFIG_RTC bool valid_time(const struct tm *tm) { - if (tm->tm_hour < 0 || tm->tm_hour > 23 || + if (!tm || (tm->tm_hour < 0 || tm->tm_hour > 23 || tm->tm_sec < 0 || tm->tm_sec > 59 || tm->tm_min < 0 || tm->tm_min > 59 || tm->tm_year < 100 || tm->tm_year > 199 || tm->tm_mon < 0 || tm->tm_mon > 11 || tm->tm_wday < 0 || tm->tm_wday > 6 || - tm->tm_mday < 1 || tm->tm_mday > 31) + tm->tm_mday < 1 || tm->tm_mday > 31)) return false; else return true; -- cgit v1.2.3