From b770f639346fa8a40d07b9dcc66b3e378210b0a9 Mon Sep 17 00:00:00 2001 From: Andrew Ryabinin Date: Sat, 9 Nov 2013 21:42:18 +0400 Subject: flac: fix seeking. As comment in code states: "It is possible for our seek to land in the middle of audio data that looks exactly like a frame header from a future version of an encoder. When that happens, frame_sync() will return false. But there is a remote possibility that it is properly synced at such a "future-codec frame", so to make sure, we wait to see several "unparseable" errors in a row before bailing out." Currently we wait for 10 "unparseable" errors. libFLAC waits for 20. But I've got a valid flac+cue, wherein switching to certain track gave me 24 "unparsaeable" errors. Therefore I increased unparseable_count to 30. Change-Id: I4e97a5385c729adf3d5075d41ea312622c69e548 Reviewed-on: http://gerrit.rockbox.org/658 Reviewed-by: Michael Giacomelli Reviewed-by: Boris Gjenero Tested-by: Andrew Ryabinin Reviewed-by: Andrew Ryabinin --- lib/rbcodec/codecs/flac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rbcodec/codecs/flac.c b/lib/rbcodec/codecs/flac.c index 3c5545df08..3390c24a2c 100644 --- a/lib/rbcodec/codecs/flac.c +++ b/lib/rbcodec/codecs/flac.c @@ -352,7 +352,7 @@ static bool flac_seek(FLACContext* fc, uint32_t target_sample) { unsigned unparseable_count; bool got_a_frame = false; for(unparseable_count = 0; !got_a_frame - && unparseable_count < 10; unparseable_count++) { + && unparseable_count < 30; unparseable_count++) { if(frame_sync(fc)) got_a_frame = true; } -- cgit v1.2.3