From b35f82c91ff050b4405b19a3e56e9d031bf940e2 Mon Sep 17 00:00:00 2001 From: Marcin Bukat Date: Tue, 13 Nov 2012 13:33:06 +0100 Subject: HD300: Fix crash in bootloader introduced by 36281c4 Uninitialized struct scroll which is used to pass state between scrollstrip ISR and button_read_device() can bomb out whole button subsytem. Change-Id: I3b415c22cfee4181b2132cddaeff68797c7cc0ea --- firmware/target/coldfire/mpio/hd300/button-hd300.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/firmware/target/coldfire/mpio/hd300/button-hd300.c b/firmware/target/coldfire/mpio/hd300/button-hd300.c index 95de05cbcf..5c817e92bd 100644 --- a/firmware/target/coldfire/mpio/hd300/button-hd300.c +++ b/firmware/target/coldfire/mpio/hd300/button-hd300.c @@ -38,7 +38,10 @@ static volatile struct scroll_state_t { signed char dir; long timeout; bool rel; -} scroll; +} scroll = { .dir = BUTTON_UP, + .timeout = SLIDER_REL_TIMEOUT, + .rel = false, + }; static inline void disable_scrollstrip_interrupts(void) { -- cgit v1.2.3