From ad9835c689575a66f2c6ce1f6efe121642061be8 Mon Sep 17 00:00:00 2001 From: Michael Giacomelli Date: Sun, 30 Aug 2009 03:52:11 +0000 Subject: Logic was backwards on the check for NSF file format. Fix that and save one memcmp. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22559 a1c6a512-1295-4272-9138-f99709370657 --- apps/metadata/nsf.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/apps/metadata/nsf.c b/apps/metadata/nsf.c index a12af14347..e1ad331d75 100644 --- a/apps/metadata/nsf.c +++ b/apps/metadata/nsf.c @@ -28,14 +28,17 @@ bool get_nsf_metadata(int fd, struct mp3entry* id3) id3->vbr = false; id3->filesize = filesize(fd); - if (memcmp(buf,"NESM",4) && memcmp(buf,"NSFE",4)) - { - return false; - } - else if (memcmp(buf, "NESM",4)) /* only NESM contain metadata */ + if (memcmp(buf,"NSFE",4) == 0) /* only NESM contain metadata */ { return true; } + else + { + if (memcmp(buf, "NESM",4) != 0) /* not a valid format*/ + { + return false; + } + } p = id3->id3v2buf; -- cgit v1.2.3