From 72404784578162495c9986cd1563d9924ddc15be Mon Sep 17 00:00:00 2001 From: Rafaël Carré Date: Mon, 20 Sep 2010 16:39:22 +0000 Subject: file_exists(): fix DEBUGF() - %s was missing the argument (function name) - add %p to print the function argument - also don't call strlen() to test string nullity (and strlen() can't return a negative result) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28123 a1c6a512-1295-4272-9138-f99709370657 --- firmware/common/filefuncs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firmware/common/filefuncs.c b/firmware/common/filefuncs.c index 19b8eff612..c31971779d 100644 --- a/firmware/common/filefuncs.c +++ b/firmware/common/filefuncs.c @@ -61,9 +61,9 @@ bool file_exists(const char *file) int fd; #ifdef DEBUG - if (!file || strlen(file) <= 0) + if (!file || !*file) { - DEBUGF("%s(): Invalid parameter!\n"); + DEBUGF("%s(%p): Invalid parameter!\n", __func__, file); return false; } #endif -- cgit v1.2.3