From 6cbcde13b9eb10b50724f956ba5696fc82ed7cf4 Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Sun, 24 Apr 2022 12:43:34 +0100 Subject: skin engine: Fix bug with touch region labeling Auto-created regions associated with a progress bar did not have a label which could result in an out of bounds read when looking up touch regions by label. Fix by initializing the label to NULL. Change-Id: Ic12d697a6a5a45dad977f307471b91db9e607bd5 --- apps/gui/skin_engine/skin_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/gui/skin_engine/skin_parser.c b/apps/gui/skin_engine/skin_parser.c index ac68b0dcba..be25bd0125 100644 --- a/apps/gui/skin_engine/skin_parser.c +++ b/apps/gui/skin_engine/skin_parser.c @@ -1287,6 +1287,7 @@ static int parse_progressbar_tag(struct skin_element* element, region->last_press = -1; region->armed = false; region->bar = PTRTOSKINOFFSET(skin_buffer, pb); + region->label = PTRTOSKINOFFSET(skin_buffer, NULL); item = new_skin_token_list_item(NULL, region); if (!item) -- cgit v1.2.3