From 3b04a85245473a6e0f82ee479ef399bc8163a473 Mon Sep 17 00:00:00 2001 From: Nils Wallménius Date: Sun, 12 Jun 2011 22:17:45 +0000 Subject: Remove a couple of dead inits and assignments found by the clang-static-analyzer. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29996 a1c6a512-1295-4272-9138-f99709370657 --- apps/gui/option_select.c | 1 - apps/gui/skin_engine/skin_render.c | 4 ++-- apps/recorder/bmp.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/apps/gui/option_select.c b/apps/gui/option_select.c index 7f829d26c3..c3246638ab 100644 --- a/apps/gui/option_select.c +++ b/apps/gui/option_select.c @@ -276,7 +276,6 @@ void option_select_next_val(const struct settings_list *setting, else if ((setting->flags & F_CHOICE_SETTING) == F_CHOICE_SETTING) { struct choice_setting *info = (struct choice_setting *)setting->choice_setting; - val = *value + 1; if (!previous) { val = *value + 1; diff --git a/apps/gui/skin_engine/skin_render.c b/apps/gui/skin_engine/skin_render.c index 349dc07d0a..13eb69c744 100644 --- a/apps/gui/skin_engine/skin_render.c +++ b/apps/gui/skin_engine/skin_render.c @@ -559,7 +559,7 @@ bool skin_render_alternator(struct skin_element* element, struct skin_draw_info if (changed_lines) { - struct skin_element *current_line = element->children[alternator->current_line]; + struct skin_element *current_line; int start = alternator->current_line; int try_line = start; bool suitable = false; @@ -687,7 +687,7 @@ void skin_render(struct gui_wps *gwps, unsigned refresh_mode) struct wps_data *data = gwps->data; struct screen *display = gwps->display; - struct skin_element* viewport = data->tree; + struct skin_element* viewport; struct skin_viewport* skin_viewport; int old_refresh_mode = refresh_mode; diff --git a/apps/recorder/bmp.c b/apps/recorder/bmp.c index 528ab3b81c..fc88709afa 100644 --- a/apps/recorder/bmp.c +++ b/apps/recorder/bmp.c @@ -206,7 +206,7 @@ static unsigned int read_part_line(struct bmp_args *ba) uint8_t *ibuf; struct uint8_rgb *buf = (struct uint8_rgb *)(ba->buf); const struct uint8_rgb *palette = ba->palette; - uint32_t component, data = data; + uint32_t component, data; int ret; int i, cols, len; -- cgit v1.2.3