From 1025283042119a1eb691eed977cee466be59f0a4 Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Mon, 23 Jan 2023 16:01:43 +0000 Subject: usb: Fix iPod video connection issues Apparently a response is coming out of nowhere and tripping this check. I can't be bothered to look into it; it would be better to just update the ARC USB driver to the new control request API... Change-Id: Ic5062443e060534f170d3afe17c00d3c25d1d3bd --- firmware/usbstack/usb_core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/firmware/usbstack/usb_core.c b/firmware/usbstack/usb_core.c index 5e50d21383..9fe8b3e603 100644 --- a/firmware/usbstack/usb_core.c +++ b/firmware/usbstack/usb_core.c @@ -1040,10 +1040,15 @@ void usb_drv_control_response(enum usb_control_response resp, unsigned int num_active = num_active_requests--; /* - * There must have been a prior request submission, at least. + * There should have been a prior request submission, at least. + * FIXME: It seems the iPod video can get here and ignoring it + * allows the connection to succeed?? */ if (num_active == 0) - panicf("null ctrl req"); + { + //panicf("null ctrl req"); + return; + } /* * This can happen because an active request was already pending when -- cgit v1.2.3