summaryrefslogtreecommitdiff
path: root/firmware/target/arm
diff options
context:
space:
mode:
Diffstat (limited to 'firmware/target/arm')
-rw-r--r--firmware/target/arm/as3525/backlight-e200v2-fuze.c10
-rw-r--r--firmware/target/arm/as3525/sansa-c200v2/backlight-c200v2.c16
-rw-r--r--firmware/target/arm/as3525/sansa-c200v2/backlight-target.h14
-rw-r--r--firmware/target/arm/as3525/sansa-clip/backlight-target.h12
-rw-r--r--firmware/target/arm/as3525/sansa-clipplus/backlight-clip.c4
-rw-r--r--firmware/target/arm/as3525/sansa-clipplus/backlight-target.h8
-rw-r--r--firmware/target/arm/as3525/sansa-clipv2/backlight-clipv2.c4
-rw-r--r--firmware/target/arm/as3525/sansa-clipv2/backlight-target.h12
-rw-r--r--firmware/target/arm/as3525/sansa-clipzip/backlight-clipzip.c8
-rw-r--r--firmware/target/arm/as3525/sansa-clipzip/backlight-target.h10
-rw-r--r--firmware/target/arm/as3525/sansa-e200v2/backlight-target.h14
-rw-r--r--firmware/target/arm/as3525/sansa-fuze/backlight-target.h14
-rw-r--r--firmware/target/arm/as3525/sansa-fuzev2/backlight-fuzev2.c12
-rw-r--r--firmware/target/arm/as3525/sansa-fuzev2/backlight-target.h14
-rw-r--r--firmware/target/arm/as3525/sansa-m200v4/backlight-target.h8
-rw-r--r--firmware/target/arm/as3525/sd-as3525.c4
-rw-r--r--firmware/target/arm/as3525/system-as3525.c2
-rw-r--r--firmware/target/arm/at91sam/lyre_proto1/backlight-lyre_proto1.c10
-rw-r--r--firmware/target/arm/imx233/creative-zen/backlight-target.h8
-rw-r--r--firmware/target/arm/imx233/creative-zen/backlight-zen.c12
-rw-r--r--firmware/target/arm/imx233/creative-zenxfi2/backlight-target.h8
-rw-r--r--firmware/target/arm/imx233/creative-zenxfi2/backlight-zenxfi2.c12
-rw-r--r--firmware/target/arm/imx233/creative-zenxfi3/backlight-target.h14
-rw-r--r--firmware/target/arm/imx233/creative-zenxfi3/backlight-zenxfi3.c18
-rw-r--r--firmware/target/arm/imx233/samsung-ypz5/backlight-target.h8
-rw-r--r--firmware/target/arm/imx233/samsung-ypz5/backlight-ypz5.c12
-rw-r--r--firmware/target/arm/imx233/sansa-fuzeplus/backlight-fuzeplus.c12
-rw-r--r--firmware/target/arm/imx233/sansa-fuzeplus/backlight-target.h8
-rw-r--r--firmware/target/arm/imx233/sony-nwz/backlight-nwz.c12
-rw-r--r--firmware/target/arm/imx233/sony-nwz/backlight-target.h8
-rw-r--r--firmware/target/arm/imx233/system-imx233.c6
-rw-r--r--firmware/target/arm/imx31/gigabeat-s/backlight-gigabeat-s.c10
-rw-r--r--firmware/target/arm/imx31/gigabeat-s/backlight-target.h8
-rw-r--r--firmware/target/arm/imx31/gigabeat-s/power-gigabeat-s.c2
-rw-r--r--firmware/target/arm/ipod/1g2g/backlight-1g2g.c4
-rw-r--r--firmware/target/arm/ipod/1g2g/backlight-target.h6
-rw-r--r--firmware/target/arm/ipod/3g/backlight-3g.c4
-rw-r--r--firmware/target/arm/ipod/backlight-4g_color.c12
-rw-r--r--firmware/target/arm/ipod/backlight-nano_video.c6
-rw-r--r--firmware/target/arm/ipod/backlight-target.h44
-rw-r--r--firmware/target/arm/ipod/button-1g-3g.c8
-rw-r--r--firmware/target/arm/ipod/button-mini1g.c8
-rw-r--r--firmware/target/arm/ipod/lcd-color_nano.c2
-rw-r--r--firmware/target/arm/iriver/backlight-target.h6
-rw-r--r--firmware/target/arm/iriver/h10/backlight-h10.c4
-rw-r--r--firmware/target/arm/olympus/mrobe-100/backlight-mr100.c12
-rw-r--r--firmware/target/arm/olympus/mrobe-100/backlight-target.h25
-rw-r--r--firmware/target/arm/olympus/mrobe-100/lcd-remote-mr100.c4
-rw-r--r--firmware/target/arm/pbell/vibe500/backlight-target.h14
-rw-r--r--firmware/target/arm/pbell/vibe500/backlight-vibe500.c12
-rw-r--r--firmware/target/arm/philips/hdd1630/backlight-hdd1630.c12
-rw-r--r--firmware/target/arm/philips/hdd1630/backlight-target.h14
-rw-r--r--firmware/target/arm/philips/hdd6330/backlight-hdd6330.c12
-rw-r--r--firmware/target/arm/philips/hdd6330/backlight-target.h14
-rw-r--r--firmware/target/arm/philips/power-hdd.c2
-rw-r--r--firmware/target/arm/philips/sa9200/backlight-sa9200.c14
-rw-r--r--firmware/target/arm/philips/sa9200/backlight-target.h12
-rw-r--r--firmware/target/arm/pnx0101/backlight-target.h6
-rw-r--r--firmware/target/arm/pnx0101/iriver-ifp7xx/backlight-ifp7xx.c4
-rw-r--r--firmware/target/arm/rk27xx/backlight-rk27xx.c8
-rw-r--r--firmware/target/arm/rk27xx/backlight-target.h8
-rw-r--r--firmware/target/arm/s3c2440/gigabeat-fx/backlight-meg-fx.c14
-rw-r--r--firmware/target/arm/s3c2440/gigabeat-fx/backlight-target.h14
-rw-r--r--firmware/target/arm/s3c2440/gigabeat-fx/power-meg-fx.c4
-rw-r--r--firmware/target/arm/s3c2440/mini2440/backlight-mini2440.c16
-rw-r--r--firmware/target/arm/s3c2440/mini2440/backlight-target.h8
-rw-r--r--firmware/target/arm/s5l8700/backlight-meizu.c12
-rw-r--r--firmware/target/arm/s5l8700/backlight-target.h8
-rw-r--r--firmware/target/arm/s5l8700/ipodnano2g/backlight-nano2g.c10
-rw-r--r--firmware/target/arm/s5l8700/yps3/backlight-target.h12
-rw-r--r--firmware/target/arm/s5l8700/yps3/backlight-yps3.c18
-rw-r--r--firmware/target/arm/s5l8702/ipod6g/backlight-ipod6g.c12
-rw-r--r--firmware/target/arm/s5l8702/ipod6g/backlight-target.h8
-rw-r--r--firmware/target/arm/samsung/backlight-target.h6
-rw-r--r--firmware/target/arm/samsung/yh820/backlight-yh820.c4
-rw-r--r--firmware/target/arm/samsung/yh920/backlight-yh920.c4
-rw-r--r--firmware/target/arm/samsung/yh925/backlight-yh925.c4
-rw-r--r--firmware/target/arm/sandisk/backlight-c200_e200.c14
-rw-r--r--firmware/target/arm/sandisk/backlight-target.h12
-rw-r--r--firmware/target/arm/sandisk/sansa-e200/button-e200.c8
-rw-r--r--firmware/target/arm/sandisk/sansa-view/backlight-target.h8
-rw-r--r--firmware/target/arm/sandisk/sansa-view/backlight-view.c12
-rw-r--r--firmware/target/arm/tatung/tpj1022/backlight-target.h6
-rw-r--r--firmware/target/arm/tatung/tpj1022/backlight-tpj1022.c4
-rw-r--r--firmware/target/arm/tcc77x/c100/backlight-target.h6
-rw-r--r--firmware/target/arm/tcc77x/iaudio7/backlight-target.h6
-rw-r--r--firmware/target/arm/tcc77x/logikdax/backlight-target.h6
-rw-r--r--firmware/target/arm/tcc77x/m200/backlight-target.h6
-rw-r--r--firmware/target/arm/tcc780x/cowond2/backlight-cowond2.c12
-rw-r--r--firmware/target/arm/tcc780x/cowond2/backlight-target.h8
-rw-r--r--firmware/target/arm/tcc780x/cowond2/button-cowond2.c2
-rw-r--r--firmware/target/arm/tcc780x/cowond2/power-cowond2.c2
-rw-r--r--firmware/target/arm/tms320dm320/creative-zvm/backlight-target.h8
-rw-r--r--firmware/target/arm/tms320dm320/mrobe-500/backlight-mr500.c12
-rw-r--r--firmware/target/arm/tms320dm320/mrobe-500/backlight-target.h8
-rw-r--r--firmware/target/arm/tms320dm320/mrobe-500/lcd-remote-mr500.c4
-rw-r--r--firmware/target/arm/tms320dm320/mrobe-500/power-mr500.c2
-rw-r--r--firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c6
-rw-r--r--firmware/target/arm/tms320dm320/sansa-connect/backlight-sansaconnect.c12
-rw-r--r--firmware/target/arm/tms320dm320/sansa-connect/backlight-target.h8
100 files changed, 467 insertions, 470 deletions
diff --git a/firmware/target/arm/as3525/backlight-e200v2-fuze.c b/firmware/target/arm/as3525/backlight-e200v2-fuze.c
index 91e1ef4d0c..26602fcee6 100644
--- a/firmware/target/arm/as3525/backlight-e200v2-fuze.c
+++ b/firmware/target/arm/as3525/backlight-e200v2-fuze.c
@@ -28,12 +28,12 @@
28 28
29int buttonlight_is_on = 0; 29int buttonlight_is_on = 0;
30 30
31void _backlight_set_brightness(int brightness) 31void backlight_hw_brightness(int brightness)
32{ 32{
33 ascodec_write(AS3514_DCDC15, brightness); 33 ascodec_write(AS3514_DCDC15, brightness);
34} 34}
35 35
36void _backlight_on(void) 36void backlight_hw_on(void)
37{ 37{
38#ifdef HAVE_LCD_ENABLE 38#ifdef HAVE_LCD_ENABLE
39 lcd_enable(true); /* power on lcd + visible display */ 39 lcd_enable(true); /* power on lcd + visible display */
@@ -45,7 +45,7 @@ void _backlight_on(void)
45#endif 45#endif
46} 46}
47 47
48void _backlight_off(void) 48void backlight_hw_off(void)
49{ 49{
50 ascodec_write(AS3514_DCDC15, 0x0); 50 ascodec_write(AS3514_DCDC15, 0x0);
51#ifdef HAVE_LCD_ENABLE 51#ifdef HAVE_LCD_ENABLE
@@ -53,7 +53,7 @@ void _backlight_off(void)
53#endif 53#endif
54} 54}
55 55
56void _buttonlight_on(void) 56void buttonlight_hw_on(void)
57{ 57{
58 /* Needed for buttonlight and MicroSD to work at the same time */ 58 /* Needed for buttonlight and MicroSD to work at the same time */
59 /* Turn ROD control on, as the OF does */ 59 /* Turn ROD control on, as the OF does */
@@ -63,7 +63,7 @@ void _buttonlight_on(void)
63 buttonlight_is_on = 1; 63 buttonlight_is_on = 1;
64} 64}
65 65
66void _buttonlight_off(void) 66void buttonlight_hw_off(void)
67{ 67{
68 /* Needed for buttonlight and MicroSD to work at the same time */ 68 /* Needed for buttonlight and MicroSD to work at the same time */
69 /* Turn ROD control off, as the OF does */ 69 /* Turn ROD control off, as the OF does */
diff --git a/firmware/target/arm/as3525/sansa-c200v2/backlight-c200v2.c b/firmware/target/arm/as3525/sansa-c200v2/backlight-c200v2.c
index 1da57de93a..6344eff593 100644
--- a/firmware/target/arm/as3525/sansa-c200v2/backlight-c200v2.c
+++ b/firmware/target/arm/as3525/sansa-c200v2/backlight-c200v2.c
@@ -98,7 +98,7 @@ void _backlight_pwm(int on)
98 } 98 }
99} 99}
100 100
101bool _backlight_init(void) 101bool backlight_hw_init(void)
102{ 102{
103 GPIOA_DIR |= 1<<5; 103 GPIOA_DIR |= 1<<5;
104 if (c200v2_variant == 1) { 104 if (c200v2_variant == 1) {
@@ -109,14 +109,14 @@ bool _backlight_init(void)
109 return true; 109 return true;
110} 110}
111 111
112void _backlight_set_brightness(int brightness) 112void backlight_hw_brightness(int brightness)
113{ 113{
114 backlight_level = brightness_table[brightness]; 114 backlight_level = brightness_table[brightness];
115 115
116 if (brightness > 0) 116 if (brightness > 0)
117 _backlight_on(); 117 backlight_hw_on();
118 else 118 else
119 _backlight_off(); 119 backlight_hw_off();
120} 120}
121 121
122static void _pwm_on(void) 122static void _pwm_on(void)
@@ -130,7 +130,7 @@ static void _pwm_off(void)
130 _set_timer2_pwm_ratio(0); 130 _set_timer2_pwm_ratio(0);
131} 131}
132 132
133void _backlight_on(void) 133void backlight_hw_on(void)
134{ 134{
135 if (backlight_is_on == 1) { 135 if (backlight_is_on == 1) {
136 /* Update pwm ratio in case user changed the brightness */ 136 /* Update pwm ratio in case user changed the brightness */
@@ -146,7 +146,7 @@ void _backlight_on(void)
146 backlight_is_on = 1; 146 backlight_is_on = 1;
147} 147}
148 148
149void _backlight_off(void) 149void backlight_hw_off(void)
150{ 150{
151 if (backlight_is_on == 0) 151 if (backlight_is_on == 0)
152 return; 152 return;
@@ -159,7 +159,7 @@ void _backlight_off(void)
159#endif 159#endif
160} 160}
161 161
162void _buttonlight_on(void) 162void buttonlight_hw_on(void)
163{ 163{
164 if (buttonlight_is_on == 1) 164 if (buttonlight_is_on == 1)
165 return; 165 return;
@@ -169,7 +169,7 @@ void _buttonlight_on(void)
169 buttonlight_is_on = 1; 169 buttonlight_is_on = 1;
170} 170}
171 171
172void _buttonlight_off(void) 172void buttonlight_hw_off(void)
173{ 173{
174 if (buttonlight_is_on == 0) 174 if (buttonlight_is_on == 0)
175 return; 175 return;
diff --git a/firmware/target/arm/as3525/sansa-c200v2/backlight-target.h b/firmware/target/arm/as3525/sansa-c200v2/backlight-target.h
index 4a098f7f28..a6b07de6bf 100644
--- a/firmware/target/arm/as3525/sansa-c200v2/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-c200v2/backlight-target.h
@@ -23,22 +23,22 @@
23 23
24#include <stdbool.h> 24#include <stdbool.h>
25 25
26bool _backlight_init(void); 26bool backlight_hw_init(void);
27void _backlight_pwm(int on); 27void _backlight_pwm(int on);
28void _backlight_on(void); 28void backlight_hw_on(void);
29void _backlight_off(void); 29void backlight_hw_off(void);
30 30
31static inline void _backlight_panic_on(void) 31static inline void _backlight_panic_on(void)
32{ 32{
33 _backlight_on(); 33 backlight_hw_on();
34 _backlight_pwm(1); 34 _backlight_pwm(1);
35} 35}
36 36
37void _backlight_set_brightness(int brightness); 37void backlight_hw_brightness(int brightness);
38int __backlight_is_on(void); 38int __backlight_is_on(void);
39 39
40void _buttonlight_on(void); 40void buttonlight_hw_on(void);
41void _buttonlight_off(void); 41void buttonlight_hw_off(void);
42 42
43/* 43/*
44 * FIXME: This may be better off in kernel.h, but... 44 * FIXME: This may be better off in kernel.h, but...
diff --git a/firmware/target/arm/as3525/sansa-clip/backlight-target.h b/firmware/target/arm/as3525/sansa-clip/backlight-target.h
index 00c6e5cc44..669f0f5939 100644
--- a/firmware/target/arm/as3525/sansa-clip/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-clip/backlight-target.h
@@ -25,30 +25,30 @@
25#include "lcd.h" 25#include "lcd.h"
26#include "backlight.h" 26#include "backlight.h"
27 27
28static inline void _backlight_on(void) 28static inline void backlight_hw_on(void)
29{ 29{
30 lcd_enable(true); 30 lcd_enable(true);
31} 31}
32 32
33static inline void _backlight_off(void) 33static inline void backlight_hw_off(void)
34{ 34{
35 lcd_enable(false); 35 lcd_enable(false);
36} 36}
37 37
38#define _backlight_panic_on() _backlight_on() 38#define _backlight_panic_on() backlight_hw_on()
39 39
40static inline bool _backlight_init(void) 40static inline bool backlight_hw_init(void)
41{ 41{
42 GPIOD_DIR |= (1<<7); /* for button light */ 42 GPIOD_DIR |= (1<<7); /* for button light */
43 return true; 43 return true;
44} 44}
45 45
46static inline void _buttonlight_on(void) 46static inline void buttonlight_hw_on(void)
47{ 47{
48 GPIOD_PIN(7) = (1<<7); 48 GPIOD_PIN(7) = (1<<7);
49} 49}
50 50
51static inline void _buttonlight_off(void) 51static inline void buttonlight_hw_off(void)
52{ 52{
53 GPIOD_PIN(7) = 0; 53 GPIOD_PIN(7) = 0;
54} 54}
diff --git a/firmware/target/arm/as3525/sansa-clipplus/backlight-clip.c b/firmware/target/arm/as3525/sansa-clipplus/backlight-clip.c
index e3b518b3f8..76df12c948 100644
--- a/firmware/target/arm/as3525/sansa-clipplus/backlight-clip.c
+++ b/firmware/target/arm/as3525/sansa-clipplus/backlight-clip.c
@@ -24,13 +24,13 @@
24#include "as3525v2.h" 24#include "as3525v2.h"
25#include "ascodec.h" 25#include "ascodec.h"
26 26
27void _backlight_on(void) 27void backlight_hw_on(void)
28{ 28{
29 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x90); 29 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x90);
30 lcd_enable(true); 30 lcd_enable(true);
31} 31}
32 32
33void _backlight_off(void) 33void backlight_hw_off(void)
34{ 34{
35 lcd_enable(false); 35 lcd_enable(false);
36 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x00); 36 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x00);
diff --git a/firmware/target/arm/as3525/sansa-clipplus/backlight-target.h b/firmware/target/arm/as3525/sansa-clipplus/backlight-target.h
index 3dd9240bd8..9e8ff1ce8c 100644
--- a/firmware/target/arm/as3525/sansa-clipplus/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-clipplus/backlight-target.h
@@ -21,10 +21,10 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25 25
26void _backlight_on(void); 26void backlight_hw_on(void);
27void _backlight_off(void); 27void backlight_hw_off(void);
28#define _backlight_panic_on() _backlight_on() 28#define _backlight_panic_on() backlight_hw_on()
29 29
30#endif 30#endif
diff --git a/firmware/target/arm/as3525/sansa-clipv2/backlight-clipv2.c b/firmware/target/arm/as3525/sansa-clipv2/backlight-clipv2.c
index f4927ba5bf..65f69e8bcd 100644
--- a/firmware/target/arm/as3525/sansa-clipv2/backlight-clipv2.c
+++ b/firmware/target/arm/as3525/sansa-clipv2/backlight-clipv2.c
@@ -24,13 +24,13 @@
24#include "as3525v2.h" 24#include "as3525v2.h"
25#include "ascodec.h" 25#include "ascodec.h"
26 26
27void _backlight_on(void) 27void backlight_hw_on(void)
28{ 28{
29 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x90); 29 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x90);
30 lcd_enable(true); 30 lcd_enable(true);
31} 31}
32 32
33void _backlight_off(void) 33void backlight_hw_off(void)
34{ 34{
35 lcd_enable(false); 35 lcd_enable(false);
36 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x0); 36 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x0);
diff --git a/firmware/target/arm/as3525/sansa-clipv2/backlight-target.h b/firmware/target/arm/as3525/sansa-clipv2/backlight-target.h
index b2da63dbff..800b26d7fa 100644
--- a/firmware/target/arm/as3525/sansa-clipv2/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-clipv2/backlight-target.h
@@ -24,22 +24,22 @@
24#include <stdbool.h> 24#include <stdbool.h>
25#include "cpu.h" 25#include "cpu.h"
26 26
27void _backlight_on(void); 27void backlight_hw_on(void);
28void _backlight_off(void); 28void backlight_hw_off(void);
29#define _backlight_panic_on() _backlight_on() 29#define _backlight_panic_on() backlight_hw_on()
30 30
31static inline bool _backlight_init(void) 31static inline bool backlight_hw_init(void)
32{ 32{
33 GPIOA_DIR |= 1<<5; /* for button light */ 33 GPIOA_DIR |= 1<<5; /* for button light */
34 return true; 34 return true;
35} 35}
36 36
37static inline void _buttonlight_on(void) 37static inline void buttonlight_hw_on(void)
38{ 38{
39 GPIOA_PIN(5) = 1<<5; 39 GPIOA_PIN(5) = 1<<5;
40} 40}
41 41
42static inline void _buttonlight_off(void) 42static inline void buttonlight_hw_off(void)
43{ 43{
44 GPIOA_PIN(5) = 0; 44 GPIOA_PIN(5) = 0;
45} 45}
diff --git a/firmware/target/arm/as3525/sansa-clipzip/backlight-clipzip.c b/firmware/target/arm/as3525/sansa-clipzip/backlight-clipzip.c
index a47941bbd7..9fde68dd8a 100644
--- a/firmware/target/arm/as3525/sansa-clipzip/backlight-clipzip.c
+++ b/firmware/target/arm/as3525/sansa-clipzip/backlight-clipzip.c
@@ -27,12 +27,12 @@
27#include "ascodec.h" 27#include "ascodec.h"
28#include "lcd-target.h" 28#include "lcd-target.h"
29 29
30bool _backlight_init() 30bool backlight_hw_init()
31{ 31{
32 return true; 32 return true;
33} 33}
34 34
35void _backlight_on(void) 35void backlight_hw_on(void)
36{ 36{
37 /* GPIO B1 controls backlight */ 37 /* GPIO B1 controls backlight */
38 GPIOB_DIR |= (1 << 1); 38 GPIOB_DIR |= (1 << 1);
@@ -43,7 +43,7 @@ void _backlight_on(void)
43#endif 43#endif
44} 44}
45 45
46void _backlight_off(void) 46void backlight_hw_off(void)
47{ 47{
48#ifdef HAVE_LCD_ENABLE 48#ifdef HAVE_LCD_ENABLE
49 lcd_enable(false); 49 lcd_enable(false);
@@ -52,7 +52,7 @@ void _backlight_off(void)
52 GPIOB_PIN(1) = 0; 52 GPIOB_PIN(1) = 0;
53} 53}
54 54
55void _backlight_set_brightness(int brightness) 55void backlight_hw_brightness(int brightness)
56{ 56{
57 oled_brightness(brightness); 57 oled_brightness(brightness);
58} 58}
diff --git a/firmware/target/arm/as3525/sansa-clipzip/backlight-target.h b/firmware/target/arm/as3525/sansa-clipzip/backlight-target.h
index bf58973ab6..00b925c22b 100644
--- a/firmware/target/arm/as3525/sansa-clipzip/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-clipzip/backlight-target.h
@@ -21,11 +21,11 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#define _backlight_panic_on() _backlight_on() 29#define _backlight_panic_on() backlight_hw_on()
30 30
31#endif 31#endif
diff --git a/firmware/target/arm/as3525/sansa-e200v2/backlight-target.h b/firmware/target/arm/as3525/sansa-e200v2/backlight-target.h
index 227a154197..0baaf2441a 100644
--- a/firmware/target/arm/as3525/sansa-e200v2/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-e200v2/backlight-target.h
@@ -21,13 +21,13 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27#define _backlight_panic_on() _backlight_on() 27#define _backlight_panic_on() backlight_hw_on()
28void _backlight_set_brightness(int brightness); 28void backlight_hw_brightness(int brightness);
29int __backlight_is_on(void); 29int __backlight_is_on(void);
30 30
31void _buttonlight_on(void); 31void buttonlight_hw_on(void);
32void _buttonlight_off(void); 32void buttonlight_hw_off(void);
33#endif 33#endif
diff --git a/firmware/target/arm/as3525/sansa-fuze/backlight-target.h b/firmware/target/arm/as3525/sansa-fuze/backlight-target.h
index df6df573b0..c4e95e9c4a 100644
--- a/firmware/target/arm/as3525/sansa-fuze/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-fuze/backlight-target.h
@@ -21,13 +21,13 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27#define _backlight_panic_on() _backlight_on() 27#define _backlight_panic_on() backlight_hw_on()
28void _backlight_set_brightness(int brightness); 28void backlight_hw_brightness(int brightness);
29#ifdef HAVE_BUTTON_LIGHT 29#ifdef HAVE_BUTTON_LIGHT
30void _buttonlight_on(void); 30void buttonlight_hw_on(void);
31void _buttonlight_off(void); 31void buttonlight_hw_off(void);
32#endif 32#endif
33#endif 33#endif
diff --git a/firmware/target/arm/as3525/sansa-fuzev2/backlight-fuzev2.c b/firmware/target/arm/as3525/sansa-fuzev2/backlight-fuzev2.c
index a01b168b71..71f0c1a3f2 100644
--- a/firmware/target/arm/as3525/sansa-fuzev2/backlight-fuzev2.c
+++ b/firmware/target/arm/as3525/sansa-fuzev2/backlight-fuzev2.c
@@ -26,12 +26,12 @@
26#include "ascodec.h" 26#include "ascodec.h"
27#include "as3514.h" 27#include "as3514.h"
28 28
29void _backlight_set_brightness(int brightness) 29void backlight_hw_brightness(int brightness)
30{ 30{
31 ascodec_write_pmu(AS3543_BACKLIGHT, 2, brightness * 10); 31 ascodec_write_pmu(AS3543_BACKLIGHT, 2, brightness * 10);
32} 32}
33 33
34bool _backlight_init(void) 34bool backlight_hw_init(void)
35{ 35{
36 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x80); 36 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x80);
37 ascodec_write_pmu(AS3543_BACKLIGHT, 2, backlight_brightness * 10); 37 ascodec_write_pmu(AS3543_BACKLIGHT, 2, backlight_brightness * 10);
@@ -49,7 +49,7 @@ bool _backlight_init(void)
49 return true; 49 return true;
50} 50}
51 51
52void _backlight_on(void) 52void backlight_hw_on(void)
53{ 53{
54#ifdef HAVE_LCD_ENABLE 54#ifdef HAVE_LCD_ENABLE
55 lcd_enable(true); /* power on lcd + visible display */ 55 lcd_enable(true); /* power on lcd + visible display */
@@ -57,7 +57,7 @@ void _backlight_on(void)
57 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x80); 57 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x80);
58} 58}
59 59
60void _backlight_off(void) 60void backlight_hw_off(void)
61{ 61{
62 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x0); 62 ascodec_write_pmu(AS3543_BACKLIGHT, 1, 0x0);
63#ifdef HAVE_LCD_ENABLE 63#ifdef HAVE_LCD_ENABLE
@@ -65,7 +65,7 @@ void _backlight_off(void)
65#endif 65#endif
66} 66}
67 67
68void _buttonlight_on(void) 68void buttonlight_hw_on(void)
69{ 69{
70 if (amsv2_variant == 0) 70 if (amsv2_variant == 0)
71 { 71 {
@@ -77,7 +77,7 @@ void _buttonlight_on(void)
77 } 77 }
78} 78}
79 79
80void _buttonlight_off(void) 80void buttonlight_hw_off(void)
81{ 81{
82 if (amsv2_variant == 0) 82 if (amsv2_variant == 0)
83 { 83 {
diff --git a/firmware/target/arm/as3525/sansa-fuzev2/backlight-target.h b/firmware/target/arm/as3525/sansa-fuzev2/backlight-target.h
index f9d7005f79..4138ef7868 100644
--- a/firmware/target/arm/as3525/sansa-fuzev2/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-fuzev2/backlight-target.h
@@ -25,13 +25,13 @@
25#include "config.h" 25#include "config.h"
26#include "ascodec.h" 26#include "ascodec.h"
27 27
28bool _backlight_init(void); 28bool backlight_hw_init(void);
29void _backlight_on(void); 29void backlight_hw_on(void);
30void _backlight_off(void); 30void backlight_hw_off(void);
31#define _backlight_panic_on() _backlight_on() 31#define _backlight_panic_on() backlight_hw_on()
32void _backlight_set_brightness(int brightness); 32void backlight_hw_brightness(int brightness);
33#ifdef HAVE_BUTTON_LIGHT 33#ifdef HAVE_BUTTON_LIGHT
34void _buttonlight_on(void); 34void buttonlight_hw_on(void);
35void _buttonlight_off(void); 35void buttonlight_hw_off(void);
36#endif 36#endif
37#endif 37#endif
diff --git a/firmware/target/arm/as3525/sansa-m200v4/backlight-target.h b/firmware/target/arm/as3525/sansa-m200v4/backlight-target.h
index b5560bd037..f3ef1095e6 100644
--- a/firmware/target/arm/as3525/sansa-m200v4/backlight-target.h
+++ b/firmware/target/arm/as3525/sansa-m200v4/backlight-target.h
@@ -21,22 +21,22 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24static inline bool _backlight_init(void) 24static inline bool backlight_hw_init(void)
25{ 25{
26 GPIOD_DIR |= (1<<1); 26 GPIOD_DIR |= (1<<1);
27 return true; 27 return true;
28} 28}
29 29
30static inline void _backlight_on(void) 30static inline void backlight_hw_on(void)
31{ 31{
32 GPIOD_PIN(1) = (1<<1); 32 GPIOD_PIN(1) = (1<<1);
33} 33}
34 34
35static inline void _backlight_off(void) 35static inline void backlight_hw_off(void)
36{ 36{
37 GPIOD_PIN(1) = 0x00; 37 GPIOD_PIN(1) = 0x00;
38} 38}
39 39
40#define _backlight_panic_on() _backlight_on() 40#define _backlight_panic_on() backlight_hw_on()
41 41
42#endif 42#endif
diff --git a/firmware/target/arm/as3525/sd-as3525.c b/firmware/target/arm/as3525/sd-as3525.c
index ead40eac3c..4530d5d763 100644
--- a/firmware/target/arm/as3525/sd-as3525.c
+++ b/firmware/target/arm/as3525/sd-as3525.c
@@ -969,7 +969,7 @@ void sd_enable(bool on)
969 if (buttonlight_is_on) 969 if (buttonlight_is_on)
970 GPIOD_DIR &= ~(1<<7); 970 GPIOD_DIR &= ~(1<<7);
971 else 971 else
972 _buttonlight_off(); 972 buttonlight_hw_off();
973#endif 973#endif
974 974
975#if defined(HAVE_HOTSWAP) && defined (HAVE_ADJUSTABLE_CPU_VOLTAGE) 975#if defined(HAVE_HOTSWAP) && defined (HAVE_ADJUSTABLE_CPU_VOLTAGE)
@@ -993,7 +993,7 @@ void sd_enable(bool on)
993#if defined(HAVE_BUTTON_LIGHT) && defined(HAVE_MULTIDRIVE) 993#if defined(HAVE_BUTTON_LIGHT) && defined(HAVE_MULTIDRIVE)
994 bitmod32(&CCU_IO, 0<<2, 3<<2); /* XPD is general purpose IO (b3:2 = 00) */ 994 bitmod32(&CCU_IO, 0<<2, 3<<2); /* XPD is general purpose IO (b3:2 = 00) */
995 if (buttonlight_is_on) 995 if (buttonlight_is_on)
996 _buttonlight_on(); 996 buttonlight_hw_on();
997#endif 997#endif
998 } 998 }
999} 999}
diff --git a/firmware/target/arm/as3525/system-as3525.c b/firmware/target/arm/as3525/system-as3525.c
index f128ef68be..51b6755601 100644
--- a/firmware/target/arm/as3525/system-as3525.c
+++ b/firmware/target/arm/as3525/system-as3525.c
@@ -360,7 +360,7 @@ void system_init(void)
360 360
361void system_reboot(void) 361void system_reboot(void)
362{ 362{
363 _backlight_off(); 363 backlight_hw_off();
364 364
365 disable_irq(); 365 disable_irq();
366 366
diff --git a/firmware/target/arm/at91sam/lyre_proto1/backlight-lyre_proto1.c b/firmware/target/arm/at91sam/lyre_proto1/backlight-lyre_proto1.c
index fabf8aa041..b60449417a 100644
--- a/firmware/target/arm/at91sam/lyre_proto1/backlight-lyre_proto1.c
+++ b/firmware/target/arm/at91sam/lyre_proto1/backlight-lyre_proto1.c
@@ -19,27 +19,27 @@
19 * 19 *
20 ****************************************************************************/ 20 ****************************************************************************/
21 21
22void _backlight_set_brightness(int brightness) 22void backlight_hw_brightness(int brightness)
23{ 23{
24 (void)brightness; 24 (void)brightness;
25} 25}
26 26
27void _backlight_on(void) 27void backlight_hw_on(void)
28{ 28{
29 29
30} 30}
31 31
32void _backlight_off(void) 32void backlight_hw_off(void)
33{ 33{
34 34
35} 35}
36 36
37void _buttonlight_on(void) 37void buttonlight_hw_on(void)
38{ 38{
39 39
40} 40}
41 41
42void _buttonlight_off(void) 42void buttonlight_hw_off(void)
43{ 43{
44 44
45} 45}
diff --git a/firmware/target/arm/imx233/creative-zen/backlight-target.h b/firmware/target/arm/imx233/creative-zen/backlight-target.h
index 78a0a72d85..60a2fbe746 100644
--- a/firmware/target/arm/imx233/creative-zen/backlight-target.h
+++ b/firmware/target/arm/imx233/creative-zen/backlight-target.h
@@ -21,9 +21,9 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#endif /* BACKLIGHT_TARGET_H */ 29#endif /* BACKLIGHT_TARGET_H */
diff --git a/firmware/target/arm/imx233/creative-zen/backlight-zen.c b/firmware/target/arm/imx233/creative-zen/backlight-zen.c
index 6d162817c8..ef2ab615a5 100644
--- a/firmware/target/arm/imx233/creative-zen/backlight-zen.c
+++ b/firmware/target/arm/imx233/creative-zen/backlight-zen.c
@@ -28,7 +28,7 @@
28#include "pinctrl-imx233.h" 28#include "pinctrl-imx233.h"
29#include "pwm-imx233.h" 29#include "pwm-imx233.h"
30 30
31void _backlight_set_brightness(int level) 31void backlight_hw_brightness(int level)
32{ 32{
33#if defined(CREATIVE_ZENXFISTYLE) 33#if defined(CREATIVE_ZENXFISTYLE)
34 imx233_pwm_setup_simple(4, 24000, level); 34 imx233_pwm_setup_simple(4, 24000, level);
@@ -49,7 +49,7 @@ void _backlight_set_brightness(int level)
49#endif 49#endif
50} 50}
51 51
52bool _backlight_init(void) 52bool backlight_hw_init(void)
53{ 53{
54#if !defined(CREATIVE_ZENV) && !defined(CREATIVE_ZENXFISTYLE) 54#if !defined(CREATIVE_ZENV) && !defined(CREATIVE_ZENXFISTYLE)
55 imx233_pinctrl_acquire(1, 12, "backlight_enable"); 55 imx233_pinctrl_acquire(1, 12, "backlight_enable");
@@ -60,19 +60,19 @@ bool _backlight_init(void)
60 return true; 60 return true;
61} 61}
62 62
63void _backlight_on(void) 63void backlight_hw_on(void)
64{ 64{
65#ifdef HAVE_LCD_ENABLE 65#ifdef HAVE_LCD_ENABLE
66 lcd_enable(true); /* power on lcd + visible display */ 66 lcd_enable(true); /* power on lcd + visible display */
67#endif 67#endif
68 /* restore the previous backlight level */ 68 /* restore the previous backlight level */
69 _backlight_set_brightness(backlight_brightness); 69 backlight_hw_brightness(backlight_brightness);
70} 70}
71 71
72void _backlight_off(void) 72void backlight_hw_off(void)
73{ 73{
74 /* there is no real on/off but we can set to 0 brightness */ 74 /* there is no real on/off but we can set to 0 brightness */
75 _backlight_set_brightness(0); 75 backlight_hw_brightness(0);
76#ifdef HAVE_LCD_ENABLE 76#ifdef HAVE_LCD_ENABLE
77 lcd_enable(false); /* power off visible display */ 77 lcd_enable(false); /* power off visible display */
78#endif 78#endif
diff --git a/firmware/target/arm/imx233/creative-zenxfi2/backlight-target.h b/firmware/target/arm/imx233/creative-zenxfi2/backlight-target.h
index e3766965d8..483272f804 100644
--- a/firmware/target/arm/imx233/creative-zenxfi2/backlight-target.h
+++ b/firmware/target/arm/imx233/creative-zenxfi2/backlight-target.h
@@ -21,9 +21,9 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#endif /* BACKLIGHT_TARGET_H */ 29#endif /* BACKLIGHT_TARGET_H */
diff --git a/firmware/target/arm/imx233/creative-zenxfi2/backlight-zenxfi2.c b/firmware/target/arm/imx233/creative-zenxfi2/backlight-zenxfi2.c
index b01dc36063..02e7a0f77e 100644
--- a/firmware/target/arm/imx233/creative-zenxfi2/backlight-zenxfi2.c
+++ b/firmware/target/arm/imx233/creative-zenxfi2/backlight-zenxfi2.c
@@ -26,19 +26,19 @@
26#include "backlight-target.h" 26#include "backlight-target.h"
27#include "pwm-imx233.h" 27#include "pwm-imx233.h"
28 28
29void _backlight_set_brightness(int brightness) 29void backlight_hw_brightness(int brightness)
30{ 30{
31 imx233_pwm_setup_simple(4, 24000, brightness); 31 imx233_pwm_setup_simple(4, 24000, brightness);
32 imx233_pwm_enable(4, true); 32 imx233_pwm_enable(4, true);
33} 33}
34 34
35bool _backlight_init(void) 35bool backlight_hw_init(void)
36{ 36{
37 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 37 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
38 return true; 38 return true;
39} 39}
40 40
41void _backlight_on(void) 41void backlight_hw_on(void)
42{ 42{
43#ifdef HAVE_LCD_ENABLE 43#ifdef HAVE_LCD_ENABLE
44 lcd_enable(true); /* power on lcd + visible display */ 44 lcd_enable(true); /* power on lcd + visible display */
@@ -46,10 +46,10 @@ void _backlight_on(void)
46 /* don't do anything special, the core will set the brightness */ 46 /* don't do anything special, the core will set the brightness */
47} 47}
48 48
49void _backlight_off(void) 49void backlight_hw_off(void)
50{ 50{
51 /* there is no real on/off but we can set to 0 brightness */ 51 /* there is no real on/off but we can set to 0 brightness */
52 _backlight_set_brightness(0); 52 backlight_hw_brightness(0);
53#ifdef HAVE_LCD_ENABLE 53#ifdef HAVE_LCD_ENABLE
54 lcd_enable(false); /* power off visible display */ 54 lcd_enable(false); /* power off visible display */
55#endif 55#endif
diff --git a/firmware/target/arm/imx233/creative-zenxfi3/backlight-target.h b/firmware/target/arm/imx233/creative-zenxfi3/backlight-target.h
index c7508c87a3..edc67ba816 100644
--- a/firmware/target/arm/imx233/creative-zenxfi3/backlight-target.h
+++ b/firmware/target/arm/imx233/creative-zenxfi3/backlight-target.h
@@ -21,13 +21,13 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29void _buttonlight_on(void); 29void buttonlight_hw_on(void);
30void _buttonlight_off(void); 30void buttonlight_hw_off(void);
31void _buttonlight_set_brightness(int brightness); 31void buttonlight_hw_brightness(int brightness);
32 32
33#endif /* BACKLIGHT_TARGET_H */ 33#endif /* BACKLIGHT_TARGET_H */
diff --git a/firmware/target/arm/imx233/creative-zenxfi3/backlight-zenxfi3.c b/firmware/target/arm/imx233/creative-zenxfi3/backlight-zenxfi3.c
index 7013696642..2b77a4d7ac 100644
--- a/firmware/target/arm/imx233/creative-zenxfi3/backlight-zenxfi3.c
+++ b/firmware/target/arm/imx233/creative-zenxfi3/backlight-zenxfi3.c
@@ -27,19 +27,19 @@
27#include "pwm-imx233.h" 27#include "pwm-imx233.h"
28#include "mpr121.h" 28#include "mpr121.h"
29 29
30void _backlight_set_brightness(int brightness) 30void backlight_hw_brightness(int brightness)
31{ 31{
32 imx233_pwm_setup_simple(2, 24000, brightness); 32 imx233_pwm_setup_simple(2, 24000, brightness);
33 imx233_pwm_enable(2, true); 33 imx233_pwm_enable(2, true);
34} 34}
35 35
36bool _backlight_init(void) 36bool backlight_hw_init(void)
37{ 37{
38 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 38 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
39 return true; 39 return true;
40} 40}
41 41
42void _backlight_on(void) 42void backlight_hw_on(void)
43{ 43{
44#ifdef HAVE_LCD_ENABLE 44#ifdef HAVE_LCD_ENABLE
45 lcd_enable(true); /* power on lcd + visible display */ 45 lcd_enable(true); /* power on lcd + visible display */
@@ -47,29 +47,29 @@ void _backlight_on(void)
47 /* don't do anything special, the core will set the brightness */ 47 /* don't do anything special, the core will set the brightness */
48} 48}
49 49
50void _backlight_off(void) 50void backlight_hw_off(void)
51{ 51{
52 /* there is no real on/off but we can set to 0 brightness */ 52 /* there is no real on/off but we can set to 0 brightness */
53 _backlight_set_brightness(0); 53 backlight_hw_brightness(0);
54#ifdef HAVE_LCD_ENABLE 54#ifdef HAVE_LCD_ENABLE
55 lcd_enable(false); /* power off visible display */ 55 lcd_enable(false); /* power off visible display */
56#endif 56#endif
57} 57}
58 58
59/* ELE8 is the button light GPIO */ 59/* ELE8 is the button light GPIO */
60void _buttonlight_on(void) 60void buttonlight_hw_on(void)
61{ 61{
62 /* assume mpr121 was initialized by button-zenxfi3.c */ 62 /* assume mpr121 was initialized by button-zenxfi3.c */
63 mpr121_set_gpio_output(8, ELE_GPIO_SET); 63 mpr121_set_gpio_output(8, ELE_GPIO_SET);
64} 64}
65 65
66void _buttonlight_off(void) 66void buttonlight_hw_off(void)
67{ 67{
68 /* assume mpr121 was initialized by button-zenxfi3.c */ 68 /* assume mpr121 was initialized by button-zenxfi3.c */
69 mpr121_set_gpio_output(8, ELE_GPIO_CLR); 69 mpr121_set_gpio_output(8, ELE_GPIO_CLR);
70} 70}
71 71
72void _buttonlight_set_brightness(int brightness) 72void buttonlight_hw_brightness(int brightness)
73{ 73{
74 /* assume mpr121 was initialized by button-zenxfi3.c */ 74 /* assume mpr121 was initialized by button-zenxfi3.c */
75 /* since backlight brightness is the same for the screen and the button light, 75 /* since backlight brightness is the same for the screen and the button light,
diff --git a/firmware/target/arm/imx233/samsung-ypz5/backlight-target.h b/firmware/target/arm/imx233/samsung-ypz5/backlight-target.h
index 5fa2ed38f9..e26f83811d 100644
--- a/firmware/target/arm/imx233/samsung-ypz5/backlight-target.h
+++ b/firmware/target/arm/imx233/samsung-ypz5/backlight-target.h
@@ -20,9 +20,9 @@
20#ifndef BACKLIGHT_TARGET_H 20#ifndef BACKLIGHT_TARGET_H
21#define BACKLIGHT_TARGET_H 21#define BACKLIGHT_TARGET_H
22 22
23bool _backlight_init(void); 23bool backlight_hw_init(void);
24void _backlight_on(void); 24void backlight_hw_on(void);
25void _backlight_off(void); 25void backlight_hw_off(void);
26void _backlight_set_brightness(int brightness); 26void backlight_hw_brightness(int brightness);
27 27
28#endif /* BACKLIGHT_TARGET_H */ 28#endif /* BACKLIGHT_TARGET_H */
diff --git a/firmware/target/arm/imx233/samsung-ypz5/backlight-ypz5.c b/firmware/target/arm/imx233/samsung-ypz5/backlight-ypz5.c
index 27a7ecedfc..b02c3a1d16 100644
--- a/firmware/target/arm/imx233/samsung-ypz5/backlight-ypz5.c
+++ b/firmware/target/arm/imx233/samsung-ypz5/backlight-ypz5.c
@@ -77,7 +77,7 @@ static void aat3151_write(int addr, int data)
77 udelay(TIME_LAT); 77 udelay(TIME_LAT);
78} 78}
79 79
80void _backlight_set_brightness(int level) 80void backlight_hw_brightness(int level)
81{ 81{
82 /* Don't try to reset backlight if not necessary 82 /* Don't try to reset backlight if not necessary
83 * Moreover this helps to avoid flickering when 83 * Moreover this helps to avoid flickering when
@@ -120,7 +120,7 @@ void _backlight_set_brightness(int level)
120 current_level = level; 120 current_level = level;
121} 121}
122 122
123bool _backlight_init(void) 123bool backlight_hw_init(void)
124{ 124{
125 imx233_pinctrl_acquire(3, 13, "backlight"); 125 imx233_pinctrl_acquire(3, 13, "backlight");
126 imx233_pinctrl_set_function(3, 13, PINCTRL_FUNCTION_GPIO); 126 imx233_pinctrl_set_function(3, 13, PINCTRL_FUNCTION_GPIO);
@@ -130,19 +130,19 @@ bool _backlight_init(void)
130 return true; 130 return true;
131} 131}
132 132
133void _backlight_on(void) 133void backlight_hw_on(void)
134{ 134{
135#ifdef HAVE_LCD_ENABLE 135#ifdef HAVE_LCD_ENABLE
136 lcd_enable(true); /* power on lcd + visible display */ 136 lcd_enable(true); /* power on lcd + visible display */
137#endif 137#endif
138 /* restore the previous backlight level */ 138 /* restore the previous backlight level */
139 _backlight_set_brightness(backlight_brightness); 139 backlight_hw_brightness(backlight_brightness);
140} 140}
141 141
142void _backlight_off(void) 142void backlight_hw_off(void)
143{ 143{
144 /* there is no real on/off but we can set to 0 brightness */ 144 /* there is no real on/off but we can set to 0 brightness */
145 _backlight_set_brightness(0); 145 backlight_hw_brightness(0);
146#ifdef HAVE_LCD_ENABLE 146#ifdef HAVE_LCD_ENABLE
147 lcd_enable(false); /* power off visible display */ 147 lcd_enable(false); /* power off visible display */
148#endif 148#endif
diff --git a/firmware/target/arm/imx233/sansa-fuzeplus/backlight-fuzeplus.c b/firmware/target/arm/imx233/sansa-fuzeplus/backlight-fuzeplus.c
index 3ee9d0914a..f87dbddfc0 100644
--- a/firmware/target/arm/imx233/sansa-fuzeplus/backlight-fuzeplus.c
+++ b/firmware/target/arm/imx233/sansa-fuzeplus/backlight-fuzeplus.c
@@ -26,7 +26,7 @@
26#include "backlight-target.h" 26#include "backlight-target.h"
27#include "pinctrl-imx233.h" 27#include "pinctrl-imx233.h"
28 28
29void _backlight_set_brightness(int brightness) 29void backlight_hw_brightness(int brightness)
30{ 30{
31 if(brightness != 0) 31 if(brightness != 0)
32 brightness = MAX_BRIGHTNESS_SETTING + 1 - brightness; 32 brightness = MAX_BRIGHTNESS_SETTING + 1 - brightness;
@@ -39,17 +39,17 @@ void _backlight_set_brightness(int brightness)
39 } 39 }
40} 40}
41 41
42bool _backlight_init(void) 42bool backlight_hw_init(void)
43{ 43{
44 imx233_pinctrl_acquire(1, 28, "backlight"); 44 imx233_pinctrl_acquire(1, 28, "backlight");
45 imx233_pinctrl_set_function(1, 28, PINCTRL_FUNCTION_GPIO); 45 imx233_pinctrl_set_function(1, 28, PINCTRL_FUNCTION_GPIO);
46 imx233_pinctrl_set_drive(1, 28, PINCTRL_DRIVE_8mA); 46 imx233_pinctrl_set_drive(1, 28, PINCTRL_DRIVE_8mA);
47 imx233_pinctrl_enable_gpio(1, 28, true); 47 imx233_pinctrl_enable_gpio(1, 28, true);
48 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 48 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
49 return true; 49 return true;
50} 50}
51 51
52void _backlight_on(void) 52void backlight_hw_on(void)
53{ 53{
54#ifdef HAVE_LCD_ENABLE 54#ifdef HAVE_LCD_ENABLE
55 lcd_enable(true); /* power on lcd + visible display */ 55 lcd_enable(true); /* power on lcd + visible display */
@@ -57,10 +57,10 @@ void _backlight_on(void)
57 /* don't do anything special, the core will set the brightness */ 57 /* don't do anything special, the core will set the brightness */
58} 58}
59 59
60void _backlight_off(void) 60void backlight_hw_off(void)
61{ 61{
62 /* there is no real on/off but we can set to 0 brightness */ 62 /* there is no real on/off but we can set to 0 brightness */
63 _backlight_set_brightness(0); 63 backlight_hw_brightness(0);
64#ifdef HAVE_LCD_ENABLE 64#ifdef HAVE_LCD_ENABLE
65 lcd_enable(false); /* power off visible display */ 65 lcd_enable(false); /* power off visible display */
66#endif 66#endif
diff --git a/firmware/target/arm/imx233/sansa-fuzeplus/backlight-target.h b/firmware/target/arm/imx233/sansa-fuzeplus/backlight-target.h
index e3766965d8..483272f804 100644
--- a/firmware/target/arm/imx233/sansa-fuzeplus/backlight-target.h
+++ b/firmware/target/arm/imx233/sansa-fuzeplus/backlight-target.h
@@ -21,9 +21,9 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#endif /* BACKLIGHT_TARGET_H */ 29#endif /* BACKLIGHT_TARGET_H */
diff --git a/firmware/target/arm/imx233/sony-nwz/backlight-nwz.c b/firmware/target/arm/imx233/sony-nwz/backlight-nwz.c
index d99d21386b..fecbeda15b 100644
--- a/firmware/target/arm/imx233/sony-nwz/backlight-nwz.c
+++ b/firmware/target/arm/imx233/sony-nwz/backlight-nwz.c
@@ -27,7 +27,7 @@
27#include "pwm-imx233.h" 27#include "pwm-imx233.h"
28#include "pinctrl-imx233.h" 28#include "pinctrl-imx233.h"
29 29
30void _backlight_set_brightness(int brightness) 30void backlight_hw_brightness(int brightness)
31{ 31{
32 bool en = brightness > 0; 32 bool en = brightness > 0;
33 imx233_pwm_setup_simple(2, 24000, 100 - brightness); 33 imx233_pwm_setup_simple(2, 24000, 100 - brightness);
@@ -35,17 +35,17 @@ void _backlight_set_brightness(int brightness)
35 imx233_pinctrl_set_gpio(0, 10, en); 35 imx233_pinctrl_set_gpio(0, 10, en);
36} 36}
37 37
38bool _backlight_init(void) 38bool backlight_hw_init(void)
39{ 39{
40 imx233_pinctrl_acquire(0, 10, "backlight_enable"); 40 imx233_pinctrl_acquire(0, 10, "backlight_enable");
41 imx233_pinctrl_set_function(0, 10, PINCTRL_FUNCTION_GPIO); 41 imx233_pinctrl_set_function(0, 10, PINCTRL_FUNCTION_GPIO);
42 imx233_pinctrl_enable_gpio(0, 10, true); 42 imx233_pinctrl_enable_gpio(0, 10, true);
43 imx233_pinctrl_set_gpio(0, 10, true); 43 imx233_pinctrl_set_gpio(0, 10, true);
44 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 44 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
45 return true; 45 return true;
46} 46}
47 47
48void _backlight_on(void) 48void backlight_hw_on(void)
49{ 49{
50#ifdef HAVE_LCD_ENABLE 50#ifdef HAVE_LCD_ENABLE
51 lcd_enable(true); /* power on lcd + visible display */ 51 lcd_enable(true); /* power on lcd + visible display */
@@ -53,10 +53,10 @@ void _backlight_on(void)
53 /* don't do anything special, the core will set the brightness */ 53 /* don't do anything special, the core will set the brightness */
54} 54}
55 55
56void _backlight_off(void) 56void backlight_hw_off(void)
57{ 57{
58 /* there is no real on/off but we can set to 0 brightness */ 58 /* there is no real on/off but we can set to 0 brightness */
59 _backlight_set_brightness(0); 59 backlight_hw_brightness(0);
60#ifdef HAVE_LCD_ENABLE 60#ifdef HAVE_LCD_ENABLE
61 lcd_enable(false); /* power off visible display */ 61 lcd_enable(false); /* power off visible display */
62#endif 62#endif
diff --git a/firmware/target/arm/imx233/sony-nwz/backlight-target.h b/firmware/target/arm/imx233/sony-nwz/backlight-target.h
index 78a0a72d85..60a2fbe746 100644
--- a/firmware/target/arm/imx233/sony-nwz/backlight-target.h
+++ b/firmware/target/arm/imx233/sony-nwz/backlight-target.h
@@ -21,9 +21,9 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#endif /* BACKLIGHT_TARGET_H */ 29#endif /* BACKLIGHT_TARGET_H */
diff --git a/firmware/target/arm/imx233/system-imx233.c b/firmware/target/arm/imx233/system-imx233.c
index f34eab66e2..38865c47a3 100644
--- a/firmware/target/arm/imx233/system-imx233.c
+++ b/firmware/target/arm/imx233/system-imx233.c
@@ -105,7 +105,7 @@ void imx233_chip_reset(void)
105 105
106void system_reboot(void) 106void system_reboot(void)
107{ 107{
108 _backlight_off(); 108 backlight_hw_off();
109 109
110 disable_irq(); 110 disable_irq();
111 111
@@ -119,8 +119,8 @@ void system_exception_wait(void)
119 imx233_rtc_enable_watchdog(false); 119 imx233_rtc_enable_watchdog(false);
120 /* make sure lcd and backlight are on */ 120 /* make sure lcd and backlight are on */
121 lcd_update(); 121 lcd_update();
122 _backlight_on(); 122 backlight_hw_on();
123 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 123 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
124 /* wait until button release (if a button is pressed) */ 124 /* wait until button release (if a button is pressed) */
125#ifdef HAVE_BUTTON_DATA 125#ifdef HAVE_BUTTON_DATA
126 int data; 126 int data;
diff --git a/firmware/target/arm/imx31/gigabeat-s/backlight-gigabeat-s.c b/firmware/target/arm/imx31/gigabeat-s/backlight-gigabeat-s.c
index 60fcb4729d..29d8980d86 100644
--- a/firmware/target/arm/imx31/gigabeat-s/backlight-gigabeat-s.c
+++ b/firmware/target/arm/imx31/gigabeat-s/backlight-gigabeat-s.c
@@ -79,7 +79,7 @@ static uint32_t backlight_pwm_bits; /* Final PWM setting for fade-in */
79/* Backlight ramping settings */ 79/* Backlight ramping settings */
80static uint32_t led_ramp_mask = MC13783_LEDMDRAMPDOWN | MC13783_LEDMDRAMPUP; 80static uint32_t led_ramp_mask = MC13783_LEDMDRAMPDOWN | MC13783_LEDMDRAMPUP;
81 81
82bool _backlight_init(void) 82bool backlight_hw_init(void)
83{ 83{
84 /* Set default LED register value */ 84 /* Set default LED register value */
85 mc13783_write(MC13783_LED_CONTROL0, 85 mc13783_write(MC13783_LED_CONTROL0,
@@ -88,7 +88,7 @@ bool _backlight_init(void)
88#ifdef HAVE_BACKLIGHT_BRIGHTNESS 88#ifdef HAVE_BACKLIGHT_BRIGHTNESS
89 /* Our PWM and I-Level is different than retailos (but same apparent 89 /* Our PWM and I-Level is different than retailos (but same apparent
90 * brightness), so init to our default. */ 90 * brightness), so init to our default. */
91 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 91 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
92#else 92#else
93 /* Use default PWM */ 93 /* Use default PWM */
94 backlight_pwm_bits = mc13783_read(MC13783_LED_CONTROL2) & MC13783_LEDMDDC; 94 backlight_pwm_bits = mc13783_read(MC13783_LED_CONTROL2) & MC13783_LEDMDDC;
@@ -113,7 +113,7 @@ void backlight_set_fade_in(bool value)
113 led_ramp_mask &= ~MC13783_LEDMDRAMPUP; 113 led_ramp_mask &= ~MC13783_LEDMDRAMPUP;
114} 114}
115 115
116void _backlight_on(void) 116void backlight_hw_on(void)
117{ 117{
118 static const char regs[2] = 118 static const char regs[2] =
119 { 119 {
@@ -149,7 +149,7 @@ void _backlight_on(void)
149 } 149 }
150} 150}
151 151
152void _backlight_off(void) 152void backlight_hw_off(void)
153{ 153{
154 uint32_t ctrl0 = MC13783_LED_CONTROL0_BITS | MC13783_LEDEN; 154 uint32_t ctrl0 = MC13783_LED_CONTROL0_BITS | MC13783_LEDEN;
155 155
@@ -173,7 +173,7 @@ void _backlight_off(void)
173#ifdef HAVE_BACKLIGHT_BRIGHTNESS 173#ifdef HAVE_BACKLIGHT_BRIGHTNESS
174/* Assumes that the backlight has been initialized - parameter should 174/* Assumes that the backlight has been initialized - parameter should
175 * already be range-checked in public interface. */ 175 * already be range-checked in public interface. */
176void _backlight_set_brightness(int brightness) 176void backlight_hw_brightness(int brightness)
177{ 177{
178 uint32_t md = led_md_pwm_table[brightness].md; 178 uint32_t md = led_md_pwm_table[brightness].md;
179 backlight_pwm_bits = backlight_on_status ? 179 backlight_pwm_bits = backlight_on_status ?
diff --git a/firmware/target/arm/imx31/gigabeat-s/backlight-target.h b/firmware/target/arm/imx31/gigabeat-s/backlight-target.h
index 2ae1372815..124fa87b17 100644
--- a/firmware/target/arm/imx31/gigabeat-s/backlight-target.h
+++ b/firmware/target/arm/imx31/gigabeat-s/backlight-target.h
@@ -27,10 +27,10 @@
27#define BACKLIGHT_FULL_INIT 27#define BACKLIGHT_FULL_INIT
28#endif 28#endif
29 29
30bool _backlight_init(void); 30bool backlight_hw_init(void);
31void _backlight_on(void); 31void backlight_hw_on(void);
32void _backlight_off(void); 32void backlight_hw_off(void);
33void _backlight_set_brightness(int brightness); 33void backlight_hw_brightness(int brightness);
34 34
35void _backlight_lcd_sleep(void); 35void _backlight_lcd_sleep(void);
36 36
diff --git a/firmware/target/arm/imx31/gigabeat-s/power-gigabeat-s.c b/firmware/target/arm/imx31/gigabeat-s/power-gigabeat-s.c
index d194a69ab1..5d89802bc9 100644
--- a/firmware/target/arm/imx31/gigabeat-s/power-gigabeat-s.c
+++ b/firmware/target/arm/imx31/gigabeat-s/power-gigabeat-s.c
@@ -136,7 +136,7 @@ void power_off(void)
136 dptc_stop(); 136 dptc_stop();
137 137
138 /* Cut backlight */ 138 /* Cut backlight */
139 _backlight_off(); 139 backlight_hw_off();
140 140
141 /* Let it fade */ 141 /* Let it fade */
142 sleep(5*HZ/4); 142 sleep(5*HZ/4);
diff --git a/firmware/target/arm/ipod/1g2g/backlight-1g2g.c b/firmware/target/arm/ipod/1g2g/backlight-1g2g.c
index b7797813ec..7f1fa7ba42 100644
--- a/firmware/target/arm/ipod/1g2g/backlight-1g2g.c
+++ b/firmware/target/arm/ipod/1g2g/backlight-1g2g.c
@@ -24,13 +24,13 @@
24#include "backlight.h" 24#include "backlight.h"
25#include "backlight-target.h" 25#include "backlight-target.h"
26 26
27void _backlight_on(void) 27void backlight_hw_on(void)
28{ 28{
29 LCD1_CONTROL |= 0x02; 29 LCD1_CONTROL |= 0x02;
30 lcd_set_backlight_inversion(true); 30 lcd_set_backlight_inversion(true);
31} 31}
32 32
33void _backlight_off(void) 33void backlight_hw_off(void)
34{ 34{
35 LCD1_CONTROL &= ~0x02; 35 LCD1_CONTROL &= ~0x02;
36 lcd_set_backlight_inversion(false); 36 lcd_set_backlight_inversion(false);
diff --git a/firmware/target/arm/ipod/1g2g/backlight-target.h b/firmware/target/arm/ipod/1g2g/backlight-target.h
index 22826054aa..e888aa7c3f 100644
--- a/firmware/target/arm/ipod/1g2g/backlight-target.h
+++ b/firmware/target/arm/ipod/1g2g/backlight-target.h
@@ -21,8 +21,8 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() false 24#define backlight_hw_init() false
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27 27
28#endif 28#endif
diff --git a/firmware/target/arm/ipod/3g/backlight-3g.c b/firmware/target/arm/ipod/3g/backlight-3g.c
index 77088e32ec..fcc162310f 100644
--- a/firmware/target/arm/ipod/3g/backlight-3g.c
+++ b/firmware/target/arm/ipod/3g/backlight-3g.c
@@ -23,12 +23,12 @@
23#include "backlight.h" 23#include "backlight.h"
24#include "backlight-target.h" 24#include "backlight-target.h"
25 25
26void _backlight_on(void) 26void backlight_hw_on(void)
27{ 27{
28 LCD1_CONTROL |= 0x02; 28 LCD1_CONTROL |= 0x02;
29} 29}
30 30
31void _backlight_off(void) 31void backlight_hw_off(void)
32{ 32{
33 LCD1_CONTROL &= ~0x02; 33 LCD1_CONTROL &= ~0x02;
34} 34}
diff --git a/firmware/target/arm/ipod/backlight-4g_color.c b/firmware/target/arm/ipod/backlight-4g_color.c
index befb036eab..96ed387625 100644
--- a/firmware/target/arm/ipod/backlight-4g_color.c
+++ b/firmware/target/arm/ipod/backlight-4g_color.c
@@ -44,11 +44,11 @@ static unsigned char log_brightness[32] = {
44static unsigned brightness = 100; /* 1 to 255 */ 44static unsigned brightness = 100; /* 1 to 255 */
45static bool enabled = false; 45static bool enabled = false;
46 46
47/* Handling B03 in _backlight_on() and _backlight_off() makes backlight go off 47/* Handling B03 in backlight_hw_on() and backlight_hw_off() makes backlight go off
48 * without delay. Not doing that does a short (fixed) fade out. Opt for the 48 * without delay. Not doing that does a short (fixed) fade out. Opt for the
49 * latter. */ 49 * latter. */
50 50
51void _backlight_on(void) 51void backlight_hw_on(void)
52{ 52{
53 /* brightness full */ 53 /* brightness full */
54 outl(0x80000000 | (brightness << 16), 0x7000a010); 54 outl(0x80000000 | (brightness << 16), 0x7000a010);
@@ -56,27 +56,27 @@ void _backlight_on(void)
56 enabled = true; 56 enabled = true;
57} 57}
58 58
59void _backlight_off(void) 59void backlight_hw_off(void)
60{ 60{
61 outl(0x80000000, 0x7000a010); 61 outl(0x80000000, 0x7000a010);
62 GPIO_CLEAR_BITWISE(GPIOB_OUTPUT_VAL, 0x08); 62 GPIO_CLEAR_BITWISE(GPIOB_OUTPUT_VAL, 0x08);
63 enabled = false; 63 enabled = false;
64} 64}
65 65
66void _backlight_set_brightness(int val) 66void backlight_hw_brightness(int val)
67{ 67{
68 brightness = log_brightness[val]; 68 brightness = log_brightness[val];
69 if (enabled) 69 if (enabled)
70 outl(0x80000000 | (brightness << 16), 0x7000a010); 70 outl(0x80000000 | (brightness << 16), 0x7000a010);
71} 71}
72 72
73bool _backlight_init(void) 73bool backlight_hw_init(void)
74{ 74{
75 GPIO_SET_BITWISE(GPIOB_ENABLE, 0x0c); /* B02 and B03 enable */ 75 GPIO_SET_BITWISE(GPIOB_ENABLE, 0x0c); /* B02 and B03 enable */
76 GPIO_SET_BITWISE(GPIOB_OUTPUT_VAL, 0x08); /* B03 = 1 */ 76 GPIO_SET_BITWISE(GPIOB_OUTPUT_VAL, 0x08); /* B03 = 1 */
77 GPO32_ENABLE &= ~0x2000000; /* D01 disable, so pwm takes over */ 77 GPO32_ENABLE &= ~0x2000000; /* D01 disable, so pwm takes over */
78 DEV_EN |= DEV_PWM; /* PWM enable */ 78 DEV_EN |= DEV_PWM; /* PWM enable */
79 79
80 _backlight_on(); 80 backlight_hw_on();
81 return true; 81 return true;
82} 82}
diff --git a/firmware/target/arm/ipod/backlight-nano_video.c b/firmware/target/arm/ipod/backlight-nano_video.c
index 2f56f94225..e2e9bf0341 100644
--- a/firmware/target/arm/ipod/backlight-nano_video.c
+++ b/firmware/target/arm/ipod/backlight-nano_video.c
@@ -38,7 +38,7 @@ static int brightness = 1; /* 1 to 32 */
38static int current_dim = 16; /* default after enabling the backlight dimmer */ 38static int current_dim = 16; /* default after enabling the backlight dimmer */
39static bool enabled = false; 39static bool enabled = false;
40 40
41void _backlight_set_brightness(int val) 41void backlight_hw_brightness(int val)
42{ 42{
43 int oldlevel; 43 int oldlevel;
44 44
@@ -91,7 +91,7 @@ void _backlight_hw_enable(bool on)
91 GPIO_SET_BITWISE(GPIOD_OUTPUT_VAL, 0x80); 91 GPIO_SET_BITWISE(GPIOD_OUTPUT_VAL, 0x80);
92 sleep(HZ/100); 92 sleep(HZ/100);
93 current_dim = 16; 93 current_dim = 16;
94 _backlight_set_brightness(brightness); 94 backlight_hw_brightness(brightness);
95 } 95 }
96 else 96 else
97 { 97 {
@@ -116,7 +116,7 @@ void _backlight_led_off(void)
116 GPIO_CLEAR_BITWISE(GPIOL_OUTPUT_VAL, 0x80); 116 GPIO_CLEAR_BITWISE(GPIOL_OUTPUT_VAL, 0x80);
117} 117}
118 118
119bool _backlight_init(void) 119bool backlight_hw_init(void)
120{ 120{
121 GPIO_SET_BITWISE(GPIOB_ENABLE, 0x08); 121 GPIO_SET_BITWISE(GPIOB_ENABLE, 0x08);
122 GPIO_SET_BITWISE(GPIOB_OUTPUT_EN, 0x08); 122 GPIO_SET_BITWISE(GPIOB_OUTPUT_EN, 0x08);
diff --git a/firmware/target/arm/ipod/backlight-target.h b/firmware/target/arm/ipod/backlight-target.h
index 9b6a96b3cb..fef7ee8ce0 100644
--- a/firmware/target/arm/ipod/backlight-target.h
+++ b/firmware/target/arm/ipod/backlight-target.h
@@ -23,8 +23,8 @@
23 23
24#if defined(IPOD_VIDEO) || defined(IPOD_NANO) 24#if defined(IPOD_VIDEO) || defined(IPOD_NANO)
25 25
26bool _backlight_init(void); 26bool backlight_hw_init(void);
27void _backlight_set_brightness(int val); 27void backlight_hw_brightness(int val);
28void _backlight_led_on(void); 28void _backlight_led_on(void);
29void _backlight_led_off(void); 29void _backlight_led_off(void);
30void _backlight_hw_enable(bool on); 30void _backlight_hw_enable(bool on);
@@ -34,48 +34,48 @@ void lcd_awake(void);
34#endif 34#endif
35 35
36#ifdef BOOTLOADER 36#ifdef BOOTLOADER
37#define _backlight_on() do { _backlight_hw_enable(true); \ 37#define backlight_hw_on() do { _backlight_hw_enable(true); \
38 _backlight_led_on(); } while(0) 38 _backlight_led_on(); } while(0)
39#define _backlight_off() do { _backlight_led_off(); \ 39#define backlight_hw_off() do { _backlight_led_off(); \
40 _backlight_hw_enable(false); } while(0) 40 _backlight_hw_enable(false); } while(0)
41#else /* !BOOTLOADER */ 41#else /* !BOOTLOADER */
42#define _backlight_on_isr() _backlight_led_on() 42#define backlight_hw_on_isr() _backlight_led_on()
43#define _backlight_off_isr() _backlight_led_off() 43#define backlight_hw_off_isr() _backlight_led_off()
44#define _backlight_on_normal() do { _backlight_hw_enable(true); \ 44#define backlight_hw_on_normal() do { _backlight_hw_enable(true); \
45 _backlight_led_on(); } while(0) 45 _backlight_led_on(); } while(0)
46#define _backlight_off_normal() do { _backlight_led_off(); \ 46#define backlight_hw_off_normal() do { _backlight_led_off(); \
47 _backlight_hw_enable(false); } while(0) 47 _backlight_hw_enable(false); } while(0)
48#define _BACKLIGHT_FADE_ENABLE 48#define _BACKLIGHT_FADE_ENABLE
49#endif /* !BOOTLOADER */ 49#endif /* !BOOTLOADER */
50 50
51#elif defined(IPOD_4G) || defined(IPOD_COLOR) 51#elif defined(IPOD_4G) || defined(IPOD_COLOR)
52 52
53bool _backlight_init(void); 53bool backlight_hw_init(void);
54void _backlight_on(void); 54void backlight_hw_on(void);
55void _backlight_off(void); 55void backlight_hw_off(void);
56void _backlight_set_brightness(int val); 56void backlight_hw_brightness(int val);
57 57
58#elif defined(IPOD_MINI) || defined(IPOD_MINI2G) 58#elif defined(IPOD_MINI) || defined(IPOD_MINI2G)
59 59
60#define _backlight_init() true 60#define backlight_hw_init() true
61void _backlight_hw_on(void); 61void _backlight_hw_on(void);
62void _backlight_hw_off(void); 62void _backlight_hw_off(void);
63 63
64#ifdef BOOTLOADER 64#ifdef BOOTLOADER
65#define _backlight_on() _backlight_hw_on() 65#define backlight_hw_on() _backlight_hw_on()
66#define _backlight_off() _backlight_hw_off() 66#define backlight_hw_off() _backlight_hw_off()
67#else 67#else
68#define _backlight_on_isr() _backlight_hw_on() 68#define backlight_hw_on_isr() _backlight_hw_on()
69#define _backlight_off_isr() _backlight_hw_off() 69#define backlight_hw_off_isr() _backlight_hw_off()
70#define _backlight_on_normal() _backlight_hw_on() 70#define backlight_hw_on_normal() _backlight_hw_on()
71#define _backlight_off_normal() _backlight_hw_off() 71#define backlight_hw_off_normal() _backlight_hw_off()
72#endif 72#endif
73 73
74#elif defined(IPOD_1G2G) || defined(IPOD_3G) 74#elif defined(IPOD_1G2G) || defined(IPOD_3G)
75 75
76#define _backlight_init() true 76#define backlight_hw_init() true
77void _backlight_on(void); 77void backlight_hw_on(void);
78void _backlight_off(void); 78void backlight_hw_off(void);
79#endif 79#endif
80 80
81#endif 81#endif
diff --git a/firmware/target/arm/ipod/button-1g-3g.c b/firmware/target/arm/ipod/button-1g-3g.c
index 045a0f6d8a..67aa7eb336 100644
--- a/firmware/target/arm/ipod/button-1g-3g.c
+++ b/firmware/target/arm/ipod/button-1g-3g.c
@@ -66,7 +66,7 @@ static void handle_scroll_wheel(int new_scroll)
66 static int prev_scroll = -1; 66 static int prev_scroll = -1;
67 static int direction = 0; 67 static int direction = 0;
68 static int count = 0; 68 static int count = 0;
69 static long next_backlight_on = 0; 69 static long nextbacklight_hw_on = 0;
70 70
71 static unsigned long last_wheel_usec = 0; 71 static unsigned long last_wheel_usec = 0;
72 static unsigned long wheel_delta = 1ul << 24; 72 static unsigned long wheel_delta = 1ul << 24;
@@ -96,10 +96,10 @@ static void handle_scroll_wheel(int new_scroll)
96 } 96 }
97 97
98 /* poke backlight every 1/4s of activity */ 98 /* poke backlight every 1/4s of activity */
99 if (TIME_AFTER(current_tick, next_backlight_on)) { 99 if (TIME_AFTER(current_tick, nextbacklight_hw_on)) {
100 backlight_on(); 100 backlight_on();
101 reset_poweroff_timer(); 101 reset_poweroff_timer();
102 next_backlight_on = current_tick + HZ/4; 102 nextbacklight_hw_on = current_tick + HZ/4;
103 } 103 }
104 104
105 /* has wheel travelled far enough? */ 105 /* has wheel travelled far enough? */
@@ -152,7 +152,7 @@ static void handle_scroll_wheel(int new_scroll)
152 wheel_velocity = v; 152 wheel_velocity = v;
153 /* ensure backlight never gets stuck for an extended period if tick 153 /* ensure backlight never gets stuck for an extended period if tick
154 * wrapped such that next poke is very far ahead */ 154 * wrapped such that next poke is very far ahead */
155 next_backlight_on = current_tick - 1; 155 nextbacklight_hw_on = current_tick - 1;
156 } 156 }
157 else { 157 else {
158 /* some velocity filtering to smooth things out */ 158 /* some velocity filtering to smooth things out */
diff --git a/firmware/target/arm/ipod/button-mini1g.c b/firmware/target/arm/ipod/button-mini1g.c
index d4a75c90d8..a508958de1 100644
--- a/firmware/target/arm/ipod/button-mini1g.c
+++ b/firmware/target/arm/ipod/button-mini1g.c
@@ -60,7 +60,7 @@ static void handle_scroll_wheel(int new_scroll)
60 static int prev_scroll = -1; 60 static int prev_scroll = -1;
61 static int direction = 0; 61 static int direction = 0;
62 static int count = 0; 62 static int count = 0;
63 static long next_backlight_on = 0; 63 static long nextbacklight_hw_on = 0;
64 64
65 int wheel_keycode = BUTTON_NONE; 65 int wheel_keycode = BUTTON_NONE;
66 int scroll; 66 int scroll;
@@ -92,10 +92,10 @@ static void handle_scroll_wheel(int new_scroll)
92 } 92 }
93 93
94 /* poke backlight every 1/4s of activity */ 94 /* poke backlight every 1/4s of activity */
95 if (TIME_AFTER(current_tick, next_backlight_on)) { 95 if (TIME_AFTER(current_tick, nextbacklight_hw_on)) {
96 backlight_on(); 96 backlight_on();
97 reset_poweroff_timer(); 97 reset_poweroff_timer();
98 next_backlight_on = current_tick + HZ/4; 98 nextbacklight_hw_on = current_tick + HZ/4;
99 } 99 }
100 100
101 if (++count < WHEEL_BASE_SENSITIVITY) 101 if (++count < WHEEL_BASE_SENSITIVITY)
@@ -144,7 +144,7 @@ static void handle_scroll_wheel(int new_scroll)
144 wheel_velocity = v; 144 wheel_velocity = v;
145 /* ensure backlight never gets stuck for an extended period if tick 145 /* ensure backlight never gets stuck for an extended period if tick
146 * wrapped such that next poke is very far ahead */ 146 * wrapped such that next poke is very far ahead */
147 next_backlight_on = current_tick - 1; 147 nextbacklight_hw_on = current_tick - 1;
148 } 148 }
149 else { 149 else {
150 /* some velocity filtering to smooth things out */ 150 /* some velocity filtering to smooth things out */
diff --git a/firmware/target/arm/ipod/lcd-color_nano.c b/firmware/target/arm/ipod/lcd-color_nano.c
index c7676fa721..67d26aa862 100644
--- a/firmware/target/arm/ipod/lcd-color_nano.c
+++ b/firmware/target/arm/ipod/lcd-color_nano.c
@@ -122,7 +122,7 @@ void lcd_shutdown(void) {
122#if defined(IPOD_NANO) 122#if defined(IPOD_NANO)
123 _backlight_hw_enable(false); 123 _backlight_hw_enable(false);
124#elif defined(IPOD_COLOR) 124#elif defined(IPOD_COLOR)
125 _backlight_off(); 125 backlight_hw_off();
126#endif 126#endif
127 127
128 if ((lcd_type&1) == 0) { 128 if ((lcd_type&1) == 0) {
diff --git a/firmware/target/arm/iriver/backlight-target.h b/firmware/target/arm/iriver/backlight-target.h
index a27b489319..3882964207 100644
--- a/firmware/target/arm/iriver/backlight-target.h
+++ b/firmware/target/arm/iriver/backlight-target.h
@@ -21,8 +21,8 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27 27
28#endif 28#endif
diff --git a/firmware/target/arm/iriver/h10/backlight-h10.c b/firmware/target/arm/iriver/h10/backlight-h10.c
index db10f39057..80dfdd88c1 100644
--- a/firmware/target/arm/iriver/h10/backlight-h10.c
+++ b/firmware/target/arm/iriver/h10/backlight-h10.c
@@ -25,7 +25,7 @@
25#include "backlight-target.h" 25#include "backlight-target.h"
26#include "lcd.h" 26#include "lcd.h"
27 27
28void _backlight_on(void) 28void backlight_hw_on(void)
29{ 29{
30#ifdef HAVE_LCD_ENABLE 30#ifdef HAVE_LCD_ENABLE
31 lcd_enable(true); /* power on lcd + visible display */ 31 lcd_enable(true); /* power on lcd + visible display */
@@ -33,7 +33,7 @@ void _backlight_on(void)
33 GPIO_SET_BITWISE(GPIOL_OUTPUT_VAL, 0x20); 33 GPIO_SET_BITWISE(GPIOL_OUTPUT_VAL, 0x20);
34} 34}
35 35
36void _backlight_off(void) 36void backlight_hw_off(void)
37{ 37{
38 GPIO_CLEAR_BITWISE(GPIOL_OUTPUT_VAL, 0x20); 38 GPIO_CLEAR_BITWISE(GPIOL_OUTPUT_VAL, 0x20);
39#ifdef HAVE_LCD_ENABLE 39#ifdef HAVE_LCD_ENABLE
diff --git a/firmware/target/arm/olympus/mrobe-100/backlight-mr100.c b/firmware/target/arm/olympus/mrobe-100/backlight-mr100.c
index f3891c5000..b39010ff0e 100644
--- a/firmware/target/arm/olympus/mrobe-100/backlight-mr100.c
+++ b/firmware/target/arm/olympus/mrobe-100/backlight-mr100.c
@@ -28,22 +28,22 @@
28static const int log_brightness[12] = {0,4,8,12,20,28,40,60,88,124,176,255}; 28static const int log_brightness[12] = {0,4,8,12,20,28,40,60,88,124,176,255};
29 29
30/* Returns the current state of the backlight (true=ON, false=OFF). */ 30/* Returns the current state of the backlight (true=ON, false=OFF). */
31bool _backlight_init(void) 31bool backlight_hw_init(void)
32{ 32{
33 return (GPO32_ENABLE & 0x1000000) ? true : false; 33 return (GPO32_ENABLE & 0x1000000) ? true : false;
34} 34}
35 35
36void _backlight_hw_on(void) 36void backlight_hw_on(void)
37{ 37{
38 GPO32_ENABLE |= 0x1000000; 38 GPO32_ENABLE |= 0x1000000;
39} 39}
40 40
41void _backlight_hw_off(void) 41void backlight_hw_off(void)
42{ 42{
43 GPO32_ENABLE &= ~0x1000000; 43 GPO32_ENABLE &= ~0x1000000;
44} 44}
45 45
46void _buttonlight_set_brightness(int brightness) 46void buttonlight_hw_brightness(int brightness)
47{ 47{
48 /* clamp the brightness value */ 48 /* clamp the brightness value */
49 brightness = MAX(0, MIN(15, brightness)); 49 brightness = MAX(0, MIN(15, brightness));
@@ -51,13 +51,13 @@ void _buttonlight_set_brightness(int brightness)
51 outl(MIN_BRIGHTNESS-(log_brightness[brightness - 1] << 16), 0x7000a010); 51 outl(MIN_BRIGHTNESS-(log_brightness[brightness - 1] << 16), 0x7000a010);
52} 52}
53 53
54void _buttonlight_on(void) 54void buttonlight_hw_on(void)
55{ 55{
56 /* turn on all touchpad leds */ 56 /* turn on all touchpad leds */
57 GPIOA_OUTPUT_VAL |= BUTTONLIGHT_ALL; 57 GPIOA_OUTPUT_VAL |= BUTTONLIGHT_ALL;
58} 58}
59 59
60void _buttonlight_off(void) 60void buttonlight_hw_off(void)
61{ 61{
62 /* turn off all touchpad leds */ 62 /* turn off all touchpad leds */
63 GPIOA_OUTPUT_VAL &= ~BUTTONLIGHT_ALL; 63 GPIOA_OUTPUT_VAL &= ~BUTTONLIGHT_ALL;
diff --git a/firmware/target/arm/olympus/mrobe-100/backlight-target.h b/firmware/target/arm/olympus/mrobe-100/backlight-target.h
index df25106d1a..725e1ad622 100644
--- a/firmware/target/arm/olympus/mrobe-100/backlight-target.h
+++ b/firmware/target/arm/olympus/mrobe-100/backlight-target.h
@@ -22,23 +22,20 @@
22#ifndef BACKLIGHT_TARGET_H 22#ifndef BACKLIGHT_TARGET_H
23#define BACKLIGHT_TARGET_H 23#define BACKLIGHT_TARGET_H
24 24
25bool _backlight_init(void); /* Returns backlight current state (true=ON). */ 25bool backlight_hw_init(void); /* Returns backlight current state (true=ON). */
26void _backlight_hw_on(void); 26void _backlight_hw_on(void);
27void _backlight_hw_off(void); 27void _backlight_hw_off(void);
28 28
29#ifdef HAVE_REMOTE_LCD 29#ifdef HAVE_REMOTE_LCD
30void _remote_backlight_on(void); 30void remote_backlight_hw_on(void);
31void _remote_backlight_off(void); 31void remote_backlight_hw_off(void);
32#endif 32#endif
33 33
34#ifdef BOOTLOADER 34#ifndef BOOTLOADER
35#define _backlight_on() _backlight_hw_on() 35#define _backlight_on_isr() backlight_hw_on()
36#define _backlight_off() _backlight_hw_off() 36#define _backlight_off_isr() backlight_hw_off()
37#else 37#define _backlight_on_normal() backlight_hw_on()
38#define _backlight_on_isr() _backlight_hw_on() 38#define _backlight_off_normal() backlight_hw_off()
39#define _backlight_off_isr() _backlight_hw_off()
40#define _backlight_on_normal() _backlight_hw_on()
41#define _backlight_off_normal() _backlight_hw_off()
42#define _BACKLIGHT_FADE_BOOST 39#define _BACKLIGHT_FADE_BOOST
43#endif 40#endif
44 41
@@ -53,8 +50,8 @@ void _remote_backlight_off(void);
53 BUTTONLIGHT_DISPLAY | BUTTONLIGHT_LEFT | \ 50 BUTTONLIGHT_DISPLAY | BUTTONLIGHT_LEFT | \
54 BUTTONLIGHT_RIGHT | BUTTONLIGHT_SCROLL) 51 BUTTONLIGHT_RIGHT | BUTTONLIGHT_SCROLL)
55 52
56void _buttonlight_set_brightness(int brightness); 53void buttonlight_hw_brightness(int brightness);
57void _buttonlight_on(void); 54void buttonlight_hw_on(void);
58void _buttonlight_off(void); 55void buttonlight_hw_off(void);
59 56
60#endif 57#endif
diff --git a/firmware/target/arm/olympus/mrobe-100/lcd-remote-mr100.c b/firmware/target/arm/olympus/mrobe-100/lcd-remote-mr100.c
index 34b114910a..22bc4fb0d8 100644
--- a/firmware/target/arm/olympus/mrobe-100/lcd-remote-mr100.c
+++ b/firmware/target/arm/olympus/mrobe-100/lcd-remote-mr100.c
@@ -552,13 +552,13 @@ void lcd_remote_update_rect(int x, int y, int width, int height)
552 rc_status |= RC_UPDATE_LCD; 552 rc_status |= RC_UPDATE_LCD;
553} 553}
554 554
555void _remote_backlight_on(void) 555void remote_backlight_hw_on(void)
556{ 556{
557 rc_status |= RC_BACKLIGHT_ON; 557 rc_status |= RC_BACKLIGHT_ON;
558 rc_status |= RC_UPDATE_CONTROLLER; 558 rc_status |= RC_UPDATE_CONTROLLER;
559} 559}
560 560
561void _remote_backlight_off(void) 561void remote_backlight_hw_off(void)
562{ 562{
563 rc_status &= ~RC_BACKLIGHT_ON; 563 rc_status &= ~RC_BACKLIGHT_ON;
564 rc_status |= RC_UPDATE_CONTROLLER; 564 rc_status |= RC_UPDATE_CONTROLLER;
diff --git a/firmware/target/arm/pbell/vibe500/backlight-target.h b/firmware/target/arm/pbell/vibe500/backlight-target.h
index 7fd6d877fb..396fea3007 100644
--- a/firmware/target/arm/pbell/vibe500/backlight-target.h
+++ b/firmware/target/arm/pbell/vibe500/backlight-target.h
@@ -21,18 +21,18 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27 27
28#ifdef HAVE_BACKLIGHT_BRIGHTNESS 28#ifdef HAVE_BACKLIGHT_BRIGHTNESS
29void _backlight_set_brightness(int brightness); 29void backlight_hw_brightness(int brightness);
30#endif 30#endif
31 31
32#ifdef HAVE_BUTTON_LIGHT 32#ifdef HAVE_BUTTON_LIGHT
33void _buttonlight_on(void); 33voidbuttonlight_hw_on(void);
34void _buttonlight_off(void); 34voidbuttonlight_hw_off(void);
35void _buttonlight_set_brightness(int brightness); 35voidbuttonlight_hw_set_brightness(int brightness);
36#endif 36#endif
37 37
38#endif /* BACKLIGHT_TARGET.H */ 38#endif /* BACKLIGHT_TARGET.H */
diff --git a/firmware/target/arm/pbell/vibe500/backlight-vibe500.c b/firmware/target/arm/pbell/vibe500/backlight-vibe500.c
index ab71012bdb..1d03ddddf0 100644
--- a/firmware/target/arm/pbell/vibe500/backlight-vibe500.c
+++ b/firmware/target/arm/pbell/vibe500/backlight-vibe500.c
@@ -27,7 +27,7 @@
27#include "lcd.h" 27#include "lcd.h"
28#include "synaptics-mep.h" 28#include "synaptics-mep.h"
29 29
30void _backlight_on(void) 30void backlight_hw_on(void)
31{ 31{
32#ifdef HAVE_LCD_ENABLE 32#ifdef HAVE_LCD_ENABLE
33 lcd_enable(true); /* power on lcd + visible display */ 33 lcd_enable(true); /* power on lcd + visible display */
@@ -35,7 +35,7 @@ void _backlight_on(void)
35 GPIO_SET_BITWISE(GPIOJ_OUTPUT_VAL, 0x01); 35 GPIO_SET_BITWISE(GPIOJ_OUTPUT_VAL, 0x01);
36} 36}
37 37
38void _backlight_off(void) 38void backlight_hw_off(void)
39{ 39{
40 GPIO_CLEAR_BITWISE(GPIOJ_OUTPUT_VAL, 0x01); 40 GPIO_CLEAR_BITWISE(GPIOJ_OUTPUT_VAL, 0x01);
41#ifdef HAVE_LCD_ENABLE 41#ifdef HAVE_LCD_ENABLE
@@ -47,7 +47,7 @@ void _backlight_off(void)
47static const int brightness_vals[16] = 47static const int brightness_vals[16] =
48 {255,237,219,201,183,165,147,130,112,94,76,58,40,22,5,0}; 48 {255,237,219,201,183,165,147,130,112,94,76,58,40,22,5,0};
49 49
50void _backlight_set_brightness(int brightness) 50void backlight_hw_brightness(int brightness)
51{ 51{
52 /* From PB Vibe Bootloader and OF */ 52 /* From PB Vibe Bootloader and OF */
53 DEV_INIT1&=0xFFFF3F3F; 53 DEV_INIT1&=0xFFFF3F3F;
@@ -60,7 +60,7 @@ void _backlight_set_brightness(int brightness)
60#ifdef HAVE_BUTTON_LIGHT 60#ifdef HAVE_BUTTON_LIGHT
61static unsigned short buttonlight_status = 0; 61static unsigned short buttonlight_status = 0;
62 62
63void _buttonlight_on(void) 63void buttonlight_hw_on(void)
64{ 64{
65 if (!buttonlight_status) 65 if (!buttonlight_status)
66 { 66 {
@@ -69,7 +69,7 @@ void _buttonlight_on(void)
69 } 69 }
70} 70}
71 71
72void _buttonlight_off(void) 72void buttonlight_hw_off(void)
73{ 73{
74 if (buttonlight_status) 74 if (buttonlight_status)
75 { 75 {
@@ -78,7 +78,7 @@ void _buttonlight_off(void)
78 } 78 }
79} 79}
80 80
81void _buttonlight_set_brightness(int brightness) 81void buttonlight_hw_brightness(int brightness)
82{ 82{
83 /* no brightness control, but lights stays on - for compatibility */ 83 /* no brightness control, but lights stays on - for compatibility */
84 (void)brightness; 84 (void)brightness;
diff --git a/firmware/target/arm/philips/hdd1630/backlight-hdd1630.c b/firmware/target/arm/philips/hdd1630/backlight-hdd1630.c
index 95a9ad8b86..efa85723a1 100644
--- a/firmware/target/arm/philips/hdd1630/backlight-hdd1630.c
+++ b/firmware/target/arm/philips/hdd1630/backlight-hdd1630.c
@@ -29,13 +29,13 @@
29static const int brightness_vals[16] = 29static const int brightness_vals[16] =
30 {255,237,219,201,183,165,147,130,112,94,76,58,40,22,5,0}; 30 {255,237,219,201,183,165,147,130,112,94,76,58,40,22,5,0};
31 31
32void _backlight_set_brightness(int brightness) 32void backlight_hw_brightness(int brightness)
33{ 33{
34 outl(0x80000000 | (brightness_vals[brightness-1] << 16), 0x7000a000); 34 outl(0x80000000 | (brightness_vals[brightness-1] << 16), 0x7000a000);
35} 35}
36#endif 36#endif
37 37
38void _backlight_on(void) 38void backlight_hw_on(void)
39{ 39{
40#ifdef HAVE_LCD_ENABLE 40#ifdef HAVE_LCD_ENABLE
41 lcd_enable(true); 41 lcd_enable(true);
@@ -45,7 +45,7 @@ void _backlight_on(void)
45 GPO32_VAL |= 0x400; 45 GPO32_VAL |= 0x400;
46} 46}
47 47
48void _backlight_off(void) 48void backlight_hw_off(void)
49{ 49{
50 GPO32_ENABLE |= 0x400; 50 GPO32_ENABLE |= 0x400;
51 GPO32_VAL &=~0x400; 51 GPO32_VAL &=~0x400;
@@ -60,7 +60,7 @@ void _backlight_off(void)
60static unsigned short buttonight_brightness = DEFAULT_BRIGHTNESS_SETTING - 1; 60static unsigned short buttonight_brightness = DEFAULT_BRIGHTNESS_SETTING - 1;
61static unsigned short buttonlight_status = 0; 61static unsigned short buttonlight_status = 0;
62 62
63void _buttonlight_on(void) 63void buttonlight_hw_on(void)
64{ 64{
65 if (!buttonlight_status) 65 if (!buttonlight_status)
66 { 66 {
@@ -69,7 +69,7 @@ void _buttonlight_on(void)
69 } 69 }
70} 70}
71 71
72void _buttonlight_off(void) 72void buttonlight_hw_off(void)
73{ 73{
74 if (buttonlight_status) 74 if (buttonlight_status)
75 { 75 {
@@ -78,7 +78,7 @@ void _buttonlight_off(void)
78 } 78 }
79} 79}
80 80
81void _buttonlight_set_brightness(int brightness) 81void buttonlight_hw_brightness(int brightness)
82{ 82{
83 buttonight_brightness = brightness - 1; 83 buttonight_brightness = brightness - 1;
84 touchpad_set_buttonlights(BUTTONLIGHT_MASK, buttonight_brightness); 84 touchpad_set_buttonlights(BUTTONLIGHT_MASK, buttonight_brightness);
diff --git a/firmware/target/arm/philips/hdd1630/backlight-target.h b/firmware/target/arm/philips/hdd1630/backlight-target.h
index 63f3f5a8df..d79f09a8a6 100644
--- a/firmware/target/arm/philips/hdd1630/backlight-target.h
+++ b/firmware/target/arm/philips/hdd1630/backlight-target.h
@@ -21,18 +21,18 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27 27
28#ifdef HAVE_BACKLIGHT_BRIGHTNESS 28#ifdef HAVE_BACKLIGHT_BRIGHTNESS
29void _backlight_set_brightness(int brightness); 29void backlight_hw_brightness(int brightness);
30#endif 30#endif
31 31
32#ifdef HAVE_BUTTON_LIGHT 32#ifdef HAVE_BUTTON_LIGHT
33void _buttonlight_on(void); 33void buttonlight_hw_on(void);
34void _buttonlight_off(void); 34void buttonlight_hw_off(void);
35void _buttonlight_set_brightness(int brightness); 35void buttonlight_hw_brightness(int brightness);
36#endif 36#endif
37 37
38#endif 38#endif
diff --git a/firmware/target/arm/philips/hdd6330/backlight-hdd6330.c b/firmware/target/arm/philips/hdd6330/backlight-hdd6330.c
index 46c03e712e..b6422a5aa9 100644
--- a/firmware/target/arm/philips/hdd6330/backlight-hdd6330.c
+++ b/firmware/target/arm/philips/hdd6330/backlight-hdd6330.c
@@ -29,13 +29,13 @@
29static const int brightness_vals[16] = 29static const int brightness_vals[16] =
30 {255,237,219,201,183,165,147,130,112,94,76,58,40,22,5,0}; 30 {255,237,219,201,183,165,147,130,112,94,76,58,40,22,5,0};
31 31
32void _backlight_set_brightness(int brightness) 32void backlight_hw_brightness(int brightness)
33{ 33{
34 outl(0x80000000 | (brightness_vals[brightness-1] << 16), 0x7000a000); 34 outl(0x80000000 | (brightness_vals[brightness-1] << 16), 0x7000a000);
35} 35}
36#endif 36#endif
37 37
38void _backlight_on(void) 38void backlight_hw_on(void)
39{ 39{
40#ifdef HAVE_LCD_ENABLE 40#ifdef HAVE_LCD_ENABLE
41 lcd_enable(true); 41 lcd_enable(true);
@@ -45,7 +45,7 @@ void _backlight_on(void)
45 GPO32_VAL |= 0x400; 45 GPO32_VAL |= 0x400;
46} 46}
47 47
48void _backlight_off(void) 48void backlight_hw_off(void)
49{ 49{
50 GPO32_ENABLE |= 0x400; 50 GPO32_ENABLE |= 0x400;
51 GPO32_VAL &= ~0x400; 51 GPO32_VAL &= ~0x400;
@@ -60,7 +60,7 @@ void _backlight_off(void)
60static unsigned short buttonight_brightness = DEFAULT_BRIGHTNESS_SETTING - 1; 60static unsigned short buttonight_brightness = DEFAULT_BRIGHTNESS_SETTING - 1;
61static unsigned short buttonlight_status = 0; 61static unsigned short buttonlight_status = 0;
62 62
63void _buttonlight_on(void) 63void buttonlight_hw_on(void)
64{ 64{
65 if (!buttonlight_status) 65 if (!buttonlight_status)
66 { 66 {
@@ -77,7 +77,7 @@ void _buttonlight_on(void)
77 } 77 }
78} 78}
79 79
80void _buttonlight_off(void) 80void buttonlight_hw_off(void)
81{ 81{
82 if (buttonlight_status) 82 if (buttonlight_status)
83 { 83 {
@@ -89,7 +89,7 @@ void _buttonlight_off(void)
89 } 89 }
90} 90}
91 91
92void _buttonlight_set_brightness(int brightness) 92void buttonlight_hw_brightness(int brightness)
93{ 93{
94 touchpad_set_parameter(0x01,0x21,0x01); 94 touchpad_set_parameter(0x01,0x21,0x01);
95 touchpad_set_parameter(0x00,0x22,0x15); 95 touchpad_set_parameter(0x00,0x22,0x15);
diff --git a/firmware/target/arm/philips/hdd6330/backlight-target.h b/firmware/target/arm/philips/hdd6330/backlight-target.h
index 63f3f5a8df..d79f09a8a6 100644
--- a/firmware/target/arm/philips/hdd6330/backlight-target.h
+++ b/firmware/target/arm/philips/hdd6330/backlight-target.h
@@ -21,18 +21,18 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27 27
28#ifdef HAVE_BACKLIGHT_BRIGHTNESS 28#ifdef HAVE_BACKLIGHT_BRIGHTNESS
29void _backlight_set_brightness(int brightness); 29void backlight_hw_brightness(int brightness);
30#endif 30#endif
31 31
32#ifdef HAVE_BUTTON_LIGHT 32#ifdef HAVE_BUTTON_LIGHT
33void _buttonlight_on(void); 33void buttonlight_hw_on(void);
34void _buttonlight_off(void); 34void buttonlight_hw_off(void);
35void _buttonlight_set_brightness(int brightness); 35void buttonlight_hw_brightness(int brightness);
36#endif 36#endif
37 37
38#endif 38#endif
diff --git a/firmware/target/arm/philips/power-hdd.c b/firmware/target/arm/philips/power-hdd.c
index a7f1302a7c..d38c6de2b4 100644
--- a/firmware/target/arm/philips/power-hdd.c
+++ b/firmware/target/arm/philips/power-hdd.c
@@ -111,7 +111,7 @@ bool ide_powered(void)
111 111
112void power_off(void) 112void power_off(void)
113{ 113{
114 _backlight_off(); 114 backlight_hw_off();
115 sleep(HZ/10); 115 sleep(HZ/10);
116 116
117 /* power off bit */ 117 /* power off bit */
diff --git a/firmware/target/arm/philips/sa9200/backlight-sa9200.c b/firmware/target/arm/philips/sa9200/backlight-sa9200.c
index 0de4c05df5..7046d09910 100644
--- a/firmware/target/arm/philips/sa9200/backlight-sa9200.c
+++ b/firmware/target/arm/philips/sa9200/backlight-sa9200.c
@@ -27,12 +27,12 @@
27#include "synaptics-mep.h" 27#include "synaptics-mep.h"
28#include "lcd.h" 28#include "lcd.h"
29 29
30void _backlight_set_brightness(int brightness) 30void backlight_hw_brightness(int brightness)
31{ 31{
32 ascodec_write(AS3514_DCDC15, brightness); 32 ascodec_write(AS3514_DCDC15, brightness);
33} 33}
34 34
35void _backlight_on(void) 35void backlight_hw_on(void)
36{ 36{
37#ifdef HAVE_LCD_ENABLE 37#ifdef HAVE_LCD_ENABLE
38 lcd_enable(true); /* power on lcd + visible display */ 38 lcd_enable(true); /* power on lcd + visible display */
@@ -40,13 +40,13 @@ void _backlight_on(void)
40#if (CONFIG_BACKLIGHT_FADING != BACKLIGHT_FADING_SW_SETTING) /* in bootloader/sim */ 40#if (CONFIG_BACKLIGHT_FADING != BACKLIGHT_FADING_SW_SETTING) /* in bootloader/sim */
41 /* if we set the brightness to the settings value, then fading up 41 /* if we set the brightness to the settings value, then fading up
42 * is glitchy */ 42 * is glitchy */
43 _backlight_set_brightness(backlight_brightness); 43 backlight_hw_brightness(backlight_brightness);
44#endif 44#endif
45} 45}
46 46
47void _backlight_off(void) 47void backlight_hw_off(void)
48{ 48{
49 _backlight_set_brightness(0); 49 backlight_hw_brightness(0);
50#ifdef HAVE_LCD_ENABLE 50#ifdef HAVE_LCD_ENABLE
51 lcd_enable(false); /* power off visible display */ 51 lcd_enable(false); /* power off visible display */
52#endif 52#endif
@@ -58,7 +58,7 @@ void _backlight_off(void)
58#define BUTTONLIGHT_MAX 0x0f 58#define BUTTONLIGHT_MAX 0x0f
59static unsigned short buttonlight_status = 0; 59static unsigned short buttonlight_status = 0;
60 60
61void _buttonlight_on(void) 61void buttonlight_hw_on(void)
62{ 62{
63 if (!buttonlight_status) 63 if (!buttonlight_status)
64 { 64 {
@@ -68,7 +68,7 @@ void _buttonlight_on(void)
68 } 68 }
69} 69}
70 70
71void _buttonlight_off(void) 71void buttonlight_hw_off(void)
72{ 72{
73 if (buttonlight_status) 73 if (buttonlight_status)
74 { 74 {
diff --git a/firmware/target/arm/philips/sa9200/backlight-target.h b/firmware/target/arm/philips/sa9200/backlight-target.h
index 9d695e5a22..349f2e2b57 100644
--- a/firmware/target/arm/philips/sa9200/backlight-target.h
+++ b/firmware/target/arm/philips/sa9200/backlight-target.h
@@ -21,15 +21,15 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28int __backlight_is_on(void); 28int __backlight_is_on(void);
29 29
30#ifdef HAVE_BUTTON_LIGHT 30#ifdef HAVE_BUTTON_LIGHT
31void _buttonlight_on(void); 31void buttonlight_hw_on(void);
32void _buttonlight_off(void); 32void buttonlight_hw_off(void);
33#endif 33#endif
34 34
35#endif 35#endif
diff --git a/firmware/target/arm/pnx0101/backlight-target.h b/firmware/target/arm/pnx0101/backlight-target.h
index 40152f1fda..7ebe85d66f 100644
--- a/firmware/target/arm/pnx0101/backlight-target.h
+++ b/firmware/target/arm/pnx0101/backlight-target.h
@@ -21,8 +21,8 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27 27
28#endif 28#endif
diff --git a/firmware/target/arm/pnx0101/iriver-ifp7xx/backlight-ifp7xx.c b/firmware/target/arm/pnx0101/iriver-ifp7xx/backlight-ifp7xx.c
index 6cf2422d60..8be7a59de2 100644
--- a/firmware/target/arm/pnx0101/iriver-ifp7xx/backlight-ifp7xx.c
+++ b/firmware/target/arm/pnx0101/iriver-ifp7xx/backlight-ifp7xx.c
@@ -24,12 +24,12 @@
24#include "backlight.h" 24#include "backlight.h"
25#include "lcd.h" 25#include "lcd.h"
26 26
27void _backlight_on(void) 27void backlight_hw_on(void)
28{ 28{
29 GPIO3_SET = 1; 29 GPIO3_SET = 1;
30} 30}
31 31
32void _backlight_off(void) 32void backlight_hw_off(void)
33{ 33{
34 GPIO3_CLR = 1; 34 GPIO3_CLR = 1;
35} 35}
diff --git a/firmware/target/arm/rk27xx/backlight-rk27xx.c b/firmware/target/arm/rk27xx/backlight-rk27xx.c
index 361d18c948..1756fcdb29 100644
--- a/firmware/target/arm/rk27xx/backlight-rk27xx.c
+++ b/firmware/target/arm/rk27xx/backlight-rk27xx.c
@@ -77,7 +77,7 @@ static const unsigned short lin_brightness[] = {
77}; 77};
78#endif 78#endif
79 79
80bool _backlight_init(void) 80bool backlight_hw_init(void)
81{ 81{
82 /* configure PD4 as output */ 82 /* configure PD4 as output */
83 GPIO_PDCON |= (1<<4); 83 GPIO_PDCON |= (1<<4);
@@ -105,7 +105,7 @@ bool _backlight_init(void)
105 return true; 105 return true;
106} 106}
107 107
108void _backlight_on(void) 108void backlight_hw_on(void)
109{ 109{
110#ifdef HAVE_LCD_ENABLE 110#ifdef HAVE_LCD_ENABLE
111 lcd_enable(true); 111 lcd_enable(true);
@@ -120,7 +120,7 @@ void _backlight_on(void)
120 PWMT0_CTRL |= (1<<3) | (1<<0); 120 PWMT0_CTRL |= (1<<3) | (1<<0);
121} 121}
122 122
123void _backlight_off(void) 123void backlight_hw_off(void)
124{ 124{
125 /* setup PWM0 pin as GPIO which is pulled low */ 125 /* setup PWM0 pin as GPIO which is pulled low */
126 SCU_IOMUXB_CON &= ~(1<<11); 126 SCU_IOMUXB_CON &= ~(1<<11);
@@ -135,7 +135,7 @@ void _backlight_off(void)
135#endif 135#endif
136} 136}
137 137
138void _backlight_set_brightness(int val) 138void backlight_hw_brightness(int val)
139{ 139{
140 brightness = val & 0x1f; 140 brightness = val & 0x1f;
141 PWMT0_HRC = lin_brightness[brightness]; 141 PWMT0_HRC = lin_brightness[brightness];
diff --git a/firmware/target/arm/rk27xx/backlight-target.h b/firmware/target/arm/rk27xx/backlight-target.h
index 91579b080d..a436186791 100644
--- a/firmware/target/arm/rk27xx/backlight-target.h
+++ b/firmware/target/arm/rk27xx/backlight-target.h
@@ -21,9 +21,9 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#endif 29#endif
diff --git a/firmware/target/arm/s3c2440/gigabeat-fx/backlight-meg-fx.c b/firmware/target/arm/s3c2440/gigabeat-fx/backlight-meg-fx.c
index f3d9aac168..c30eb8d812 100644
--- a/firmware/target/arm/s3c2440/gigabeat-fx/backlight-meg-fx.c
+++ b/firmware/target/arm/s3c2440/gigabeat-fx/backlight-meg-fx.c
@@ -74,7 +74,7 @@ static unsigned char buttonlight_target;
74static unsigned short buttonlight_trigger_now; 74static unsigned short buttonlight_trigger_now;
75 75
76/* Assumes that the backlight has been initialized */ 76/* Assumes that the backlight has been initialized */
77void _backlight_set_brightness(int brightness) 77void backlight_hw_brightness(int brightness)
78{ 78{
79 /* stop the interrupt from messing us up */ 79 /* stop the interrupt from messing us up */
80 backlight_control = BACKLIGHT_CONTROL_IDLE; 80 backlight_control = BACKLIGHT_CONTROL_IDLE;
@@ -335,7 +335,7 @@ static void __backlight_dim(bool dim_now)
335 backlight_control = BACKLIGHT_CONTROL_FADE; 335 backlight_control = BACKLIGHT_CONTROL_FADE;
336} 336}
337 337
338void _backlight_on(void) 338void backlight_hw_on(void)
339{ 339{
340#ifdef HAVE_LCD_ENABLE 340#ifdef HAVE_LCD_ENABLE
341 lcd_enable(true); /* power on lcd + visible display */ 341 lcd_enable(true); /* power on lcd + visible display */
@@ -343,7 +343,7 @@ void _backlight_on(void)
343 __backlight_dim(false); 343 __backlight_dim(false);
344} 344}
345 345
346void _backlight_off(void) 346void backlight_hw_off(void)
347{ 347{
348 __backlight_dim(true); 348 __backlight_dim(true);
349} 349}
@@ -373,12 +373,12 @@ static void __buttonlight_dim(bool dim_now)
373 buttonlight_control = BUTTONLIGHT_CONTROL_FADE; 373 buttonlight_control = BUTTONLIGHT_CONTROL_FADE;
374} 374}
375 375
376void _buttonlight_on(void) 376void buttonlight_hw_on(void)
377{ 377{
378 __buttonlight_dim(false); 378 __buttonlight_dim(false);
379} 379}
380 380
381void _buttonlight_off(void) 381void buttonlight_hw_off(void)
382{ 382{
383#ifndef BOOTLOADER 383#ifndef BOOTLOADER
384 if(buttonlight_get_current_timeout() > 0) 384 if(buttonlight_get_current_timeout() > 0)
@@ -388,7 +388,7 @@ void _buttonlight_off(void)
388 __buttonlight_off(); 388 __buttonlight_off();
389} 389}
390 390
391void _buttonlight_set_brightness(int brightness) 391void buttonlight_hw_brightness(int brightness)
392{ 392{
393 /* stop the interrupt from messing us up */ 393 /* stop the interrupt from messing us up */
394 buttonlight_control = BUTTONLIGHT_CONTROL_IDLE; 394 buttonlight_control = BUTTONLIGHT_CONTROL_IDLE;
@@ -396,7 +396,7 @@ void _buttonlight_set_brightness(int brightness)
396 buttonlight_control = BUTTONLIGHT_CONTROL_SET; 396 buttonlight_control = BUTTONLIGHT_CONTROL_SET;
397} 397}
398 398
399bool _backlight_init(void) 399bool backlight_hw_init(void)
400{ 400{
401 unsigned char brightness = log_brightness[DEFAULT_BRIGHTNESS_SETTING]; 401 unsigned char brightness = log_brightness[DEFAULT_BRIGHTNESS_SETTING];
402 buttonlight_brightness = brightness; 402 buttonlight_brightness = brightness;
diff --git a/firmware/target/arm/s3c2440/gigabeat-fx/backlight-target.h b/firmware/target/arm/s3c2440/gigabeat-fx/backlight-target.h
index 8db2b11041..ef30babc2f 100644
--- a/firmware/target/arm/s3c2440/gigabeat-fx/backlight-target.h
+++ b/firmware/target/arm/s3c2440/gigabeat-fx/backlight-target.h
@@ -43,12 +43,12 @@ void __buttonlight_trigger(void);
43/* See enum buttonlight_mode for available functions */ 43/* See enum buttonlight_mode for available functions */
44void __buttonlight_mode(enum buttonlight_mode mode); 44void __buttonlight_mode(enum buttonlight_mode mode);
45 45
46bool _backlight_init(void); 46bool backlight_hw_init(void);
47void _backlight_on(void); 47void backlight_hw_on(void);
48void _backlight_off(void); 48void backlight_hw_off(void);
49void _backlight_set_brightness(int brightness); 49void backlight_hw_brightness(int brightness);
50 50
51void _buttonlight_set_brightness(int brightness); 51void buttonlight_hw_brightness(int brightness);
52void _buttonlight_on(void); 52void buttonlight_hw_on(void);
53void _buttonlight_off(void); 53void buttonlight_hw_off(void);
54#endif 54#endif
diff --git a/firmware/target/arm/s3c2440/gigabeat-fx/power-meg-fx.c b/firmware/target/arm/s3c2440/gigabeat-fx/power-meg-fx.c
index ad9098dd8a..e31a633aca 100644
--- a/firmware/target/arm/s3c2440/gigabeat-fx/power-meg-fx.c
+++ b/firmware/target/arm/s3c2440/gigabeat-fx/power-meg-fx.c
@@ -81,8 +81,8 @@ void power_off(void)
81 int(*reboot_point)(void); 81 int(*reboot_point)(void);
82 reboot_point=(void*)(unsigned char*) 0x00000000; 82 reboot_point=(void*)(unsigned char*) 0x00000000;
83 /* turn off backlight and wait for 1 second */ 83 /* turn off backlight and wait for 1 second */
84 _backlight_off(); 84 backlight_hw_off();
85 _buttonlight_off(); 85 buttonlight_hw_off();
86 sleep(HZ); 86 sleep(HZ);
87 87
88 /* Do this to allow the drive to properly reset when player restarts 88 /* Do this to allow the drive to properly reset when player restarts
diff --git a/firmware/target/arm/s3c2440/mini2440/backlight-mini2440.c b/firmware/target/arm/s3c2440/mini2440/backlight-mini2440.c
index b39bfc4949..c4b93da9bc 100644
--- a/firmware/target/arm/s3c2440/mini2440/backlight-mini2440.c
+++ b/firmware/target/arm/s3c2440/mini2440/backlight-mini2440.c
@@ -46,7 +46,7 @@ static unsigned char backlight_target;
46 46
47 47
48/* Assumes that the backlight has been initialized */ 48/* Assumes that the backlight has been initialized */
49void _backlight_set_brightness(int brightness) 49void backlight_hw_brightness(int brightness)
50{ 50{
51 if (brightness < 0) 51 if (brightness < 0)
52 brightness = 0; 52 brightness = 0;
@@ -86,22 +86,22 @@ static void led_control_service(void)
86 backlight_control = BACKLIGHT_CONTROL_IDLE; 86 backlight_control = BACKLIGHT_CONTROL_IDLE;
87 break; 87 break;
88 case BACKLIGHT_CONTROL_OFF: 88 case BACKLIGHT_CONTROL_OFF:
89 _backlight_set_brightness(0); 89 backlight_hw_brightness(0);
90 backlight_control = BACKLIGHT_CONTROL_IDLE; 90 backlight_control = BACKLIGHT_CONTROL_IDLE;
91 break; 91 break;
92 case BACKLIGHT_CONTROL_ON: 92 case BACKLIGHT_CONTROL_ON:
93 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 93 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
94 backlight_control = BACKLIGHT_CONTROL_IDLE; 94 backlight_control = BACKLIGHT_CONTROL_IDLE;
95 break; 95 break;
96 case BACKLIGHT_CONTROL_SET: 96 case BACKLIGHT_CONTROL_SET:
97 /* TODO: This is probably wrong since it sets a fixed value. 97 /* TODO: This is probably wrong since it sets a fixed value.
98 It was a fixed value of 255 before, but that was even more wrong 98 It was a fixed value of 255 before, but that was even more wrong
99 since it accessed the log_brightness buffer out of bounds */ 99 since it accessed the log_brightness buffer out of bounds */
100 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 100 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
101 backlight_control = BACKLIGHT_CONTROL_IDLE; 101 backlight_control = BACKLIGHT_CONTROL_IDLE;
102 break; 102 break;
103 case BACKLIGHT_CONTROL_FADE: 103 case BACKLIGHT_CONTROL_FADE:
104 _backlight_set_brightness(0); 104 backlight_hw_brightness(0);
105 backlight_control = BACKLIGHT_CONTROL_IDLE; 105 backlight_control = BACKLIGHT_CONTROL_IDLE;
106 break; 106 break;
107 default: 107 default:
@@ -127,7 +127,7 @@ static void __backlight_dim(bool dim_now)
127 backlight_control = BACKLIGHT_CONTROL_FADE; 127 backlight_control = BACKLIGHT_CONTROL_FADE;
128} 128}
129 129
130void _backlight_on(void) 130void backlight_hw_on(void)
131{ 131{
132#ifdef HAVE_LCD_ENABLE 132#ifdef HAVE_LCD_ENABLE
133 lcd_enable(true); /* power on lcd + visible display */ 133 lcd_enable(true); /* power on lcd + visible display */
@@ -135,13 +135,13 @@ void _backlight_on(void)
135 __backlight_dim(false); 135 __backlight_dim(false);
136} 136}
137 137
138void _backlight_off(void) 138void backlight_hw_off(void)
139{ 139{
140 __backlight_dim(true); 140 __backlight_dim(true);
141} 141}
142 142
143 143
144bool _backlight_init(void) 144bool backlight_hw_init(void)
145{ 145{
146 unsigned char brightness = log_brightness[DEFAULT_BRIGHTNESS_SETTING]; 146 unsigned char brightness = log_brightness[DEFAULT_BRIGHTNESS_SETTING];
147 _backlight_brightness = brightness; 147 _backlight_brightness = brightness;
diff --git a/firmware/target/arm/s3c2440/mini2440/backlight-target.h b/firmware/target/arm/s3c2440/mini2440/backlight-target.h
index c804f16bcc..ceb6824841 100644
--- a/firmware/target/arm/s3c2440/mini2440/backlight-target.h
+++ b/firmware/target/arm/s3c2440/mini2440/backlight-target.h
@@ -23,9 +23,9 @@
23 23
24#define GPIO_LCD_PWR (1 << 4) /* GPIO.G4 */ 24#define GPIO_LCD_PWR (1 << 4) /* GPIO.G4 */
25 25
26bool _backlight_init(void); 26bool backlight_hw_init(void);
27void _backlight_on(void); 27void backlight_hw_on(void);
28void _backlight_off(void); 28void backlight_hw_off(void);
29void _backlight_set_brightness(int brightness); 29void backlight_hw_brightness(int brightness);
30 30
31#endif 31#endif
diff --git a/firmware/target/arm/s5l8700/backlight-meizu.c b/firmware/target/arm/s5l8700/backlight-meizu.c
index 4eb6967b94..d5c9a22f82 100644
--- a/firmware/target/arm/s5l8700/backlight-meizu.c
+++ b/firmware/target/arm/s5l8700/backlight-meizu.c
@@ -32,7 +32,7 @@
32 level. This makes the brightness curve more linear to the human eye. 32 level. This makes the brightness curve more linear to the human eye.
33 */ 33 */
34 34
35void _backlight_set_brightness(int brightness) 35void backlight_hw_brightness(int brightness)
36{ 36{
37 /* pwm = round(sqrt(2)**x), where brightness level x = 1..16 */ 37 /* pwm = round(sqrt(2)**x), where brightness level x = 1..16 */
38 static const unsigned int logtable[] = 38 static const unsigned int logtable[] =
@@ -42,21 +42,21 @@ void _backlight_set_brightness(int brightness)
42 TCDATA0 = logtable[brightness]; 42 TCDATA0 = logtable[brightness];
43} 43}
44 44
45void _backlight_on(void) 45void backlight_hw_on(void)
46{ 46{
47 /* configure backlight pin P0.2 as timer PWM output */ 47 /* configure backlight pin P0.2 as timer PWM output */
48 PCON0 = ((PCON0 & ~(3 << 4)) | (2 << 4)); 48 PCON0 = ((PCON0 & ~(3 << 4)) | (2 << 4));
49 _backlight_set_brightness(backlight_brightness); 49 backlight_hw_brightness(backlight_brightness);
50} 50}
51 51
52void _backlight_off(void) 52void backlight_hw_off(void)
53{ 53{
54 /* configure backlight pin P0.2 as GPIO and switch off */ 54 /* configure backlight pin P0.2 as GPIO and switch off */
55 PCON0 = ((PCON0 & ~(3 << 4)) | (1 << 4)); 55 PCON0 = ((PCON0 & ~(3 << 4)) | (1 << 4));
56 PDAT0 &= ~(1 << 2); 56 PDAT0 &= ~(1 << 2);
57} 57}
58 58
59bool _backlight_init(void) 59bool backlight_hw_init(void)
60{ 60{
61 /* enable timer clock */ 61 /* enable timer clock */
62 PWRCON &= ~(1 << 4); 62 PWRCON &= ~(1 << 4);
@@ -72,7 +72,7 @@ bool _backlight_init(void)
72 TCPRE = 20; /* prescaler */ 72 TCPRE = 20; /* prescaler */
73 TCCMD = (1 << 0); /* TC_EN */ 73 TCCMD = (1 << 0); /* TC_EN */
74 74
75 _backlight_on(); 75 backlight_hw_on();
76 76
77 return true; 77 return true;
78} 78}
diff --git a/firmware/target/arm/s5l8700/backlight-target.h b/firmware/target/arm/s5l8700/backlight-target.h
index 91579b080d..a436186791 100644
--- a/firmware/target/arm/s5l8700/backlight-target.h
+++ b/firmware/target/arm/s5l8700/backlight-target.h
@@ -21,9 +21,9 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#endif 29#endif
diff --git a/firmware/target/arm/s5l8700/ipodnano2g/backlight-nano2g.c b/firmware/target/arm/s5l8700/ipodnano2g/backlight-nano2g.c
index 3e0e7460c4..b38e0f17f5 100644
--- a/firmware/target/arm/s5l8700/ipodnano2g/backlight-nano2g.c
+++ b/firmware/target/arm/s5l8700/ipodnano2g/backlight-nano2g.c
@@ -32,12 +32,12 @@ void lcd_awake(void);
32void lcd_update(void); 32void lcd_update(void);
33#endif 33#endif
34 34
35void _backlight_set_brightness(int brightness) 35void backlight_hw_brightness(int brightness)
36{ 36{
37 pmu_write(0x28, brightness); 37 pmu_write(0x28, brightness);
38} 38}
39 39
40void _backlight_on(void) 40void backlight_hw_on(void)
41{ 41{
42#ifdef HAVE_LCD_SLEEP 42#ifdef HAVE_LCD_SLEEP
43 if (!lcd_active()) 43 if (!lcd_active())
@@ -50,18 +50,18 @@ void _backlight_on(void)
50 pmu_write(0x29, 1); 50 pmu_write(0x29, 1);
51} 51}
52 52
53void _backlight_off(void) 53void backlight_hw_off(void)
54{ 54{
55 pmu_write(0x29, 0); 55 pmu_write(0x29, 0);
56} 56}
57 57
58bool _backlight_init(void) 58bool backlight_hw_init(void)
59{ 59{
60 pmu_write(0x2a, 6); 60 pmu_write(0x2a, 6);
61 pmu_write(0x28, 0x2e); 61 pmu_write(0x28, 0x2e);
62 pmu_write(0x2b, 20); 62 pmu_write(0x2b, 20);
63 63
64 _backlight_on(); 64 backlight_hw_on();
65 65
66 return true; 66 return true;
67} 67}
diff --git a/firmware/target/arm/s5l8700/yps3/backlight-target.h b/firmware/target/arm/s5l8700/yps3/backlight-target.h
index 0507be4f76..74ea0aa035 100644
--- a/firmware/target/arm/s5l8700/yps3/backlight-target.h
+++ b/firmware/target/arm/s5l8700/yps3/backlight-target.h
@@ -21,13 +21,13 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29void _buttonlight_on(void); 29void buttonlight_hw_on(void);
30void _buttonlight_off(void); 30void buttonlight_hw_off(void);
31 31
32#endif /* BACKLIGHT_TARGET_H */ 32#endif /* BACKLIGHT_TARGET_H */
33 33
diff --git a/firmware/target/arm/s5l8700/yps3/backlight-yps3.c b/firmware/target/arm/s5l8700/yps3/backlight-yps3.c
index 7cf3a44805..ae3cc3b0a1 100644
--- a/firmware/target/arm/s5l8700/yps3/backlight-yps3.c
+++ b/firmware/target/arm/s5l8700/yps3/backlight-yps3.c
@@ -35,7 +35,7 @@
35 are three individually controllable groups: menu/back, cursor, middle). 35 are three individually controllable groups: menu/back, cursor, middle).
36 */ 36 */
37 37
38void _backlight_set_brightness(int brightness) 38void backlight_hw_brightness(int brightness)
39{ 39{
40 /* pwm = round(16 * 16**(x/16)), where brightness level x = 1..16 */ 40 /* pwm = round(16 * 16**(x/16)), where brightness level x = 1..16 */
41 static const unsigned int logtable[] = 41 static const unsigned int logtable[] =
@@ -45,39 +45,39 @@ void _backlight_set_brightness(int brightness)
45 TADATA0 = logtable[brightness]; 45 TADATA0 = logtable[brightness];
46} 46}
47 47
48void _backlight_on(void) 48void backlight_hw_on(void)
49{ 49{
50 /* configure backlight pin P0.0 as timer PWM output */ 50 /* configure backlight pin P0.0 as timer PWM output */
51 PCON0 = ((PCON0 & ~(3 << 0)) | (2 << 0)); 51 PCON0 = ((PCON0 & ~(3 << 0)) | (2 << 0));
52 52
53 _backlight_set_brightness(backlight_brightness); 53 backlight_hw_brightness(backlight_brightness);
54} 54}
55 55
56void _backlight_off(void) 56void backlight_hw_off(void)
57{ 57{
58 /* configure backlight pin P0.0 as GPIO and switch off */ 58 /* configure backlight pin P0.0 as GPIO and switch off */
59 PCON0 = ((PCON0 & ~(3 << 0)) | (1 << 0)); 59 PCON0 = ((PCON0 & ~(3 << 0)) | (1 << 0));
60 PDAT0 &= ~(1 << 0); 60 PDAT0 &= ~(1 << 0);
61} 61}
62 62
63void _buttonlight_on(void) 63void buttonlight_hw_on(void)
64{ 64{
65 PDAT3 |= (3 << 2); 65 PDAT3 |= (3 << 2);
66 PDAT4 |= (1 << 2); 66 PDAT4 |= (1 << 2);
67} 67}
68 68
69void _buttonlight_off(void) 69void buttonlight_hw_off(void)
70{ 70{
71 PDAT3 &= ~(3 << 2); 71 PDAT3 &= ~(3 << 2);
72 PDAT4 &= ~(1 << 2); 72 PDAT4 &= ~(1 << 2);
73} 73}
74 74
75bool _backlight_init(void) 75bool backlight_hw_init(void)
76{ 76{
77 /* Enable button LEDs: P3.2 (menu/back), P3.3 (cursor), P4.2 (middle) */ 77 /* Enable button LEDs: P3.2 (menu/back), P3.3 (cursor), P4.2 (middle) */
78 PCON3 = (PCON3 & ~0x0000FF00) | 0x00001100; 78 PCON3 = (PCON3 & ~0x0000FF00) | 0x00001100;
79 PCON4 = (PCON4 & ~0x00000F00) | 0x00000100; 79 PCON4 = (PCON4 & ~0x00000F00) | 0x00000100;
80 _buttonlight_off(); 80 buttonlight_hw_off();
81 81
82 /* enable timer clock */ 82 /* enable timer clock */
83 PWRCON &= ~(1 << 4); 83 PWRCON &= ~(1 << 4);
@@ -93,7 +93,7 @@ bool _backlight_init(void)
93 TAPRE = 20; /* prescaler */ 93 TAPRE = 20; /* prescaler */
94 TACMD = (1 << 0); /* TA_EN */ 94 TACMD = (1 << 0); /* TA_EN */
95 95
96 _backlight_on(); 96 backlight_hw_on();
97 97
98 return true; 98 return true;
99} 99}
diff --git a/firmware/target/arm/s5l8702/ipod6g/backlight-ipod6g.c b/firmware/target/arm/s5l8702/ipod6g/backlight-ipod6g.c
index 481a2643bb..7d1c8bde13 100644
--- a/firmware/target/arm/s5l8702/ipod6g/backlight-ipod6g.c
+++ b/firmware/target/arm/s5l8702/ipod6g/backlight-ipod6g.c
@@ -32,12 +32,12 @@ void lcd_awake(void);
32void lcd_update(void); 32void lcd_update(void);
33#endif 33#endif
34 34
35void _backlight_set_brightness(int brightness) 35void backlight_hw_brightness(int brightness)
36{ 36{
37 pmu_write(0x28, brightness); 37 pmu_write(0x28, brightness);
38} 38}
39 39
40void _backlight_on(void) 40void backlight_hw_on(void)
41{ 41{
42#ifdef HAVE_LCD_SLEEP 42#ifdef HAVE_LCD_SLEEP
43 if (!lcd_active()) 43 if (!lcd_active())
@@ -50,20 +50,20 @@ void _backlight_on(void)
50 pmu_write(0x29, 1); 50 pmu_write(0x29, 1);
51} 51}
52 52
53void _backlight_off(void) 53void backlight_hw_off(void)
54{ 54{
55 pmu_write(0x29, 0); 55 pmu_write(0x29, 0);
56} 56}
57 57
58bool _backlight_init(void) 58bool backlight_hw_init(void)
59{ 59{
60 /* LEDCTL: overvoltage protection enabled, OCP limit is 500mA */ 60 /* LEDCTL: overvoltage protection enabled, OCP limit is 500mA */
61 pmu_write(0x2a, 0x05); 61 pmu_write(0x2a, 0x05);
62 62
63 pmu_write(0x2b, 0x14); /* T_dimstep = 16 * value / 32768 */ 63 pmu_write(0x2b, 0x14); /* T_dimstep = 16 * value / 32768 */
64 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 64 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
65 65
66 _backlight_on(); 66 backlight_hw_on();
67 67
68 return true; 68 return true;
69} 69}
diff --git a/firmware/target/arm/s5l8702/ipod6g/backlight-target.h b/firmware/target/arm/s5l8702/ipod6g/backlight-target.h
index 05a8addfea..21ff6c30e1 100644
--- a/firmware/target/arm/s5l8702/ipod6g/backlight-target.h
+++ b/firmware/target/arm/s5l8702/ipod6g/backlight-target.h
@@ -21,9 +21,9 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24bool _backlight_init(void); 24bool backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#endif 29#endif
diff --git a/firmware/target/arm/samsung/backlight-target.h b/firmware/target/arm/samsung/backlight-target.h
index a27b489319..3882964207 100644
--- a/firmware/target/arm/samsung/backlight-target.h
+++ b/firmware/target/arm/samsung/backlight-target.h
@@ -21,8 +21,8 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27 27
28#endif 28#endif
diff --git a/firmware/target/arm/samsung/yh820/backlight-yh820.c b/firmware/target/arm/samsung/yh820/backlight-yh820.c
index 0bbdb4f7d4..b24f8128c4 100644
--- a/firmware/target/arm/samsung/yh820/backlight-yh820.c
+++ b/firmware/target/arm/samsung/yh820/backlight-yh820.c
@@ -25,7 +25,7 @@
25#include "backlight-target.h" 25#include "backlight-target.h"
26#include "lcd.h" 26#include "lcd.h"
27 27
28void _backlight_on(void) 28void backlight_hw_on(void)
29{ 29{
30#ifdef HAVE_LCD_SLEEP 30#ifdef HAVE_LCD_SLEEP
31 backlight_lcd_sleep_countdown(false); /* stop counter */ 31 backlight_lcd_sleep_countdown(false); /* stop counter */
@@ -36,7 +36,7 @@ void _backlight_on(void)
36 GPIO_SET_BITWISE(GPIOB_OUTPUT_VAL, 0x2); 36 GPIO_SET_BITWISE(GPIOB_OUTPUT_VAL, 0x2);
37} 37}
38 38
39void _backlight_off(void) 39void backlight_hw_off(void)
40{ 40{
41 GPIO_CLEAR_BITWISE(GPIOB_OUTPUT_VAL, 0x2); 41 GPIO_CLEAR_BITWISE(GPIOB_OUTPUT_VAL, 0x2);
42#ifdef HAVE_LCD_ENABLE 42#ifdef HAVE_LCD_ENABLE
diff --git a/firmware/target/arm/samsung/yh920/backlight-yh920.c b/firmware/target/arm/samsung/yh920/backlight-yh920.c
index 0bbdb4f7d4..b24f8128c4 100644
--- a/firmware/target/arm/samsung/yh920/backlight-yh920.c
+++ b/firmware/target/arm/samsung/yh920/backlight-yh920.c
@@ -25,7 +25,7 @@
25#include "backlight-target.h" 25#include "backlight-target.h"
26#include "lcd.h" 26#include "lcd.h"
27 27
28void _backlight_on(void) 28void backlight_hw_on(void)
29{ 29{
30#ifdef HAVE_LCD_SLEEP 30#ifdef HAVE_LCD_SLEEP
31 backlight_lcd_sleep_countdown(false); /* stop counter */ 31 backlight_lcd_sleep_countdown(false); /* stop counter */
@@ -36,7 +36,7 @@ void _backlight_on(void)
36 GPIO_SET_BITWISE(GPIOB_OUTPUT_VAL, 0x2); 36 GPIO_SET_BITWISE(GPIOB_OUTPUT_VAL, 0x2);
37} 37}
38 38
39void _backlight_off(void) 39void backlight_hw_off(void)
40{ 40{
41 GPIO_CLEAR_BITWISE(GPIOB_OUTPUT_VAL, 0x2); 41 GPIO_CLEAR_BITWISE(GPIOB_OUTPUT_VAL, 0x2);
42#ifdef HAVE_LCD_ENABLE 42#ifdef HAVE_LCD_ENABLE
diff --git a/firmware/target/arm/samsung/yh925/backlight-yh925.c b/firmware/target/arm/samsung/yh925/backlight-yh925.c
index 5f29f9f770..8eb287b61b 100644
--- a/firmware/target/arm/samsung/yh925/backlight-yh925.c
+++ b/firmware/target/arm/samsung/yh925/backlight-yh925.c
@@ -25,7 +25,7 @@
25#include "backlight-target.h" 25#include "backlight-target.h"
26#include "lcd.h" 26#include "lcd.h"
27 27
28void _backlight_on(void) 28void backlight_hw_on(void)
29{ 29{
30#ifdef HAVE_LCD_SLEEP 30#ifdef HAVE_LCD_SLEEP
31 backlight_lcd_sleep_countdown(false); /* stop counter */ 31 backlight_lcd_sleep_countdown(false); /* stop counter */
@@ -36,7 +36,7 @@ void _backlight_on(void)
36 GPIO_SET_BITWISE(GPIOF_OUTPUT_VAL, 0x1); 36 GPIO_SET_BITWISE(GPIOF_OUTPUT_VAL, 0x1);
37} 37}
38 38
39void _backlight_off(void) 39void backlight_hw_off(void)
40{ 40{
41 GPIO_CLEAR_BITWISE(GPIOF_OUTPUT_VAL, 0x1); 41 GPIO_CLEAR_BITWISE(GPIOF_OUTPUT_VAL, 0x1);
42#ifdef HAVE_LCD_ENABLE 42#ifdef HAVE_LCD_ENABLE
diff --git a/firmware/target/arm/sandisk/backlight-c200_e200.c b/firmware/target/arm/sandisk/backlight-c200_e200.c
index 0280604526..ad1a6d9e46 100644
--- a/firmware/target/arm/sandisk/backlight-c200_e200.c
+++ b/firmware/target/arm/sandisk/backlight-c200_e200.c
@@ -26,12 +26,12 @@
26#include "ascodec.h" 26#include "ascodec.h"
27#include "as3514.h" 27#include "as3514.h"
28 28
29void _backlight_set_brightness(int brightness) 29void backlight_hw_brightness(int brightness)
30{ 30{
31 ascodec_write(AS3514_DCDC15, brightness); 31 ascodec_write(AS3514_DCDC15, brightness);
32} 32}
33 33
34void _backlight_on(void) 34void backlight_hw_on(void)
35{ 35{
36#ifdef HAVE_LCD_ENABLE 36#ifdef HAVE_LCD_ENABLE
37 lcd_enable(true); /* power on lcd + visible display */ 37 lcd_enable(true); /* power on lcd + visible display */
@@ -39,19 +39,19 @@ void _backlight_on(void)
39#if (CONFIG_BACKLIGHT_FADING != BACKLIGHT_FADING_SW_SETTING) /* in bootloader/sim */ 39#if (CONFIG_BACKLIGHT_FADING != BACKLIGHT_FADING_SW_SETTING) /* in bootloader/sim */
40 /* if we set the brightness to the settings value, then fading up 40 /* if we set the brightness to the settings value, then fading up
41 * is glitchy */ 41 * is glitchy */
42 _backlight_set_brightness(backlight_brightness); 42 backlight_hw_brightness(backlight_brightness);
43#endif 43#endif
44} 44}
45 45
46void _backlight_off(void) 46void backlight_hw_off(void)
47{ 47{
48 _backlight_set_brightness(0); 48 backlight_hw_brightness(0);
49#ifdef HAVE_LCD_ENABLE 49#ifdef HAVE_LCD_ENABLE
50 lcd_enable(false); /* power off visible display */ 50 lcd_enable(false); /* power off visible display */
51#endif 51#endif
52} 52}
53 53
54void _buttonlight_on(void) 54void buttonlight_hw_on(void)
55{ 55{
56 GPIO_SET_BITWISE(GPIOG_OUTPUT_VAL, 0x80); 56 GPIO_SET_BITWISE(GPIOG_OUTPUT_VAL, 0x80);
57#ifdef SANSA_C200 57#ifdef SANSA_C200
@@ -59,7 +59,7 @@ void _buttonlight_on(void)
59#endif 59#endif
60} 60}
61 61
62void _buttonlight_off(void) 62void buttonlight_hw_off(void)
63{ 63{
64 GPIO_CLEAR_BITWISE(GPIOG_OUTPUT_VAL, 0x80); 64 GPIO_CLEAR_BITWISE(GPIOG_OUTPUT_VAL, 0x80);
65#ifdef SANSA_C200 65#ifdef SANSA_C200
diff --git a/firmware/target/arm/sandisk/backlight-target.h b/firmware/target/arm/sandisk/backlight-target.h
index 1f5e475a42..cbe26f54da 100644
--- a/firmware/target/arm/sandisk/backlight-target.h
+++ b/firmware/target/arm/sandisk/backlight-target.h
@@ -21,11 +21,11 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24#define _backlight_init() true 24#define backlight_hw_init() true
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29void _buttonlight_on(void); 29void buttonlight_hw_on(void);
30void _buttonlight_off(void); 30void buttonlight_hw_off(void);
31#endif 31#endif
diff --git a/firmware/target/arm/sandisk/sansa-e200/button-e200.c b/firmware/target/arm/sandisk/sansa-e200/button-e200.c
index 73279b44cf..0df71f4815 100644
--- a/firmware/target/arm/sandisk/sansa-e200/button-e200.c
+++ b/firmware/target/arm/sandisk/sansa-e200/button-e200.c
@@ -135,7 +135,7 @@ void clickwheel_int(void)
135 static int prev_keypost = BUTTON_NONE; 135 static int prev_keypost = BUTTON_NONE;
136 static int count = 0; 136 static int count = 0;
137 static int fast_mode = 0; 137 static int fast_mode = 0;
138 static long next_backlight_on = 0; 138 static long nextbacklight_hw_on = 0;
139 139
140 static unsigned long prev_usec[WHEEL_BASE_SENSITIVITY] = { 0 }; 140 static unsigned long prev_usec[WHEEL_BASE_SENSITIVITY] = { 0 };
141 static unsigned long delta = 1ul << 24; 141 static unsigned long delta = 1ul << 24;
@@ -166,11 +166,11 @@ void clickwheel_int(void)
166 velocity = 0; 166 velocity = 0;
167 } 167 }
168 168
169 if (TIME_AFTER(current_tick, next_backlight_on)) 169 if (TIME_AFTER(current_tick, nextbacklight_hw_on))
170 { 170 {
171 /* Poke backlight to turn it on or maintain it no more often 171 /* Poke backlight to turn it on or maintain it no more often
172 * than every 1/4 second */ 172 * than every 1/4 second */
173 next_backlight_on = current_tick + HZ/4; 173 nextbacklight_hw_on = current_tick + HZ/4;
174 backlight_on(); 174 backlight_on();
175#ifdef HAVE_BUTTON_LIGHT 175#ifdef HAVE_BUTTON_LIGHT
176 buttonlight_on(); 176 buttonlight_on();
@@ -209,7 +209,7 @@ void clickwheel_int(void)
209 velocity = v; 209 velocity = v;
210 /* Ensure backlight never gets stuck for an extended period if tick 210 /* Ensure backlight never gets stuck for an extended period if tick
211 * wrapped such that next poke is very far ahead */ 211 * wrapped such that next poke is very far ahead */
212 next_backlight_on = current_tick - 1; 212 nextbacklight_hw_on = current_tick - 1;
213 } 213 }
214 else 214 else
215 { 215 {
diff --git a/firmware/target/arm/sandisk/sansa-view/backlight-target.h b/firmware/target/arm/sandisk/sansa-view/backlight-target.h
index 545ee93677..c51875754d 100644
--- a/firmware/target/arm/sandisk/sansa-view/backlight-target.h
+++ b/firmware/target/arm/sandisk/sansa-view/backlight-target.h
@@ -24,10 +24,10 @@
24 24
25#include <stdbool.h> 25#include <stdbool.h>
26 26
27void _backlight_on(void); 27void backlight_hw_on(void);
28void _backlight_off(void); 28void backlight_hw_off(void);
29 29
30void _buttonlight_on(void); 30void buttonlight_hw_on(void);
31void _buttonlight_off(void); 31void buttonlight_hw_off(void);
32 32
33#endif 33#endif
diff --git a/firmware/target/arm/sandisk/sansa-view/backlight-view.c b/firmware/target/arm/sandisk/sansa-view/backlight-view.c
index c065ec3f2a..637e5b4269 100644
--- a/firmware/target/arm/sandisk/sansa-view/backlight-view.c
+++ b/firmware/target/arm/sandisk/sansa-view/backlight-view.c
@@ -25,7 +25,7 @@
25#include "lcd.h" 25#include "lcd.h"
26#include "backlight.h" 26#include "backlight.h"
27 27
28bool _backlight_init(void) 28bool backlight_hw_init(void)
29{ 29{
30 GPIO_SET_BITWISE(GPIOD_ENABLE, 0x01); 30 GPIO_SET_BITWISE(GPIOD_ENABLE, 0x01);
31 GPIO_SET_BITWISE(GPIOD_OUTPUT_EN, 0x01); 31 GPIO_SET_BITWISE(GPIOD_OUTPUT_EN, 0x01);
@@ -44,22 +44,22 @@ bool _backlight_init(void)
44 return true; 44 return true;
45} 45}
46 46
47void _backlight_set_brightness(int brightness) 47void backlight_hw_brightness(int brightness)
48{ 48{
49 (void)brightness; 49 (void)brightness;
50} 50}
51 51
52void _backlight_off(void) 52void backlight_hw_off(void)
53{ 53{
54 GPIO_CLEAR_BITWISE(GPIOD_OUTPUT_VAL, 0x01); 54 GPIO_CLEAR_BITWISE(GPIOD_OUTPUT_VAL, 0x01);
55} 55}
56 56
57void _backlight_on(void) 57void backlight_hw_on(void)
58{ 58{
59 GPIO_SET_BITWISE(GPIOD_OUTPUT_VAL, 0x01); 59 GPIO_SET_BITWISE(GPIOD_OUTPUT_VAL, 0x01);
60} 60}
61 61
62void _buttonlight_off(void) 62void buttonlight_hw_off(void)
63{ 63{
64 GPIO_CLEAR_BITWISE(GPIOA_OUTPUT_VAL, 0x02); /* vertical buttonlight */ 64 GPIO_CLEAR_BITWISE(GPIOA_OUTPUT_VAL, 0x02); /* vertical buttonlight */
65 GPIO_CLEAR_BITWISE(GPIOA_OUTPUT_VAL, 0x01); /* horizontal buttonlight */ 65 GPIO_CLEAR_BITWISE(GPIOA_OUTPUT_VAL, 0x01); /* horizontal buttonlight */
@@ -70,7 +70,7 @@ void _buttonlight_off(void)
70 GPIO_CLEAR_BITWISE(GPIOR_OUTPUT_VAL, 0x10); /* scrollwheel left led */ 70 GPIO_CLEAR_BITWISE(GPIOR_OUTPUT_VAL, 0x10); /* scrollwheel left led */
71} 71}
72 72
73void _buttonlight_on(void) 73void buttonlight_hw_on(void)
74{ 74{
75 GPIO_SET_BITWISE(GPIOA_OUTPUT_VAL, 0x02); /* vertical buttonlight */ 75 GPIO_SET_BITWISE(GPIOA_OUTPUT_VAL, 0x02); /* vertical buttonlight */
76 GPIO_SET_BITWISE(GPIOA_OUTPUT_VAL, 0x01); /* horizontal buttonlight */ 76 GPIO_SET_BITWISE(GPIOA_OUTPUT_VAL, 0x01); /* horizontal buttonlight */
diff --git a/firmware/target/arm/tatung/tpj1022/backlight-target.h b/firmware/target/arm/tatung/tpj1022/backlight-target.h
index f82dc567ef..4a5e677599 100644
--- a/firmware/target/arm/tatung/tpj1022/backlight-target.h
+++ b/firmware/target/arm/tatung/tpj1022/backlight-target.h
@@ -24,8 +24,8 @@
24#ifndef BACKLIGHT_TARGET_H 24#ifndef BACKLIGHT_TARGET_H
25#define BACKLIGHT_TARGET_H 25#define BACKLIGHT_TARGET_H
26 26
27#define _backlight_init() true 27#define backlight_hw_init() true
28void _backlight_on(void); 28void backlight_hw_on(void);
29void _backlight_off(void); 29void backlight_hw_off(void);
30 30
31#endif 31#endif
diff --git a/firmware/target/arm/tatung/tpj1022/backlight-tpj1022.c b/firmware/target/arm/tatung/tpj1022/backlight-tpj1022.c
index 87ec19fa80..d63387728b 100644
--- a/firmware/target/arm/tatung/tpj1022/backlight-tpj1022.c
+++ b/firmware/target/arm/tatung/tpj1022/backlight-tpj1022.c
@@ -27,7 +27,7 @@
27#include "system.h" 27#include "system.h"
28#include "backlight.h" 28#include "backlight.h"
29 29
30void _backlight_on(void) 30void backlight_hw_on(void)
31{ 31{
32#if 0 32#if 0
33 int level = disable_irq_save(); 33 int level = disable_irq_save();
@@ -36,7 +36,7 @@ void _backlight_on(void)
36#endif 36#endif
37} 37}
38 38
39void _backlight_off(void) 39void backlight_hw_off(void)
40{ 40{
41#if 0 41#if 0
42 int level = disable_irq_save(); 42 int level = disable_irq_save();
diff --git a/firmware/target/arm/tcc77x/c100/backlight-target.h b/firmware/target/arm/tcc77x/c100/backlight-target.h
index 738a2f80ab..7ae71022f0 100644
--- a/firmware/target/arm/tcc77x/c100/backlight-target.h
+++ b/firmware/target/arm/tcc77x/c100/backlight-target.h
@@ -23,15 +23,15 @@
23 23
24#include "tcc77x.h" 24#include "tcc77x.h"
25 25
26#define _backlight_init() true 26#define backlight_hw_init() true
27 27
28static inline void _backlight_on(void) 28static inline void backlight_hw_on(void)
29{ 29{
30 /* Enable backlight */ 30 /* Enable backlight */
31 GPIOE |= 0x2; 31 GPIOE |= 0x2;
32} 32}
33 33
34static inline void _backlight_off(void) 34static inline void backlight_hw_off(void)
35{ 35{
36 /* Disable backlight */ 36 /* Disable backlight */
37 GPIOE &= ~0x2; 37 GPIOE &= ~0x2;
diff --git a/firmware/target/arm/tcc77x/iaudio7/backlight-target.h b/firmware/target/arm/tcc77x/iaudio7/backlight-target.h
index 9a6182ff02..0b227cd11c 100644
--- a/firmware/target/arm/tcc77x/iaudio7/backlight-target.h
+++ b/firmware/target/arm/tcc77x/iaudio7/backlight-target.h
@@ -26,7 +26,7 @@
26 26
27void power_touch_panel(bool on); 27void power_touch_panel(bool on);
28 28
29static inline bool _backlight_init(void) 29static inline bool backlight_hw_init(void)
30{ 30{
31 GPIOD_DIR |= 0x2; 31 GPIOD_DIR |= 0x2;
32 /* set backlight on by default, since the screen is unreadable without it */ 32 /* set backlight on by default, since the screen is unreadable without it */
@@ -34,13 +34,13 @@ static inline bool _backlight_init(void)
34 return true; 34 return true;
35} 35}
36 36
37static inline void _backlight_on(void) 37static inline void backlight_hw_on(void)
38{ 38{
39 GPIOD |= 0x2; 39 GPIOD |= 0x2;
40 power_touch_panel(true); 40 power_touch_panel(true);
41} 41}
42 42
43static inline void _backlight_off(void) 43static inline void backlight_hw_off(void)
44{ 44{
45 GPIOD &= ~0x2; 45 GPIOD &= ~0x2;
46 power_touch_panel(false); 46 power_touch_panel(false);
diff --git a/firmware/target/arm/tcc77x/logikdax/backlight-target.h b/firmware/target/arm/tcc77x/logikdax/backlight-target.h
index 7630a8332e..202e118606 100644
--- a/firmware/target/arm/tcc77x/logikdax/backlight-target.h
+++ b/firmware/target/arm/tcc77x/logikdax/backlight-target.h
@@ -23,15 +23,15 @@
23 23
24#include "tcc77x.h" 24#include "tcc77x.h"
25 25
26#define _backlight_init() true 26#define backlight_hw_init() true
27 27
28static inline void _backlight_on(void) 28static inline void backlight_hw_on(void)
29{ 29{
30 /* Enable backlight */ 30 /* Enable backlight */
31 GPIOD |= 0x10; 31 GPIOD |= 0x10;
32} 32}
33 33
34static inline void _backlight_off(void) 34static inline void backlight_hw_off(void)
35{ 35{
36 /* Disable backlight */ 36 /* Disable backlight */
37 GPIOD &= ~0x10; 37 GPIOD &= ~0x10;
diff --git a/firmware/target/arm/tcc77x/m200/backlight-target.h b/firmware/target/arm/tcc77x/m200/backlight-target.h
index bbc9037075..d73ac78852 100644
--- a/firmware/target/arm/tcc77x/m200/backlight-target.h
+++ b/firmware/target/arm/tcc77x/m200/backlight-target.h
@@ -23,19 +23,19 @@
23 23
24#include "tcc77x.h" 24#include "tcc77x.h"
25 25
26static inline bool _backlight_init(void) 26static inline bool backlight_hw_init(void)
27{ 27{
28 GPIOA_DIR |= 0x40; 28 GPIOA_DIR |= 0x40;
29 return true; 29 return true;
30} 30}
31 31
32static inline void _backlight_on(void) 32static inline void backlight_hw_on(void)
33{ 33{
34 /* Enable backlight */ 34 /* Enable backlight */
35 GPIOA |= 0x40; 35 GPIOA |= 0x40;
36} 36}
37 37
38static inline void _backlight_off(void) 38static inline void backlight_hw_off(void)
39{ 39{
40 /* Disable backlight */ 40 /* Disable backlight */
41 GPIOA &= ~0x40; 41 GPIOA &= ~0x40;
diff --git a/firmware/target/arm/tcc780x/cowond2/backlight-cowond2.c b/firmware/target/arm/tcc780x/cowond2/backlight-cowond2.c
index 5668023f28..37ee0e57a1 100644
--- a/firmware/target/arm/tcc780x/cowond2/backlight-cowond2.c
+++ b/firmware/target/arm/tcc780x/cowond2/backlight-cowond2.c
@@ -26,15 +26,15 @@
26#include "tcc780x.h" 26#include "tcc780x.h"
27#include "pmu-target.h" 27#include "pmu-target.h"
28 28
29int _backlight_init(void) 29int backlight_hw_init(void)
30{ 30{
31 _backlight_set_brightness(DEFAULT_BRIGHTNESS_SETTING); 31 backlight_hw_brightness(DEFAULT_BRIGHTNESS_SETTING);
32 /* set backlight on by default, since the screen is unreadable without it */ 32 /* set backlight on by default, since the screen is unreadable without it */
33 _backlight_on(); 33 backlight_hw_on();
34 return true; 34 return true;
35} 35}
36 36
37void _backlight_set_brightness(int brightness) 37void backlight_hw_brightness(int brightness)
38{ 38{
39 int level = disable_irq_save(); 39 int level = disable_irq_save();
40 40
@@ -56,7 +56,7 @@ void _backlight_set_brightness(int brightness)
56 restore_irq(level); 56 restore_irq(level);
57} 57}
58 58
59void _backlight_on(void) 59void backlight_hw_on(void)
60{ 60{
61 if (get_pmu_type() == PCF50606) 61 if (get_pmu_type() == PCF50606)
62 { 62 {
@@ -70,7 +70,7 @@ void _backlight_on(void)
70 } 70 }
71} 71}
72 72
73void _backlight_off(void) 73void backlight_hw_off(void)
74{ 74{
75 if (get_pmu_type() == PCF50606) 75 if (get_pmu_type() == PCF50606)
76 { 76 {
diff --git a/firmware/target/arm/tcc780x/cowond2/backlight-target.h b/firmware/target/arm/tcc780x/cowond2/backlight-target.h
index dbb0baae43..6577f74474 100644
--- a/firmware/target/arm/tcc780x/cowond2/backlight-target.h
+++ b/firmware/target/arm/tcc780x/cowond2/backlight-target.h
@@ -21,9 +21,9 @@
21#ifndef BACKLIGHT_TARGET_H 21#ifndef BACKLIGHT_TARGET_H
22#define BACKLIGHT_TARGET_H 22#define BACKLIGHT_TARGET_H
23 23
24int _backlight_init(void); 24int backlight_hw_init(void);
25void _backlight_on(void); 25void backlight_hw_on(void);
26void _backlight_off(void); 26void backlight_hw_off(void);
27void _backlight_set_brightness(int brightness); 27void backlight_hw_brightness(int brightness);
28 28
29#endif 29#endif
diff --git a/firmware/target/arm/tcc780x/cowond2/button-cowond2.c b/firmware/target/arm/tcc780x/cowond2/button-cowond2.c
index df2ea1f307..6c8541ef62 100644
--- a/firmware/target/arm/tcc780x/cowond2/button-cowond2.c
+++ b/firmware/target/arm/tcc780x/cowond2/button-cowond2.c
@@ -92,7 +92,7 @@ int button_read_device(int *data)
92 if (!(GPIOA & 0x4)) 92 if (!(GPIOA & 0x4))
93 btn |= BUTTON_POWER; 93 btn |= BUTTON_POWER;
94 94
95 if (btn & BUTTON_TOUCHSCREEN && !is_backlight_on(true)) 95 if (btn & BUTTON_TOUCHSCREEN && !isbacklight_hw_on(true))
96 old_data = *data = 0; 96 old_data = *data = 0;
97 97
98 return btn; 98 return btn;
diff --git a/firmware/target/arm/tcc780x/cowond2/power-cowond2.c b/firmware/target/arm/tcc780x/cowond2/power-cowond2.c
index 09787289ac..6576afb09c 100644
--- a/firmware/target/arm/tcc780x/cowond2/power-cowond2.c
+++ b/firmware/target/arm/tcc780x/cowond2/power-cowond2.c
@@ -78,7 +78,7 @@ void power_init(void)
78void power_off(void) 78void power_off(void)
79{ 79{
80 /* Turn the backlight off first to avoid a bright stripe on power-off */ 80 /* Turn the backlight off first to avoid a bright stripe on power-off */
81 _backlight_off(); 81 backlight_hw_off();
82 sleep(HZ/10); 82 sleep(HZ/10);
83 83
84 /* Power off the player using the same mechanism as the OF */ 84 /* Power off the player using the same mechanism as the OF */
diff --git a/firmware/target/arm/tms320dm320/creative-zvm/backlight-target.h b/firmware/target/arm/tms320dm320/creative-zvm/backlight-target.h
index c50ce6a128..4ebe3144cf 100644
--- a/firmware/target/arm/tms320dm320/creative-zvm/backlight-target.h
+++ b/firmware/target/arm/tms320dm320/creative-zvm/backlight-target.h
@@ -22,10 +22,10 @@
22#ifndef BACKLIGHT_TARGET_H 22#ifndef BACKLIGHT_TARGET_H
23#define BACKLIGHT_TARGET_H 23#define BACKLIGHT_TARGET_H
24 24
25bool _backlight_init(void); 25bool backlight_hw_init(void);
26void _backlight_on(void); 26void backlight_hw_on(void);
27void _backlight_off(void); 27void backlight_hw_off(void);
28void _backlight_set_brightness(int brightness); 28void backlight_hw_brightness(int brightness);
29 29
30/* true: backlight fades off - false: backlight fades on */ 30/* true: backlight fades off - false: backlight fades on */
31void __backlight_dim(bool dim); 31void __backlight_dim(bool dim);
diff --git a/firmware/target/arm/tms320dm320/mrobe-500/backlight-mr500.c b/firmware/target/arm/tms320dm320/mrobe-500/backlight-mr500.c
index 0cebc1bd5c..0b338c1640 100644
--- a/firmware/target/arm/tms320dm320/mrobe-500/backlight-mr500.c
+++ b/firmware/target/arm/tms320dm320/mrobe-500/backlight-mr500.c
@@ -55,7 +55,7 @@ static void _backlight_write_brightness(int brightness)
55 spi_block_transfer(SPI_target_BACKLIGHT, bl_command, 4, 0, 0); 55 spi_block_transfer(SPI_target_BACKLIGHT, bl_command, 4, 0, 0);
56} 56}
57 57
58void _backlight_on(void) 58void backlight_hw_on(void)
59{ 59{
60 lcd_awake(); /* power on lcd + visible display */ 60 lcd_awake(); /* power on lcd + visible display */
61 61
@@ -64,25 +64,25 @@ void _backlight_on(void)
64#endif 64#endif
65} 65}
66 66
67void _backlight_off(void) 67void backlight_hw_off(void)
68{ 68{
69 _backlight_write_brightness(0); 69 _backlight_write_brightness(0);
70} 70}
71 71
72/* Assumes that the backlight has been initialized */ 72/* Assumes that the backlight has been initialized */
73void _backlight_set_brightness(int brightness) 73void backlight_hw_brightness(int brightness)
74{ 74{
75 _backlight_write_brightness(brightness); 75 _backlight_write_brightness(brightness);
76} 76}
77 77
78void __backlight_dim(bool dim_now) 78void __backlight_dim(bool dim_now)
79{ 79{
80 _backlight_set_brightness(dim_now ? 80 backlight_hw_brightness(dim_now ?
81 DEFAULT_BRIGHTNESS_SETTING : 81 DEFAULT_BRIGHTNESS_SETTING :
82 DEFAULT_DIMNESS_SETTING); 82 DEFAULT_DIMNESS_SETTING);
83} 83}
84 84
85bool _backlight_init(void) 85bool backlight_hw_init(void)
86{ 86{
87 short read_value; 87 short read_value;
88 88
@@ -102,7 +102,7 @@ bool _backlight_init(void)
102 102
103 spi_block_transfer(SPI_target_BACKLIGHT, commands[2], 2, 0, 0); 103 spi_block_transfer(SPI_target_BACKLIGHT, commands[2], 2, 0, 0);
104 104
105 _backlight_set_brightness(backlight_brightness); 105 backlight_hw_brightness(backlight_brightness);
106 return true; 106 return true;
107} 107}
108 108
diff --git a/firmware/target/arm/tms320dm320/mrobe-500/backlight-target.h b/firmware/target/arm/tms320dm320/mrobe-500/backlight-target.h
index ab8ceacbb1..5e91cd691a 100644
--- a/firmware/target/arm/tms320dm320/mrobe-500/backlight-target.h
+++ b/firmware/target/arm/tms320dm320/mrobe-500/backlight-target.h
@@ -22,10 +22,10 @@
22#ifndef BACKLIGHT_TARGET_H 22#ifndef BACKLIGHT_TARGET_H
23#define BACKLIGHT_TARGET_H 23#define BACKLIGHT_TARGET_H
24 24
25bool _backlight_init(void); 25bool backlight_hw_init(void);
26void _backlight_on(void); 26void backlight_hw_on(void);
27void _backlight_off(void); 27void backlight_hw_off(void);
28void _backlight_set_brightness(int brightness); 28void backlight_hw_brightness(int brightness);
29 29
30/* true: backlight fades off - false: backlight fades on */ 30/* true: backlight fades off - false: backlight fades on */
31void __backlight_dim(bool dim); 31void __backlight_dim(bool dim);
diff --git a/firmware/target/arm/tms320dm320/mrobe-500/lcd-remote-mr500.c b/firmware/target/arm/tms320dm320/mrobe-500/lcd-remote-mr500.c
index b001032322..e21e1fa193 100644
--- a/firmware/target/arm/tms320dm320/mrobe-500/lcd-remote-mr500.c
+++ b/firmware/target/arm/tms320dm320/mrobe-500/lcd-remote-mr500.c
@@ -292,13 +292,13 @@ void lcd_remote_update_rect(int x, int y, int width, int height)
292 remote_state_control=REMOTE_CONTROL_DRAW; 292 remote_state_control=REMOTE_CONTROL_DRAW;
293} 293}
294 294
295void _remote_backlight_on(void) 295void remote_backlight_hw_on(void)
296{ 296{
297 remote_power|=0x40; 297 remote_power|=0x40;
298 remote_state_control_next=REMOTE_CONTROL_POWER; 298 remote_state_control_next=REMOTE_CONTROL_POWER;
299} 299}
300 300
301void _remote_backlight_off(void) 301void remote_backlight_hw_off(void)
302{ 302{
303 remote_power&=~(0x40); 303 remote_power&=~(0x40);
304 remote_state_control_next=REMOTE_CONTROL_POWER; 304 remote_state_control_next=REMOTE_CONTROL_POWER;
diff --git a/firmware/target/arm/tms320dm320/mrobe-500/power-mr500.c b/firmware/target/arm/tms320dm320/mrobe-500/power-mr500.c
index d9e0d52191..77348317a6 100644
--- a/firmware/target/arm/tms320dm320/mrobe-500/power-mr500.c
+++ b/firmware/target/arm/tms320dm320/mrobe-500/power-mr500.c
@@ -75,7 +75,7 @@ bool ide_powered(void)
75void power_off(void) 75void power_off(void)
76{ 76{
77 /* turn off backlight and wait for 1 second */ 77 /* turn off backlight and wait for 1 second */
78 _backlight_off(); 78 backlight_hw_off();
79#if defined(HAVE_REMOTE_LCD) 79#if defined(HAVE_REMOTE_LCD)
80 lcd_remote_sleep(); 80 lcd_remote_sleep();
81#endif 81#endif
diff --git a/firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c b/firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c
index c8b2c9623c..611bdbfde5 100644
--- a/firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c
+++ b/firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c
@@ -92,15 +92,15 @@ static void handle_wheel(unsigned char wheel)
92 static unsigned char velocity = 0; 92 static unsigned char velocity = 0;
93 static unsigned long wheel_delta = 1ul << 24; 93 static unsigned long wheel_delta = 1ul << 24;
94 static unsigned char wheel_prev = 0; 94 static unsigned char wheel_prev = 0;
95 static long next_backlight_on = 0; 95 static long nextbacklight_hw_on = 0;
96 static int prev_key = -1; 96 static int prev_key = -1;
97 static int prev_key_post = 0; 97 static int prev_key_post = 0;
98 98
99 if (TIME_AFTER(current_tick, next_backlight_on)) 99 if (TIME_AFTER(current_tick, nextbacklight_hw_on))
100 { 100 {
101 backlight_on(); 101 backlight_on();
102 reset_poweroff_timer(); 102 reset_poweroff_timer();
103 next_backlight_on = current_tick + HZ/4; 103 nextbacklight_hw_on = current_tick + HZ/4;
104 } 104 }
105 105
106 if (wheel_prev < wheel) 106 if (wheel_prev < wheel)
diff --git a/firmware/target/arm/tms320dm320/sansa-connect/backlight-sansaconnect.c b/firmware/target/arm/tms320dm320/sansa-connect/backlight-sansaconnect.c
index 4104c21e52..c65d806635 100644
--- a/firmware/target/arm/tms320dm320/sansa-connect/backlight-sansaconnect.c
+++ b/firmware/target/arm/tms320dm320/sansa-connect/backlight-sansaconnect.c
@@ -50,7 +50,7 @@ static void _backlight_write_brightness(int brightness)
50 IO_CLK_PWM1H = brightness*70; 50 IO_CLK_PWM1H = brightness*70;
51} 51}
52 52
53void _backlight_on(void) 53void backlight_hw_on(void)
54{ 54{
55#ifdef HAVE_LCD_SLEEP 55#ifdef HAVE_LCD_SLEEP
56 if (!lcd_active()) 56 if (!lcd_active())
@@ -67,7 +67,7 @@ void _backlight_on(void)
67#endif 67#endif
68} 68}
69 69
70void _backlight_off(void) 70void backlight_hw_off(void)
71{ 71{
72 _backlight_write_brightness(0); 72 _backlight_write_brightness(0);
73 73
@@ -77,23 +77,23 @@ void _backlight_off(void)
77} 77}
78 78
79/* Assumes that the backlight has been initialized */ 79/* Assumes that the backlight has been initialized */
80void _backlight_set_brightness(int brightness) 80void backlight_hw_brightness(int brightness)
81{ 81{
82 _backlight_write_brightness(brightness); 82 _backlight_write_brightness(brightness);
83} 83}
84 84
85void __backlight_dim(bool dim_now) 85void __backlight_dim(bool dim_now)
86{ 86{
87 _backlight_set_brightness(dim_now ? 87 backlight_hw_brightness(dim_now ?
88 DEFAULT_BRIGHTNESS_SETTING : 88 DEFAULT_BRIGHTNESS_SETTING :
89 DEFAULT_DIMNESS_SETTING); 89 DEFAULT_DIMNESS_SETTING);
90} 90}
91 91
92bool _backlight_init(void) 92bool backlight_hw_init(void)
93{ 93{
94 IO_CLK_PWM1C = 0x58D; /* as found in OF */ 94 IO_CLK_PWM1C = 0x58D; /* as found in OF */
95 95
96 _backlight_set_brightness(backlight_brightness); 96 backlight_hw_brightness(backlight_brightness);
97 return true; 97 return true;
98} 98}
99 99
diff --git a/firmware/target/arm/tms320dm320/sansa-connect/backlight-target.h b/firmware/target/arm/tms320dm320/sansa-connect/backlight-target.h
index 89bd837cee..3a6fc8cf11 100644
--- a/firmware/target/arm/tms320dm320/sansa-connect/backlight-target.h
+++ b/firmware/target/arm/tms320dm320/sansa-connect/backlight-target.h
@@ -22,10 +22,10 @@
22#ifndef BACKLIGHT_TARGET_H 22#ifndef BACKLIGHT_TARGET_H
23#define BACKLIGHT_TARGET_H 23#define BACKLIGHT_TARGET_H
24 24
25bool _backlight_init(void); 25bool backlight_hw_init(void);
26void _backlight_on(void); 26void backlight_hw_on(void);
27void _backlight_off(void); 27void backlight_hw_off(void);
28void _backlight_set_brightness(int brightness); 28void backlight_hw_brightness(int brightness);
29 29
30/* true: backlight fades off - false: backlight fades on */ 30/* true: backlight fades off - false: backlight fades on */
31void __backlight_dim(bool dim); 31void __backlight_dim(bool dim);