summaryrefslogtreecommitdiff
path: root/apps
diff options
context:
space:
mode:
Diffstat (limited to 'apps')
-rw-r--r--apps/plugins/pictureflow/pictureflow.c3
-rw-r--r--apps/tagcache.c4
2 files changed, 7 insertions, 0 deletions
diff --git a/apps/plugins/pictureflow/pictureflow.c b/apps/plugins/pictureflow/pictureflow.c
index e5492cf01c..b68e879fc4 100644
--- a/apps/plugins/pictureflow/pictureflow.c
+++ b/apps/plugins/pictureflow/pictureflow.c
@@ -1218,7 +1218,10 @@ static int create_album_untagged(struct tagcache_search *tcs,
1218 { 1218 {
1219 if (rb->button_get(false) > BUTTON_NONE) { 1219 if (rb->button_get(false) > BUTTON_NONE) {
1220 if (confirm_quit()) 1220 if (confirm_quit())
1221 {
1222 rb->tagcache_search_finish(tcs);
1221 return ERROR_USER_ABORT; 1223 return ERROR_USER_ABORT;
1224 }
1222 else 1225 else
1223 { 1226 {
1224 rb->lcd_clear_display(); 1227 rb->lcd_clear_display();
diff --git a/apps/tagcache.c b/apps/tagcache.c
index 5bfeb82481..7d8d2aec22 100644
--- a/apps/tagcache.c
+++ b/apps/tagcache.c
@@ -970,6 +970,7 @@ static int find_index(const char *filename)
970 970
971bool tagcache_find_index(struct tagcache_search *tcs, const char *filename) 971bool tagcache_find_index(struct tagcache_search *tcs, const char *filename)
972{ 972{
973 /* NOTE: on ret==true you need to call tagcache_search_finish(tcs) yourself */
973 int idx_id; 974 int idx_id;
974 975
975 if (!tc_stat.ready) 976 if (!tc_stat.ready)
@@ -1721,6 +1722,7 @@ static bool build_lookup_list(struct tagcache_search *tcs)
1721 1722
1722bool tagcache_search(struct tagcache_search *tcs, int tag) 1723bool tagcache_search(struct tagcache_search *tcs, int tag)
1723{ 1724{
1725 /* NOTE: call tagcache_search_finish(&tcs) when finished or BAD things may happen (TM) */
1724 struct tagcache_header tag_hdr; 1726 struct tagcache_header tag_hdr;
1725 struct master_header master_hdr; 1727 struct master_header master_hdr;
1726 int i; 1728 int i;
@@ -3936,6 +3938,7 @@ bool tagcache_create_changelog(struct tagcache_search *tcs)
3936 if (clfd < 0) 3938 if (clfd < 0)
3937 { 3939 {
3938 logf("failure to open changelog"); 3940 logf("failure to open changelog");
3941 tagcache_search_finish(tcs);
3939 return false; 3942 return false;
3940 } 3943 }
3941 3944
@@ -3944,6 +3947,7 @@ bool tagcache_create_changelog(struct tagcache_search *tcs)
3944 if ( (tcs->masterfd = open_master_fd(&myhdr, false)) < 0) 3947 if ( (tcs->masterfd = open_master_fd(&myhdr, false)) < 0)
3945 { 3948 {
3946 close(clfd); 3949 close(clfd);
3950 tagcache_search_finish(tcs);
3947 return false; 3951 return false;
3948 } 3952 }
3949 } 3953 }