summaryrefslogtreecommitdiff
path: root/apps/plugins
diff options
context:
space:
mode:
Diffstat (limited to 'apps/plugins')
-rw-r--r--apps/plugins/puzzles/README.rockbox53
-rwxr-xr-xapps/plugins/puzzles/genhelp.sh4
-rw-r--r--apps/plugins/puzzles/src/map.c1
3 files changed, 56 insertions, 2 deletions
diff --git a/apps/plugins/puzzles/README.rockbox b/apps/plugins/puzzles/README.rockbox
index b64b60f694..117383eacb 100644
--- a/apps/plugins/puzzles/README.rockbox
+++ b/apps/plugins/puzzles/README.rockbox
@@ -31,6 +31,56 @@ distribution. The compression is LZ4, implemented in lz4tiny.c (for
31decompression on target), and compress.c (for generation). genhelp.sh 31decompression on target), and compress.c (for generation). genhelp.sh
32should be run whenever the documentation is changed. 32should be run whenever the documentation is changed.
33 33
34Upstreams
35=========
36
37As of 2024, Simon's tree is located at:
38
39https://git.tartarus.org/?p=simon/puzzles.git
40
41For a long time (i.e. 2017-2024), our version of the puzzles tree
42contained several modifications by myself (notably cursor interfaces
43to Untangle and Palisade). These divergent changes complicated
44maintenance of this port, as merge conflicts often arose when upstream
45changes to these games conflicted with our changes. To remedy this, I
46sent most of these patches back upstream in summer 2024, and since
47then, Simon has merged the majority of them into his tree.
48
49This leaves us with a very small set of places where our branch of the
50puzzles source diverges from Simon's. That branch lives here:
51
52https://github.com/built1n/puzzles/tree/rockbox-devel
53
54Notably, there are several hacks which work around Rockbox's lack of a
55proper polygon filling algorithm. Eliminating this deficiency would
56enable us to use a totally unmodified upstream source tree.
57
58Maintenance
59===========
60
61Simon's upstream tree sees continued development. The port is
62structured so that integrating new upstream versions is
63straightforward: all the upstream sources live in the src/
64subdirectory; all of the Rockbox frontend lives in the root
65apps/pluginspuzzles/ directory.
66
67The `resync.sh' shell script automates the resyncing process. It
68copies the upstream sources (point it to a local copy of the
69rockbox-devel branch above) into src/ and performs auto-generation of
70the help content. Note that a modified version of "halibut" (Simon's
71homegrown documentation processor) must be compiled from this source:
72
73https://github.com/built1n/halibut
74
75The LZ4 library and GCC are necessary as well.
76
77Wishlist
78========
79
80- Proper polygon filling algorithm. The current algorithm is a hack
81 that uses overdrawn triangles. This will enable us to eliminate the
82 last of the Rockbox-specific modifications.
83
34Kudos to Simon (duh), and Frank, for telling me about it. 84Kudos to Simon (duh), and Frank, for telling me about it.
35 85
36Franklin Wei (__builtin) 86Franklin Wei (__builtin)
@@ -67,3 +117,6 @@ saved games.
67 117
68July 2024: Resync to 1c62dac (branched from Simon's fd304c5). 118July 2024: Resync to 1c62dac (branched from Simon's fd304c5).
69Implement user preferences menu. Introduced "Mosaic". 119Implement user preferences menu. Introduced "Mosaic".
120
121August 2024: Resync to ee5e327 (branched from Simon's
1221c1899e). Changes default Map stipple size to "Small".
diff --git a/apps/plugins/puzzles/genhelp.sh b/apps/plugins/puzzles/genhelp.sh
index f515bb25dc..588eff4c97 100755
--- a/apps/plugins/puzzles/genhelp.sh
+++ b/apps/plugins/puzzles/genhelp.sh
@@ -1,8 +1,8 @@
1#!/bin/bash 1#!/bin/bash
2# usage: ./genhelp.sh 2# usage: ./genhelp.sh
3# 3#
4# Expects halibut to be installed in $PATH: 4# Expects a modified version of `halibut' to be installed in $PATH:
5# https://www.fwei.tk/git/halibut 5# https://github.com/built1n/halibut
6# 6#
7# Also requires host CC and lz4 library to be available 7# Also requires host CC and lz4 library to be available
8 8
diff --git a/apps/plugins/puzzles/src/map.c b/apps/plugins/puzzles/src/map.c
index 9cea0d4647..2ef156e72a 100644
--- a/apps/plugins/puzzles/src/map.c
+++ b/apps/plugins/puzzles/src/map.c
@@ -2330,6 +2330,7 @@ static game_ui *new_ui(const game_state *state)
2330 ui->cur_moved = false; 2330 ui->cur_moved = false;
2331 ui->cur_lastmove = 0; 2331 ui->cur_lastmove = 0;
2332 ui->flash_type = FLASH_CYCLIC; 2332 ui->flash_type = FLASH_CYCLIC;
2333 ui->large_stipples = false;
2333 legacy_prefs_override(ui); 2334 legacy_prefs_override(ui);
2334 return ui; 2335 return ui;
2335} 2336}