summaryrefslogtreecommitdiff
path: root/utils/rbutilqt/test
diff options
context:
space:
mode:
authorDominik Riebeling <Dominik.Riebeling@gmail.com>2022-04-17 12:26:43 +0200
committerDominik Riebeling <Dominik.Riebeling@gmail.com>2022-04-17 23:21:19 +0200
commit62108a96137dff6fefb61d2af8dc59e8716ccb96 (patch)
tree621b185a5f3d9b88a41fdae89b348f413cd6b7b2 /utils/rbutilqt/test
parent8c55ce62b9e65533619870d1e5b72612a1a16406 (diff)
downloadrockbox-62108a96137dff6fefb61d2af8dc59e8716ccb96.tar.gz
rockbox-62108a96137dff6fefb61d2af8dc59e8716ccb96.zip
rbutil: Use references to avoid creating temporary objects.
Get rid of some unnecessary object creating / copying by using references. Change-Id: Ia44e34f6f66d230caa9af7ef7c0eca73be12de2a
Diffstat (limited to 'utils/rbutilqt/test')
-rw-r--r--utils/rbutilqt/test/stubs/stubs-talkgenerator.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/utils/rbutilqt/test/stubs/stubs-talkgenerator.cpp b/utils/rbutilqt/test/stubs/stubs-talkgenerator.cpp
index 295dc81a78..a67600a0ae 100644
--- a/utils/rbutilqt/test/stubs/stubs-talkgenerator.cpp
+++ b/utils/rbutilqt/test/stubs/stubs-talkgenerator.cpp
@@ -54,7 +54,7 @@ public:
54 TTSFakeEspeak(QObject *parent): TTSBase(parent) {} 54 TTSFakeEspeak(QObject *parent): TTSBase(parent) {}
55 virtual bool start(QString *errStr) { (void)errStr; return true; } 55 virtual bool start(QString *errStr) { (void)errStr; return true; }
56 virtual bool stop() { return true; } 56 virtual bool stop() { return true; }
57 virtual TTSStatus voice(QString text, QString wavfile, QString *errStr) 57 virtual TTSStatus voice(const QString& text, const QString& wavfile, QString *errStr)
58 { (void)text; (void)wavfile; (void)errStr; return NoError; } 58 { (void)text; (void)wavfile; (void)errStr; return NoError; }
59 virtual QString voiceVendor() { return QString("DummyVendor"); } 59 virtual QString voiceVendor() { return QString("DummyVendor"); }
60 virtual bool configOk() { return true; } 60 virtual bool configOk() { return true; }
@@ -67,7 +67,7 @@ TTSBase::TTSBase(QObject* parent) : EncTtsSettingInterface(parent)
67{ 67{
68} 68}
69 69
70TTSStatus TTSBase::voice(QString /*text*/, QString /*wavfile*/, QString* /*errStr*/) 70TTSStatus TTSBase::voice(const QString& /*text*/, const QString& /*wavfile*/, QString* /*errStr*/)
71{ 71{
72 return NoError; 72 return NoError;
73} 73}