diff options
author | Michael Sevakis <jethead71@rockbox.org> | 2017-01-30 09:52:05 -0500 |
---|---|---|
committer | Michael Sevakis <jethead71@rockbox.org> | 2017-02-11 22:19:32 -0500 |
commit | fc9695eb47732e1c189e2f033dbd55e5c346e8c4 (patch) | |
tree | 550830e9af67f47e3eb87587770b25d22110f57a /firmware/target/hosted/samsungypr/radio-ypr.c | |
parent | 6436c6e749ab04fbd5d97804a6a1c3b3122b326d (diff) | |
download | rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.tar.gz rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.zip |
Improve radio RDS driver and framework
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.
* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.
Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.
Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.
* Time out of stale text.
* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?
* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.
* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).
Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Diffstat (limited to 'firmware/target/hosted/samsungypr/radio-ypr.c')
-rw-r--r-- | firmware/target/hosted/samsungypr/radio-ypr.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/firmware/target/hosted/samsungypr/radio-ypr.c b/firmware/target/hosted/samsungypr/radio-ypr.c index 1929bb7c90..af49c4c3f2 100644 --- a/firmware/target/hosted/samsungypr/radio-ypr.c +++ b/firmware/target/hosted/samsungypr/radio-ypr.c | |||
@@ -29,7 +29,6 @@ | |||
29 | #include "kernel.h" | 29 | #include "kernel.h" |
30 | 30 | ||
31 | #include "radio-ypr.h" | 31 | #include "radio-ypr.h" |
32 | #include "rds.h" | ||
33 | #include "si4700.h" | 32 | #include "si4700.h" |
34 | #include "power.h" | 33 | #include "power.h" |
35 | 34 | ||
@@ -79,7 +78,6 @@ int fmradio_i2c_read(unsigned char address, unsigned char* buf, int count) | |||
79 | /* Low-level RDS Support */ | 78 | /* Low-level RDS Support */ |
80 | static struct event_queue rds_queue; | 79 | static struct event_queue rds_queue; |
81 | static uint32_t rds_stack[DEFAULT_STACK_SIZE / sizeof(uint32_t)]; | 80 | static uint32_t rds_stack[DEFAULT_STACK_SIZE / sizeof(uint32_t)]; |
82 | static uint16_t rds_data[4]; | ||
83 | 81 | ||
84 | enum { | 82 | enum { |
85 | Q_POWERUP, | 83 | Q_POWERUP, |
@@ -101,8 +99,7 @@ static void NORETURN_ATTR rds_thread(void) | |||
101 | case SYS_TIMEOUT: | 99 | case SYS_TIMEOUT: |
102 | /* Captures RDS data and processes it */ | 100 | /* Captures RDS data and processes it */ |
103 | if ((si4709_read_reg(STATUSRSSI) & STATUSRSSI_RDSR) >> 8) { | 101 | if ((si4709_read_reg(STATUSRSSI) & STATUSRSSI_RDSR) >> 8) { |
104 | if (si4700_rds_read_raw(rds_data) && rds_process(rds_data)) | 102 | si4700_rds_process(); |
105 | si4700_rds_set_event(); | ||
106 | } | 103 | } |
107 | break; | 104 | break; |
108 | } | 105 | } |
@@ -121,6 +118,5 @@ void si4700_rds_init(void) | |||
121 | queue_init(&rds_queue, false); | 118 | queue_init(&rds_queue, false); |
122 | create_thread(rds_thread, rds_stack, sizeof(rds_stack), 0, "rds" | 119 | create_thread(rds_thread, rds_stack, sizeof(rds_stack), 0, "rds" |
123 | IF_PRIO(, PRIORITY_PLAYBACK) IF_COP(, CPU)); | 120 | IF_PRIO(, PRIORITY_PLAYBACK) IF_COP(, CPU)); |
124 | rds_init(); | ||
125 | } | 121 | } |
126 | #endif /* HAVE_RDS_CAP */ | 122 | #endif /* HAVE_RDS_CAP */ |