diff options
author | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-11 04:41:36 +0000 |
---|---|---|
committer | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-11 04:41:36 +0000 |
commit | 45c7498f59ad2889f2120a865a51043004eddd5d (patch) | |
tree | 1a62b0e8549a7f2750679de8d7dd3f82039c5719 /firmware/target/arm/philips/hdd1630 | |
parent | fe7ca44471b309a0adea563cce947de9efb62ab5 (diff) | |
download | rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.tar.gz rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.zip |
FS#11335 by me: make ARM assembly functions thumb-friendly
We can't pop into pc on ARMv4t when using thumb: the T bit won't be
modified if we are returning to a thumb function
Code running on ARMv4t should use the new ldrpc / ldmpc macros instead
of ldr pc, [sp], #4 and ldm(cond) sp!, {regs, pc}
No modification on pure ARM builds and ARMv5+
Note: USE_THUMB is currently never defined, no targets can currently be
built with -mthumb, see FS#6734
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26756 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware/target/arm/philips/hdd1630')
-rw-r--r-- | firmware/target/arm/philips/hdd1630/lcd-as-hdd1630.S | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/firmware/target/arm/philips/hdd1630/lcd-as-hdd1630.S b/firmware/target/arm/philips/hdd1630/lcd-as-hdd1630.S index 73ad84ae45..7be807ae98 100644 --- a/firmware/target/arm/philips/hdd1630/lcd-as-hdd1630.S +++ b/firmware/target/arm/philips/hdd1630/lcd-as-hdd1630.S | |||
@@ -248,7 +248,7 @@ lcd_write_yuv420_lines: | |||
248 | subs r1, r1, #2 @ subtract block from width | 248 | subs r1, r1, #2 @ subtract block from width |
249 | bgt 10b @ loop line @ | 249 | bgt 10b @ loop line @ |
250 | @ | 250 | @ |
251 | ldmfd sp!, { r4-r11, pc } @ restore registers and return | 251 | ldmpc regs=r4-r11 @ restore registers and return |
252 | .ltorg @ dump constant pool | 252 | .ltorg @ dump constant pool |
253 | .size lcd_write_yuv420_lines, .-lcd_write_yuv420_lines | 253 | .size lcd_write_yuv420_lines, .-lcd_write_yuv420_lines |
254 | 254 | ||
@@ -565,6 +565,6 @@ lcd_write_yuv420_lines_odither: | |||
565 | subs r1, r1, #2 @ subtract block from width | 565 | subs r1, r1, #2 @ subtract block from width |
566 | bgt 10b @ loop line @ | 566 | bgt 10b @ loop line @ |
567 | @ | 567 | @ |
568 | ldmfd sp!, { r4-r11, pc } @ restore registers and return | 568 | ldmpc regs=r4-r11 @ restore registers and return |
569 | .ltorg @ dump constant pool | 569 | .ltorg @ dump constant pool |
570 | .size lcd_write_yuv420_lines_odither, .-lcd_write_yuv420_lines_odither | 570 | .size lcd_write_yuv420_lines_odither, .-lcd_write_yuv420_lines_odither |