diff options
author | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-11 04:41:36 +0000 |
---|---|---|
committer | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-11 04:41:36 +0000 |
commit | 45c7498f59ad2889f2120a865a51043004eddd5d (patch) | |
tree | 1a62b0e8549a7f2750679de8d7dd3f82039c5719 /firmware/target/arm/memcpy-arm.S | |
parent | fe7ca44471b309a0adea563cce947de9efb62ab5 (diff) | |
download | rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.tar.gz rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.zip |
FS#11335 by me: make ARM assembly functions thumb-friendly
We can't pop into pc on ARMv4t when using thumb: the T bit won't be
modified if we are returning to a thumb function
Code running on ARMv4t should use the new ldrpc / ldmpc macros instead
of ldr pc, [sp], #4 and ldm(cond) sp!, {regs, pc}
No modification on pure ARM builds and ARMv5+
Note: USE_THUMB is currently never defined, no targets can currently be
built with -mthumb, see FS#6734
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26756 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware/target/arm/memcpy-arm.S')
-rw-r--r-- | firmware/target/arm/memcpy-arm.S | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/firmware/target/arm/memcpy-arm.S b/firmware/target/arm/memcpy-arm.S index d17d659a28..2a55fb5656 100644 --- a/firmware/target/arm/memcpy-arm.S +++ b/firmware/target/arm/memcpy-arm.S | |||
@@ -98,7 +98,7 @@ memcpy: | |||
98 | strcsb r4, [r0], #1 | 98 | strcsb r4, [r0], #1 |
99 | strcsb ip, [r0] | 99 | strcsb ip, [r0] |
100 | 100 | ||
101 | ldmfd sp!, {r0, r4, pc} | 101 | ldmpc regs="r0, r4" |
102 | 102 | ||
103 | 9: rsb ip, ip, #4 | 103 | 9: rsb ip, ip, #4 |
104 | cmp ip, #2 | 104 | cmp ip, #2 |