diff options
author | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-11 04:41:36 +0000 |
---|---|---|
committer | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-11 04:41:36 +0000 |
commit | 45c7498f59ad2889f2120a865a51043004eddd5d (patch) | |
tree | 1a62b0e8549a7f2750679de8d7dd3f82039c5719 /firmware/target/arm/lcd-as-memframe.S | |
parent | fe7ca44471b309a0adea563cce947de9efb62ab5 (diff) | |
download | rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.tar.gz rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.zip |
FS#11335 by me: make ARM assembly functions thumb-friendly
We can't pop into pc on ARMv4t when using thumb: the T bit won't be
modified if we are returning to a thumb function
Code running on ARMv4t should use the new ldrpc / ldmpc macros instead
of ldr pc, [sp], #4 and ldm(cond) sp!, {regs, pc}
No modification on pure ARM builds and ARMv5+
Note: USE_THUMB is currently never defined, no targets can currently be
built with -mthumb, see FS#6734
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26756 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware/target/arm/lcd-as-memframe.S')
-rw-r--r-- | firmware/target/arm/lcd-as-memframe.S | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/firmware/target/arm/lcd-as-memframe.S b/firmware/target/arm/lcd-as-memframe.S index 4532bab221..87cbb611ca 100644 --- a/firmware/target/arm/lcd-as-memframe.S +++ b/firmware/target/arm/lcd-as-memframe.S | |||
@@ -101,7 +101,7 @@ lcd_copy_buffer_rect: @ | |||
101 | add r0, r0, r4, lsl #1 @ | 101 | add r0, r0, r4, lsl #1 @ |
102 | subs r3, r3, #1 @ next line | 102 | subs r3, r3, #1 @ next line |
103 | bgt 10b @ copy line @ | 103 | bgt 10b @ copy line @ |
104 | ldmfd sp!, { r4-r11, pc } @ restore regs and return | 104 | ldmpc regs=r4-r11 @ restore regs and return |
105 | .ltorg @ dump constant pool | 105 | .ltorg @ dump constant pool |
106 | .size lcd_copy_buffer_rect, .-lcd_copy_buffer_rect | 106 | .size lcd_copy_buffer_rect, .-lcd_copy_buffer_rect |
107 | 107 | ||
@@ -344,7 +344,7 @@ lcd_write_yuv420_lines: | |||
344 | subs r2, r2, #2 @ subtract block from width | 344 | subs r2, r2, #2 @ subtract block from width |
345 | bgt 10b @ loop line @ | 345 | bgt 10b @ loop line @ |
346 | @ | 346 | @ |
347 | ldmfd sp!, { r4-r10, pc } @ restore registers and return | 347 | ldmpc regs=r4-r10 @ restore registers and return |
348 | .ltorg @ dump constant pool | 348 | .ltorg @ dump constant pool |
349 | .size lcd_write_yuv420_lines, .-lcd_write_yuv420_lines | 349 | .size lcd_write_yuv420_lines, .-lcd_write_yuv420_lines |
350 | 350 | ||
@@ -691,6 +691,6 @@ lcd_write_yuv420_lines_odither: | |||
691 | subs r2, r2, #2 @ subtract block from width | 691 | subs r2, r2, #2 @ subtract block from width |
692 | bgt 10b @ loop line @ | 692 | bgt 10b @ loop line @ |
693 | @ | 693 | @ |
694 | ldmfd sp!, { r4-r11, pc } @ restore registers and return | 694 | ldmpc regs=r4-r11 @ restore registers and return |
695 | .ltorg @ dump constant pool | 695 | .ltorg @ dump constant pool |
696 | .size lcd_write_yuv420_lines_odither, .-lcd_write_yuv420_lines_odither | 696 | .size lcd_write_yuv420_lines_odither, .-lcd_write_yuv420_lines_odither |