summaryrefslogtreecommitdiff
path: root/firmware/target/arm/ipod/lcd-as-gray.S
diff options
context:
space:
mode:
authorRafaël Carré <rafael.carre@gmail.com>2010-06-11 04:41:36 +0000
committerRafaël Carré <rafael.carre@gmail.com>2010-06-11 04:41:36 +0000
commit45c7498f59ad2889f2120a865a51043004eddd5d (patch)
tree1a62b0e8549a7f2750679de8d7dd3f82039c5719 /firmware/target/arm/ipod/lcd-as-gray.S
parentfe7ca44471b309a0adea563cce947de9efb62ab5 (diff)
downloadrockbox-45c7498f59ad2889f2120a865a51043004eddd5d.tar.gz
rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.zip
FS#11335 by me: make ARM assembly functions thumb-friendly
We can't pop into pc on ARMv4t when using thumb: the T bit won't be modified if we are returning to a thumb function Code running on ARMv4t should use the new ldrpc / ldmpc macros instead of ldr pc, [sp], #4 and ldm(cond) sp!, {regs, pc} No modification on pure ARM builds and ARMv5+ Note: USE_THUMB is currently never defined, no targets can currently be built with -mthumb, see FS#6734 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26756 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware/target/arm/ipod/lcd-as-gray.S')
-rw-r--r--firmware/target/arm/ipod/lcd-as-gray.S8
1 files changed, 4 insertions, 4 deletions
diff --git a/firmware/target/arm/ipod/lcd-as-gray.S b/firmware/target/arm/ipod/lcd-as-gray.S
index 1364c1f965..cfd179a714 100644
--- a/firmware/target/arm/ipod/lcd-as-gray.S
+++ b/firmware/target/arm/ipod/lcd-as-gray.S
@@ -97,7 +97,7 @@ lcd_write_data_shifted:
97 subs r1, r1, #1 97 subs r1, r1, #1
98 bne .sloop 98 bne .sloop
99 99
100 ldmfd sp!, {r4, pc} 100 ldmpc regs=r4
101 .size lcd_write_data_shifted,.-lcd_write_data_shifted 101 .size lcd_write_data_shifted,.-lcd_write_data_shifted
102 102
103#elif defined IPOD_MINI 103#elif defined IPOD_MINI
@@ -132,7 +132,7 @@ lcd_write_data_shifted:
132 subs r1, r1, #1 132 subs r1, r1, #1
133 bne .sloop 133 bne .sloop
134 134
135 ldr pc, [sp], #4 135 ldrpc
136 .size lcd_write_data_shifted,.-lcd_write_data_shifted 136 .size lcd_write_data_shifted,.-lcd_write_data_shifted
137 137
138#endif 138#endif
@@ -179,7 +179,7 @@ lcd_mono_data:
179 subs r1, r1, #1 179 subs r1, r1, #1
180 bne .mloop 180 bne .mloop
181 181
182 ldmfd sp!, {r4, pc} 182 ldmpc regs=r4
183 183
184.dibits: 184.dibits:
185 .byte 0x00, 0x03, 0x0C, 0x0F, 0x30, 0x33, 0x3C, 0x3F 185 .byte 0x00, 0x03, 0x0C, 0x0F, 0x30, 0x33, 0x3C, 0x3F
@@ -267,6 +267,6 @@ lcd_grey_data:
267 subs r2, r2, #1 267 subs r2, r2, #1
268 bne .greyloop 268 bne .greyloop
269 269
270 ldmfd sp!, {r4-r7, pc} 270 ldmpc regs=r4-r7
271 .size lcd_grey_data,.-lcd_grey_data 271 .size lcd_grey_data,.-lcd_grey_data
272 272