summaryrefslogtreecommitdiff
path: root/firmware/target/arm/as3525
diff options
context:
space:
mode:
authorRafaël Carré <rafael.carre@gmail.com>2010-06-11 04:41:36 +0000
committerRafaël Carré <rafael.carre@gmail.com>2010-06-11 04:41:36 +0000
commit45c7498f59ad2889f2120a865a51043004eddd5d (patch)
tree1a62b0e8549a7f2750679de8d7dd3f82039c5719 /firmware/target/arm/as3525
parentfe7ca44471b309a0adea563cce947de9efb62ab5 (diff)
downloadrockbox-45c7498f59ad2889f2120a865a51043004eddd5d.tar.gz
rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.zip
FS#11335 by me: make ARM assembly functions thumb-friendly
We can't pop into pc on ARMv4t when using thumb: the T bit won't be modified if we are returning to a thumb function Code running on ARMv4t should use the new ldrpc / ldmpc macros instead of ldr pc, [sp], #4 and ldm(cond) sp!, {regs, pc} No modification on pure ARM builds and ARMv5+ Note: USE_THUMB is currently never defined, no targets can currently be built with -mthumb, see FS#6734 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26756 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware/target/arm/as3525')
-rw-r--r--firmware/target/arm/as3525/lcd-as-e200v2-fuze-fuzev2.S4
-rw-r--r--firmware/target/arm/as3525/sansa-clip/lcd-as-clip.S3
2 files changed, 4 insertions, 3 deletions
diff --git a/firmware/target/arm/as3525/lcd-as-e200v2-fuze-fuzev2.S b/firmware/target/arm/as3525/lcd-as-e200v2-fuze-fuzev2.S
index f71216c674..690641c850 100644
--- a/firmware/target/arm/as3525/lcd-as-e200v2-fuze-fuzev2.S
+++ b/firmware/target/arm/as3525/lcd-as-e200v2-fuze-fuzev2.S
@@ -241,7 +241,7 @@ lcd_write_yuv420_lines:
241 tst r7, #DBOP_BUSY @ fifo not empty? 241 tst r7, #DBOP_BUSY @ fifo not empty?
242 beq 1b @ 242 beq 1b @
243 243
244 ldmfd sp!, { r4-r11, pc } @ restore registers and return 244 ldmpc regs=r4-r11 @ restore registers and return
245 .ltorg @ dump constant pool 245 .ltorg @ dump constant pool
246 .size lcd_write_yuv420_lines, .-lcd_write_yuv420_lines 246 .size lcd_write_yuv420_lines, .-lcd_write_yuv420_lines
247 247
@@ -545,6 +545,6 @@ lcd_write_yuv420_lines_odither:
545 tst r7, #DBOP_BUSY @ fifo not empty? 545 tst r7, #DBOP_BUSY @ fifo not empty?
546 beq 1b @ 546 beq 1b @
547 547
548 ldmfd sp!, { r4-r11, pc } @ restore registers and return 548 ldmpc regs=r4-r11 @ restore registers and return
549 .ltorg @ dump constant pool 549 .ltorg @ dump constant pool
550 .size lcd_write_yuv420_lines_odither, .-lcd_write_yuv420_lines_odither 550 .size lcd_write_yuv420_lines_odither, .-lcd_write_yuv420_lines_odither
diff --git a/firmware/target/arm/as3525/sansa-clip/lcd-as-clip.S b/firmware/target/arm/as3525/sansa-clip/lcd-as-clip.S
index 942ddf79f8..431dc62da0 100644
--- a/firmware/target/arm/as3525/sansa-clip/lcd-as-clip.S
+++ b/firmware/target/arm/as3525/sansa-clip/lcd-as-clip.S
@@ -19,6 +19,7 @@
19 * 19 *
20 ****************************************************************************/ 20 ****************************************************************************/
21 21
22#include "config.h"
22#include "as3525.h" 23#include "as3525.h"
23 24
24 .text 25 .text
@@ -90,5 +91,5 @@ lcd_grey_data:
90 ands r5, r5, #(1<<10) @ wait until push fifo empties 91 ands r5, r5, #(1<<10) @ wait until push fifo empties
91 beq 1b 92 beq 1b
92 93
93 ldmfd sp!, {r4-r7, pc} 94 ldmpc regs=r4-r7
94 .size lcd_grey_data,.-lcd_grey_data 95 .size lcd_grey_data,.-lcd_grey_data