diff options
author | Thomas Martitz <kugel@rockbox.org> | 2011-06-13 16:50:10 +0000 |
---|---|---|
committer | Thomas Martitz <kugel@rockbox.org> | 2011-06-13 16:50:10 +0000 |
commit | 3b18158688415e311b2d5333cb4262912fb2a424 (patch) | |
tree | 7ccf0ea8f567cb8d882a3d2a94bfecc675192897 /apps | |
parent | b843abef86dc44a5803299cf53c96864874185c2 (diff) | |
download | rockbox-3b18158688415e311b2d5333cb4262912fb2a424.tar.gz rockbox-3b18158688415e311b2d5333cb4262912fb2a424.zip |
Fix FS#11387 - PictureFlow runs jerkily while playing music on Nano2G after the recent feature addition
The problem r26713 addressed was not caused by missing yields but by too high
priority of the background loader thread. Undoing the yield() change and decreasing
the priority fixes the audio drop as well but doesn't cause jerkiness.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30000 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps')
-rw-r--r-- | apps/plugins/pictureflow/pictureflow.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/apps/plugins/pictureflow/pictureflow.c b/apps/plugins/pictureflow/pictureflow.c index d26e6ead60..e93f2d2951 100644 --- a/apps/plugins/pictureflow/pictureflow.c +++ b/apps/plugins/pictureflow/pictureflow.c | |||
@@ -1330,8 +1330,7 @@ bool create_pf_thread(void) | |||
1330 | sizeof(thread_stack), | 1330 | sizeof(thread_stack), |
1331 | 0, | 1331 | 0, |
1332 | "Picture load thread" | 1332 | "Picture load thread" |
1333 | IF_PRIO(, MAX(PRIORITY_USER_INTERFACE / 2, | 1333 | IF_PRIO(, PRIORITY_BUFFERING) |
1334 | PRIORITY_REALTIME + 1)) | ||
1335 | IF_COP(, CPU) | 1334 | IF_COP(, CPU) |
1336 | ) | 1335 | ) |
1337 | ) == 0) { | 1336 | ) == 0) { |
@@ -1928,10 +1927,6 @@ void render_slide(struct slide_data *slide, const int alpha) | |||
1928 | pixel -= PIXELSTEP_Y; | 1927 | pixel -= PIXELSTEP_Y; |
1929 | } | 1928 | } |
1930 | } | 1929 | } |
1931 | rb->yield(); /* allow audio to play when fast scrolling */ | ||
1932 | bmp = surface(slide->slide_index); /* resync surface due to yield */ | ||
1933 | src = (pix_t*)(sizeof(struct dim) + (char *)bmp); | ||
1934 | ptr = &src[column * bmp->height]; | ||
1935 | p = (bmp->height-DISPLAY_OFFS) * PFREAL_ONE; | 1930 | p = (bmp->height-DISPLAY_OFFS) * PFREAL_ONE; |
1936 | plim = MIN(sh * PFREAL_ONE, p + (LCD_HEIGHT/2) * dy); | 1931 | plim = MIN(sh * PFREAL_ONE, p + (LCD_HEIGHT/2) * dy); |
1937 | int plim2 = MIN(MIN(sh + REFLECT_HEIGHT, sh * 2) * PFREAL_ONE, | 1932 | int plim2 = MIN(MIN(sh + REFLECT_HEIGHT, sh * 2) * PFREAL_ONE, |