diff options
author | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-11 04:41:36 +0000 |
---|---|---|
committer | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-11 04:41:36 +0000 |
commit | 45c7498f59ad2889f2120a865a51043004eddd5d (patch) | |
tree | 1a62b0e8549a7f2750679de8d7dd3f82039c5719 /apps/plugins/mpegplayer/idct_arm.S | |
parent | fe7ca44471b309a0adea563cce947de9efb62ab5 (diff) | |
download | rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.tar.gz rockbox-45c7498f59ad2889f2120a865a51043004eddd5d.zip |
FS#11335 by me: make ARM assembly functions thumb-friendly
We can't pop into pc on ARMv4t when using thumb: the T bit won't be
modified if we are returning to a thumb function
Code running on ARMv4t should use the new ldrpc / ldmpc macros instead
of ldr pc, [sp], #4 and ldm(cond) sp!, {regs, pc}
No modification on pure ARM builds and ARMv5+
Note: USE_THUMB is currently never defined, no targets can currently be
built with -mthumb, see FS#6734
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26756 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugins/mpegplayer/idct_arm.S')
-rw-r--r-- | apps/plugins/mpegplayer/idct_arm.S | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/apps/plugins/mpegplayer/idct_arm.S b/apps/plugins/mpegplayer/idct_arm.S index 7253d890bf..97a87a8b59 100644 --- a/apps/plugins/mpegplayer/idct_arm.S +++ b/apps/plugins/mpegplayer/idct_arm.S | |||
@@ -19,6 +19,8 @@ | |||
19 | * | 19 | * |
20 | ****************************************************************************/ | 20 | ****************************************************************************/ |
21 | 21 | ||
22 | #include "config.h" | ||
23 | |||
22 | .global mpeg2_idct_copy | 24 | .global mpeg2_idct_copy |
23 | .type mpeg2_idct_copy, %function | 25 | .type mpeg2_idct_copy, %function |
24 | .global mpeg2_idct_add | 26 | .global mpeg2_idct_add |
@@ -313,7 +315,7 @@ mpeg2_idct_copy: | |||
313 | add r1, r1, r2 | 315 | add r1, r1, r2 |
314 | cmp r0, r12 | 316 | cmp r0, r12 |
315 | blo 1b | 317 | blo 1b |
316 | ldmfd sp!, { r4-r11, pc } | 318 | ldmpc regs=r4-r11 |
317 | 319 | ||
318 | mpeg2_idct_add: | 320 | mpeg2_idct_add: |
319 | cmp r0, #129 | 321 | cmp r0, #129 |
@@ -385,7 +387,7 @@ mpeg2_idct_add: | |||
385 | add r1, r1, r2 | 387 | add r1, r1, r2 |
386 | cmp r0, r12 | 388 | cmp r0, r12 |
387 | blo 2b | 389 | blo 2b |
388 | ldmfd sp!, { r4-r11, pc } | 390 | ldmpc regs=r4-r11 |
389 | 3: | 391 | 3: |
390 | stmfd sp!, { r4-r5, lr } | 392 | stmfd sp!, { r4-r5, lr } |
391 | ldrsh r1, [r0, #0] /* r1 = block[0] */ | 393 | ldrsh r1, [r0, #0] /* r1 = block[0] */ |
@@ -438,4 +440,4 @@ mpeg2_idct_add: | |||
438 | add r2, r2, r3 | 440 | add r2, r2, r3 |
439 | cmp r2, r0 | 441 | cmp r2, r0 |
440 | blo 4b | 442 | blo 4b |
441 | ldmfd sp!, { r4-r5, pc } | 443 | ldmpc regs=r4-r5 |