diff options
author | Jens Arnold <amiconn@rockbox.org> | 2006-04-06 18:26:14 +0000 |
---|---|---|
committer | Jens Arnold <amiconn@rockbox.org> | 2006-04-06 18:26:14 +0000 |
commit | b509ff5069acc2d1c63ea501fbc27e08c7e263d3 (patch) | |
tree | cd14dbbd74636c4a80240445f25055e10ba4bf27 /apps/plugins/lib | |
parent | 930785cd8f68e0906d2a8d892d1db1d17dfc77e9 (diff) | |
download | rockbox-b509ff5069acc2d1c63ea501fbc27e08c7e263d3.tar.gz rockbox-b509ff5069acc2d1c63ea501fbc27e08c7e263d3.zip |
Patch #3022 by Mikael Magnusson: Only zero out the actual bss area instead of the whole plugiin buffer, for faster plugin loading. * Applied the same idea to the overlay loader.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9535 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugins/lib')
-rwxr-xr-x | apps/plugins/lib/overlay.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/apps/plugins/lib/overlay.c b/apps/plugins/lib/overlay.c index 31c2b00f91..91f08e23f0 100755 --- a/apps/plugins/lib/overlay.c +++ b/apps/plugins/lib/overlay.c | |||
@@ -85,7 +85,6 @@ enum plugin_status run_overlay(struct plugin_api* rb, void* parameter, | |||
85 | rb->splash(2*HZ, true, "%s overlay doesn't fit into memory.", name); | 85 | rb->splash(2*HZ, true, "%s overlay doesn't fit into memory.", name); |
86 | return PLUGIN_ERROR; | 86 | return PLUGIN_ERROR; |
87 | } | 87 | } |
88 | rb->memset(header.load_addr, 0, header.end_addr - header.load_addr); | ||
89 | 88 | ||
90 | fd = rb->open(filename, O_RDONLY); | 89 | fd = rb->open(filename, O_RDONLY); |
91 | if (fd < 0) | 90 | if (fd < 0) |
@@ -101,6 +100,10 @@ enum plugin_status run_overlay(struct plugin_api* rb, void* parameter, | |||
101 | rb->splash(2*HZ, true, "Reading %s overlay failed.", name); | 100 | rb->splash(2*HZ, true, "Reading %s overlay failed.", name); |
102 | return PLUGIN_ERROR; | 101 | return PLUGIN_ERROR; |
103 | } | 102 | } |
103 | /* Zero out bss area */ | ||
104 | rb->memset(header.load_addr + readsize, 0, | ||
105 | header.end_addr - (header.load_addr + readsize)); | ||
106 | |||
104 | return header.entry_point(rb, parameter); | 107 | return header.entry_point(rb, parameter); |
105 | } | 108 | } |
106 | #endif | 109 | #endif |