diff options
author | Jonathan Gordon <rockbox@jdgordon.info> | 2011-09-14 12:47:26 +0000 |
---|---|---|
committer | Jonathan Gordon <rockbox@jdgordon.info> | 2011-09-14 12:47:26 +0000 |
commit | 08d285b414627851ca49f89a49e085fac83f1e89 (patch) | |
tree | ff11cb6e45e7559caebdcd391930b73d4bd77e8c /apps/plugin.c | |
parent | da44fd6f994c601d30bf5896d03afd267feab37b (diff) | |
download | rockbox-08d285b414627851ca49f89a49e085fac83f1e89.tar.gz rockbox-08d285b414627851ca49f89a49e085fac83f1e89.zip |
Remove some old code which tries to clear/set the backdrop when starting plugins which is broken and potentially can cause backdrop corruption if the backdrop buffers move during the plugin lifetime
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30545 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugin.c')
-rw-r--r-- | apps/plugin.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/apps/plugin.c b/apps/plugin.c index 422749b533..2517a7183f 100644 --- a/apps/plugin.c +++ b/apps/plugin.c | |||
@@ -812,10 +812,6 @@ int plugin_load(const char* plugin, const void* parameter) | |||
812 | struct plugin_header *p_hdr; | 812 | struct plugin_header *p_hdr; |
813 | struct lc_header *hdr; | 813 | struct lc_header *hdr; |
814 | 814 | ||
815 | #if LCD_DEPTH > 1 | ||
816 | fb_data* old_backdrop; | ||
817 | #endif | ||
818 | |||
819 | if (current_plugin_handle && pfn_tsr_exit) | 815 | if (current_plugin_handle && pfn_tsr_exit) |
820 | { /* if we have a resident old plugin and a callback */ | 816 | { /* if we have a resident old plugin and a callback */ |
821 | if (pfn_tsr_exit(!strcmp(current_plugin, plugin)) == false ) | 817 | if (pfn_tsr_exit(!strcmp(current_plugin, plugin)) == false ) |
@@ -869,9 +865,6 @@ int plugin_load(const char* plugin, const void* parameter) | |||
869 | 865 | ||
870 | *(p_hdr->api) = &rockbox_api; | 866 | *(p_hdr->api) = &rockbox_api; |
871 | 867 | ||
872 | #if defined HAVE_LCD_BITMAP && LCD_DEPTH > 1 | ||
873 | old_backdrop = lcd_get_backdrop(); | ||
874 | #endif | ||
875 | lcd_clear_display(); | 868 | lcd_clear_display(); |
876 | lcd_update(); | 869 | lcd_update(); |
877 | 870 | ||
@@ -914,7 +907,6 @@ int plugin_load(const char* plugin, const void* parameter) | |||
914 | #ifdef HAVE_LCD_BITMAP | 907 | #ifdef HAVE_LCD_BITMAP |
915 | lcd_setfont(FONT_UI); | 908 | lcd_setfont(FONT_UI); |
916 | #if LCD_DEPTH > 1 | 909 | #if LCD_DEPTH > 1 |
917 | lcd_set_backdrop(old_backdrop); | ||
918 | #ifdef HAVE_LCD_COLOR | 910 | #ifdef HAVE_LCD_COLOR |
919 | lcd_set_drawinfo(DRMODE_SOLID, global_settings.fg_color, | 911 | lcd_set_drawinfo(DRMODE_SOLID, global_settings.fg_color, |
920 | global_settings.bg_color); | 912 | global_settings.bg_color); |
@@ -942,7 +934,7 @@ int plugin_load(const char* plugin, const void* parameter) | |||
942 | #endif | 934 | #endif |
943 | 935 | ||
944 | FOR_NB_SCREENS(i) | 936 | FOR_NB_SCREENS(i) |
945 | viewportmanager_theme_undo(i, false); | 937 | viewportmanager_theme_undo(i, true); |
946 | 938 | ||
947 | #ifdef HAVE_PLUGIN_CHECK_OPEN_CLOSE | 939 | #ifdef HAVE_PLUGIN_CHECK_OPEN_CLOSE |
948 | if(open_files != 0 && !current_plugin_handle) | 940 | if(open_files != 0 && !current_plugin_handle) |