diff options
author | Michael Sevakis <jethead71@rockbox.org> | 2017-01-30 09:52:05 -0500 |
---|---|---|
committer | Michael Sevakis <jethead71@rockbox.org> | 2017-02-11 22:19:32 -0500 |
commit | fc9695eb47732e1c189e2f033dbd55e5c346e8c4 (patch) | |
tree | 550830e9af67f47e3eb87587770b25d22110f57a /apps/debug_menu.c | |
parent | 6436c6e749ab04fbd5d97804a6a1c3b3122b326d (diff) | |
download | rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.tar.gz rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.zip |
Improve radio RDS driver and framework
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.
* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.
Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.
Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.
* Time out of stale text.
* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?
* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.
* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).
Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Diffstat (limited to 'apps/debug_menu.c')
-rw-r--r-- | apps/debug_menu.c | 24 |
1 files changed, 14 insertions, 10 deletions
diff --git a/apps/debug_menu.c b/apps/debug_menu.c index 000dbdc4fc..d761b9f868 100644 --- a/apps/debug_menu.c +++ b/apps/debug_menu.c | |||
@@ -127,10 +127,6 @@ | |||
127 | #include "iap.h" | 127 | #include "iap.h" |
128 | #endif | 128 | #endif |
129 | 129 | ||
130 | #ifdef HAVE_RDS_CAP | ||
131 | #include "rds.h" | ||
132 | #endif | ||
133 | |||
134 | #include "talk.h" | 130 | #include "talk.h" |
135 | 131 | ||
136 | static const char* threads_getname(int selected_item, void *data, | 132 | static const char* threads_getname(int selected_item, void *data, |
@@ -2166,17 +2162,25 @@ static int radio_callback(int btn, struct gui_synclist *lists) | |||
2166 | #endif /* TEA5760 */ | 2162 | #endif /* TEA5760 */ |
2167 | 2163 | ||
2168 | #ifdef HAVE_RDS_CAP | 2164 | #ifdef HAVE_RDS_CAP |
2169 | simplelist_addline("PI:%04X PS:'%8s'", | 2165 | { |
2170 | rds_get_pi(), rds_get_ps()); | 2166 | char buf[65*4]; |
2171 | simplelist_addline("RT:%s", | 2167 | uint16_t pi; |
2172 | rds_get_rt()); | 2168 | time_t seconds; |
2173 | time_t seconds = rds_get_ct(); | 2169 | |
2170 | tuner_get_rds_info(RADIO_RDS_NAME, buf, sizeof (buf)); | ||
2171 | tuner_get_rds_info(RADIO_RDS_PROGRAM_INFO, &pi, sizeof (pi)); | ||
2172 | simplelist_addline("PI:%04X PS:'%8s'", pi, buf); | ||
2173 | tuner_get_rds_info(RADIO_RDS_TEXT, buf, sizeof (buf)); | ||
2174 | simplelist_addline("RT:%s", buf); | ||
2175 | tuner_get_rds_info(RADIO_RDS_CURRENT_TIME, &seconds, sizeof (seconds)); | ||
2176 | |||
2174 | struct tm* time = gmtime(&seconds); | 2177 | struct tm* time = gmtime(&seconds); |
2175 | simplelist_addline( | 2178 | simplelist_addline( |
2176 | "CT:%4d-%02d-%02d %02d:%02d", | 2179 | "CT:%4d-%02d-%02d %02d:%02d", |
2177 | time->tm_year + 1900, time->tm_mon + 1, time->tm_mday, | 2180 | time->tm_year + 1900, time->tm_mon + 1, time->tm_mday, |
2178 | time->tm_hour, time->tm_min, time->tm_sec); | 2181 | time->tm_hour, time->tm_min, time->tm_sec); |
2179 | #endif | 2182 | } |
2183 | #endif /* HAVE_RDS_CAP */ | ||
2180 | return ACTION_REDRAW; | 2184 | return ACTION_REDRAW; |
2181 | } | 2185 | } |
2182 | static bool dbg_fm_radio(void) | 2186 | static bool dbg_fm_radio(void) |