summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Jarosch <tomj@simonv.com>2011-08-25 19:18:20 +0000
committerThomas Jarosch <tomj@simonv.com>2011-08-25 19:18:20 +0000
commit59b8c7816fde56a721dea6d25cf08d45e17e1ffd (patch)
tree2de3a632f80ec854283f48d768737580158fefb9
parent697aa7f4994651233bf5208877d58dbb1cec1974 (diff)
downloadrockbox-59b8c7816fde56a721dea6d25cf08d45e17e1ffd.tar.gz
rockbox-59b8c7816fde56a721dea6d25cf08d45e17e1ffd.zip
Fix off-by-one memory corruption in resistor plugin.
I'm wondering if that also was the cause for the lines exactly next to it: --------------------------------- /* This cleans out the mysterious garbage that appears */ rb->lcd_clear_display(); --------------------------------- -> Atleast I see no garbage in the sim. Credit for this bug goes to "cppcheck". git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30345 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/plugins/resistor.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/plugins/resistor.c b/apps/plugins/resistor.c
index a0bd94911a..06d3bf9d7a 100644
--- a/apps/plugins/resistor.c
+++ b/apps/plugins/resistor.c
@@ -801,8 +801,8 @@ static void resistance_to_color(void)
801 enum color units_used = 0; 801 enum color units_used = 0;
802 802
803 char out_str[20]; 803 char out_str[20];
804 804
805 for(i=0; i<=10; i++) { kbd_buffer[i] = 0; } 805 memset(kbd_buffer,0,sizeof(kbd_buffer));
806 /* This cleans out the mysterious garbage that appears */ 806 /* This cleans out the mysterious garbage that appears */
807 rb->lcd_clear_display(); 807 rb->lcd_clear_display();
808 rb->splash(HZ/2, "Resistance to Colour"); 808 rb->splash(HZ/2, "Resistance to Colour");